From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.7531.1574140954143064012 for ; Mon, 18 Nov 2019 21:22:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: eric.dong@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 21:22:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="215452385" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 18 Nov 2019 21:22:33 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 21:22:33 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 21:22:33 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Tue, 19 Nov 2019 13:22:30 +0800 From: "Dong, Eric" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH] UefiCpuPkg: Update the coding styles Thread-Topic: [PATCH] UefiCpuPkg: Update the coding styles Thread-Index: AQHVmuFEJYnFSKOHUkex8FKJDkGWJaeR/Mng Date: Tue, 19 Nov 2019 05:22:30 +0000 Message-ID: References: <20191114114644.5504-1-shenglei.zhang@intel.com> <20191114114644.5504-4-shenglei.zhang@intel.com> In-Reply-To: <20191114114644.5504-4-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjY5YWY5NTktYzcxZi00Nzc0LThjZTEtOGQ1NDcxOWFmNzY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaFFjaE5UMTkxMzljZTdzN1lVOWhtak81S0FveVRBbUJcLzR6ajN5N2k5NjdDblBUMGc3RXdlYmhSb29NOFIzXC9BIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, November 14, 2019 5:17 PM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Dong, Eric > ; Ni, Ray ; Laszlo Ersek > > Subject: [PATCH] UefiCpuPkg: Update the coding styles >=20 > From: Shenglei Zhang >=20 > In MpLib.c, remove the white space on a new line. > In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 49be5d5385d9..d32adf0780b7 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -475,7 +475,7 @@ CollectProcessorCount ( > CpuPause (); > } >=20 > - > + > // > // Enable x2APIC mode if > // 1. Number of CPU is greater than 255; or diff --git > a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c > index f891a811126f..2483f2ea849d 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c > @@ -342,7 +342,7 @@ RestoreCr2 ( >=20 > @retval TRUE Access to non-SMRAM is restricted. > @retval FALSE Access to non-SMRAM is not restricted. > -*/ > +**/ > BOOLEAN > IsRestrictedMemoryAccess ( > VOID > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > index e5c4788c13d7..810985df20ae 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > @@ -1275,7 +1275,7 @@ RestoreCr2 ( >=20 > @retval TRUE Access to non-SMRAM is restricted. > @retval FALSE Access to non-SMRAM is not restricted. > -*/ > +**/ > BOOLEAN > IsRestrictedMemoryAccess ( > VOID > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index daf977f654b4..7e7c73f27f76 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1455,7 +1455,7 @@ InitializeDataForMmMp ( >=20 > @retval TRUE Access to non-SMRAM is restricted. > @retval FALSE Access to non-SMRAM is not restricted. > -*/ > +**/ > BOOLEAN > IsRestrictedMemoryAccess ( > VOID > -- > 2.18.0.windows.1