Re: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 5:17 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for
> PCD
> 
> From: Shenglei Zhang <shenglei.zhang@intel.com>
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index
> a7e279c5cb14..bfd696f48c35 100644
> --- a/UefiCpuPkg/UefiCpuPkg.uni
> +++ b/UefiCpuPkg/UefiCpuPkg.uni
> @@ -195,6 +195,22 @@
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_HELP
> #language en-US "Indicates if the current boot is a power-on reset."
> 
> +#string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmRestrictedMemoryAccess_P
> ROMPT  #language en-US "Access to non-SMRAM memory is restricted to
> reserved, runtime and ACPI NVS type after SmmReadyToLock."
> +
> +#string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmRestrictedMemoryAccess_H
> ELP  #language en-US "Indicate access to non-SMRAM memory is restricted
> to reserved, runtime and ACPI NVS type after
> SmmReadyToLock.<BR><BR>\n"
> +
> "MMIO access is always allowed regardless of the value of this PCD.<BR>\n"
> +
> "Loose of such restriction is only required by RAS components in X64
> platforms.<BR>\n"
> +
> "The PCD value is considered as constantly TRUE in IA32 platforms.<BR>\n"
> +
> "When the PCD value is TRUE, page table is initialized to cover all memory
> spaces<BR>\n"
> +
> "and the memory occupied by page table is protected by page table itself as
> read-only.<BR>\n"
> +
> "In X64 build, it cannot be enabled at the same time with SMM profile
> feature (PcdCpuSmmProfileEnable).<BR>\n"
> +
> "In X64 build, it could not be enabled also at the same time with heap guard
> feature for SMM<BR>\n"
> +
> "(PcdHeapGuardPropertyMask in MdeModulePkg).<BR>\n"
> +
> "In IA32 build, page table memory is not marked as read-only when either
> SMM profile feature (PcdCpuSmmProfileEnable)<BR>\n"
> +
> "or heap guard feature for SMM (PcdHeapGuardPropertyMask in
> MdeModulePkg) is enabled.<BR>\n"
> +
> "TRUE  - Access to non-SMRAM memory is restricted to reserved, runtime
> and ACPI NVS type after SmmReadyToLock.<BR>\n"
> +
> "FALSE - Access to any type of non-SMRAM memory after SmmReadyToLock
> is allowed.<BR>"
> +
>  #string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_PROMPT
> #language en-US "Processor feature capabilities."
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_HELP
> #language en-US "Indicates processor feature capabilities, each bit
> corresponding to a specific feature."
> --
> 2.18.0.windows.1