From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.3625.1579047872835346249 for ; Tue, 14 Jan 2020 16:24:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: eric.dong@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 16:24:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,320,1574150400"; d="scan'208";a="213518426" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 14 Jan 2020 16:24:32 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jan 2020 16:24:31 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jan 2020 16:24:30 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.202]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.132]) with mapi id 14.03.0439.000; Wed, 15 Jan 2020 08:24:29 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Haug, Brian R" , "Gao, Liming" Subject: Re: [patch] MdeModulePkg/Setup: Update opcode number variable type to UINTN Thread-Topic: [patch] MdeModulePkg/Setup: Update opcode number variable type to UINTN Thread-Index: AQHVyriV34sAg42I40Cl6oYWPcrXYKfq3r3Q Date: Wed, 15 Jan 2020 00:24:29 +0000 Message-ID: References: <20200114085647.1796-1-dandan.bi@intel.com> In-Reply-To: <20200114085647.1796-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, January 14, 2020 4:57 PM > To: devel@edk2.groups.io > Cc: Haug, Brian R ; Gao, Liming > ; Dong, Eric > Subject: [patch] MdeModulePkg/Setup: Update opcode number variable > type to UINTN >=20 > From: Brian R Haug >=20 > Update data type of variables which save the opcode numbers to UINTN, in > case some configuration module has lots of configuration items. >=20 > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Brian R Haug > Reviewed-by: Dandan Bi > --- > .../Universal/SetupBrowserDxe/IfrParse.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c > b/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c > index 891b95cf9f..edb6a0fc4c 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c > @@ -1,17 +1,17 @@ > /** @file > Parser for IFR binary encoding. >=20 > -Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2007 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ >=20 > #include "Setup.h" >=20 > -UINT16 mStatementIndex; > -UINT16 mExpressionOpCodeIndex; > +UINTN mStatementIndex; > +UINTN mExpressionOpCodeIndex; > EFI_QUESTION_ID mUsedQuestionId; > extern LIST_ENTRY gBrowserStorageList; > /** > Initialize Statement header members. >=20 > @@ -1104,16 +1104,16 @@ IsUnKnownOpCode ( >=20 > **/ > VOID > CountOpCodes ( > IN FORM_BROWSER_FORMSET *FormSet, > - IN OUT UINT16 *NumberOfStatement, > - IN OUT UINT16 *NumberOfExpression > + OUT UINTN *NumberOfStatement, > + OUT UINTN *NumberOfExpression > ) > { > - UINT16 StatementCount; > - UINT16 ExpressionCount; > + UINTN StatementCount; > + UINTN ExpressionCount; > UINT8 *OpCodeData; > UINTN Offset; > UINTN OpCodeLen; >=20 > Offset =3D 0; > @@ -1167,12 +1167,12 @@ ParseOpCodes ( > FORMSET_STORAGE *Storage; > FORMSET_DEFAULTSTORE *DefaultStore; > QUESTION_DEFAULT *CurrentDefault; > QUESTION_OPTION *CurrentOption; > UINT8 Width; > - UINT16 NumberOfStatement; > - UINT16 NumberOfExpression; > + UINTN NumberOfStatement; > + UINTN NumberOfExpression; > EFI_IMAGE_ID *ImageId; > BOOLEAN SuppressForQuestion; > BOOLEAN SuppressForOption; > UINT16 DepthOfDisable; > BOOLEAN OpCodeDisabled; > -- > 2.18.0.windows.1