From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.1569.1580870597740634562 for ; Tue, 04 Feb 2020 18:43:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: eric.dong@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 18:43:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,404,1574150400"; d="scan'208";a="231579214" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 04 Feb 2020 18:43:16 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 18:43:16 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 18:43:16 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.126]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.138]) with mapi id 14.03.0439.000; Wed, 5 Feb 2020 10:43:14 +0800 From: "Dong, Eric" To: "devel@edk2.groups.io" , "Zeng, Star" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier Thread-Topic: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier Thread-Index: AQHV2ykLVktMr+y1ik6+QV+CrUwLPKgL5ZyQ Date: Wed, 5 Feb 2020 02:43:13 +0000 Message-ID: References: <20200204070204.41260-1-star.zeng@intel.com> In-Reply-To: <20200204070204.41260-1-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGU1YzQzMjQtMjNmOC00NmI3LWJiYzEtNzY2NTIwNTAxZWYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWkpuRHJhcmNYQTZXSldCUXF5OFwvTWVzc2t5V2k3Y0JxWnFZN3N4QmxWZ0phRzNQd0picW5CZlFRZlwvbjJyZk5JIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: devel@edk2.groups.io On Behalf Of Zeng, Star Sent: Tuesday, February 4, 2020 3:02 PM To: devel@edk2.groups.io Cc: Zeng, Star ; Dong, Eric ; Ni= , Ray ; Laszlo Ersek Subject: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match = data type and format specifier Match data type and format specifier for printing. 1. Type cast ProcessorNumber and FeatureIndex to UINT32 as %d only expects a UINT32. 2. Use %08x instead of %08lx for CacheControl to print Index as it is UINT32 type. 3. Use %016lx instead of %08lx for MemoryMapped to print (Index | LShiftU64 (HighIndex, 32)) as it is UINT64 type. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Star Zeng --- .../CpuFeaturesInitialize.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitiali= ze.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 0a4fcff033a3..fc96fb4372cf 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -430,8 +430,8 @@ DumpRegisterTableOnProcessor ( DEBUG (( DebugPrintErrorLevel, "Processor: %04d: Index %04d, MSR : %08x, Bit Start: %02d, Bit L= ength: %02d, Value: %016lx\r\n", - ProcessorNumber, - FeatureIndex, + (UINT32) ProcessorNumber, + (UINT32) FeatureIndex, RegisterTableEntry->Index, RegisterTableEntry->ValidBitStart, RegisterTableEntry->ValidBitLength, @@ -442,8 +442,8 @@ DumpRegisterTableOnProcessor ( DEBUG (( DebugPrintErrorLevel, "Processor: %04d: Index %04d, CR : %08x, Bit Start: %02d, Bit L= ength: %02d, Value: %016lx\r\n", - ProcessorNumber, - FeatureIndex, + (UINT32) ProcessorNumber, + (UINT32) FeatureIndex, RegisterTableEntry->Index, RegisterTableEntry->ValidBitStart, RegisterTableEntry->ValidBitLength, @@ -453,9 +453,9 @@ DumpRegisterTableOnProcessor ( case MemoryMapped: DEBUG (( DebugPrintErrorLevel, - "Processor: %04d: Index %04d, MMIO : %08lx, Bit Start: %02d, Bit = Length: %02d, Value: %016lx\r\n", - ProcessorNumber, - FeatureIndex, + "Processor: %04d: Index %04d, MMIO : %016lx, Bit Start: %02d, Bit= Length: %02d, Value: %016lx\r\n", + (UINT32) ProcessorNumber, + (UINT32) FeatureIndex, RegisterTableEntry->Index | LShiftU64 (RegisterTableEntry->HighIn= dex, 32), RegisterTableEntry->ValidBitStart, RegisterTableEntry->ValidBitLength, @@ -465,9 +465,9 @@ DumpRegisterTableOnProcessor ( case CacheControl: DEBUG (( DebugPrintErrorLevel, - "Processor: %04d: Index %04d, CACHE: %08lx, Bit Start: %02d, Bit = Length: %02d, Value: %016lx\r\n", - ProcessorNumber, - FeatureIndex, + "Processor: %04d: Index %04d, CACHE: %08x, Bit Start: %02d, Bit L= ength: %02d, Value: %016lx\r\n", + (UINT32) ProcessorNumber, + (UINT32) FeatureIndex, RegisterTableEntry->Index, RegisterTableEntry->ValidBitStart, RegisterTableEntry->ValidBitLength, @@ -478,8 +478,8 @@ DumpRegisterTableOnProcessor ( DEBUG (( DebugPrintErrorLevel, "Processor: %04d: Index %04d, SEMAP: %s\r\n", - ProcessorNumber, - FeatureIndex, + (UINT32) ProcessorNumber, + (UINT32) FeatureIndex, mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value, InvalidDep= Type)] )); break; --=20 2.21.0.windows.1