From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.8751.1582859130242753128 for ; Thu, 27 Feb 2020 19:05:30 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: eric.dong@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 19:05:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="232410310" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 27 Feb 2020 19:05:29 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Feb 2020 19:05:29 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.50]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.137]) with mapi id 14.03.0439.000; Fri, 28 Feb 2020 11:05:27 +0800 From: "Dong, Eric" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: Ard Biesheuvel , Igor Mammedov , "Yao, Jiewen" , "Justen, Jordan L" , "Kinney, Michael D" , =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v2 02/16] UefiCpuPkg/PiSmmCpuDxeSmm: fix S3 Resume for CPU hotplug Thread-Topic: [edk2-devel] [PATCH v2 02/16] UefiCpuPkg/PiSmmCpuDxeSmm: fix S3 Resume for CPU hotplug Thread-Index: AQHV7PHaDw0IiW64fEyfNmtV/GEfcagv6kEg Date: Fri, 28 Feb 2020 03:05:26 +0000 Message-ID: References: <20200226221156.29589-1-lersek@redhat.com> <20200226221156.29589-3-lersek@redhat.com> In-Reply-To: <20200226221156.29589-3-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTE5ZDA2NWQtOGVhZC00MTc4LWFmNDItZDcyYmZjMDM0MmRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTVpuUWNVSXhFVlhWRlpiZWcwbVJqdFRWZU1MQ1RcL2hYSFwvTHNtOEJNeTZQcFBXSGFlODd0OUYza2d5bGMxZjZNIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTGFzemxvLA0KDQpUaGFua3MgZm9yIHlvdXIgcGF0Y2guIFRoZSBjaGFuZ2UgbWFrZSBzZW5z ZSBiYXNlIG9uIHRoZSBjb21tZW50cyBpbiB0aGUgZGF0YSBzdHJ1Y3R1cmUgaGVhZGVyIGZpbGUu DQoNCkkgYWxzbyBjaGVja2VkIGFsbCB0aGUgY29kZSByZWxhdGVkIHRvIHRoaXMgZGF0YSBzdHJ1 Y3R1cmUuIFRoZSBpbnB1dHMgZm9yIHRoaXMgZGF0YSBzdHJ1Y3R1cmUgYXJlIENwdVMzRGF0YUR4 ZSBhbmQgUmVnaXN0ZXJDcHVGZWF0dXJlc0xpYi4gQm90aCB0aGVzZSB0d28gZHJpdmVycyBub3Qg c3VwcG9ydCBDUFUgaG90IHBsdWcgZmVhdHVyZSwgc28gdGhlIHJlYWwgaW5wdXRzIGZvciBtQWNw aUNwdURhdGEuTnVtYmVyT2ZDcHVzIGlzIHRoZSBlbmFibGVkIENQVSBudW1iZXIgaW4gdGhpcyBz eXN0ZW0uIFNvIGJlZm9yZSBhbmQgYWZ0ZXIgeW91ciBjb2RlIGNoYW5nZSwgdGhlIENQVSB2YWx1 ZXMgYXJlIHNhbWUuIEJ1dCB0aGUgZGF0YSBzdHJ1Y3R1cmUgY29tbWVudHMgc2FpZCBpdCBjYW4g c3VwcG9ydCBDUFUgaG90IHBsdWcsIHNvIEkgYWdyZWUgeW91ciBjb2RlIGNoYW5nZS4NCg0KUmV2 aWV3ZWQtYnk6IEVyaWMgRG9uZyA8ZXJpYy5kb25nQGludGVsLmNvbT4NCg0KVGhhbmtzLA0KRXJp Yw0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogZGV2ZWxAZWRrMi5ncm91cHMu aW8gPGRldmVsQGVkazIuZ3JvdXBzLmlvPiBPbiBCZWhhbGYgT2YgTGFzemxvIEVyc2VrDQpTZW50 OiBUaHVyc2RheSwgRmVicnVhcnkgMjcsIDIwMjAgNjoxMiBBTQ0KVG86IGVkazItZGV2ZWwtZ3Jv dXBzLWlvIDxkZXZlbEBlZGsyLmdyb3Vwcy5pbz4NCkNjOiBBcmQgQmllc2hldXZlbCA8YXJkLmJp ZXNoZXV2ZWxAbGluYXJvLm9yZz47IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb20+OyBJ Z29yIE1hbW1lZG92IDxpbWFtbWVkb0ByZWRoYXQuY29tPjsgWWFvLCBKaWV3ZW4gPGppZXdlbi55 YW9AaW50ZWwuY29tPjsgSnVzdGVuLCBKb3JkYW4gTCA8am9yZGFuLmwuanVzdGVuQGludGVsLmNv bT47IEtpbm5leSwgTWljaGFlbCBEIDxtaWNoYWVsLmQua2lubmV5QGludGVsLmNvbT47IFBoaWxp cHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT47IE5pLCBSYXkgPHJheS5uaUBp bnRlbC5jb20+DQpTdWJqZWN0OiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDAyLzE2XSBVZWZpQ3B1 UGtnL1BpU21tQ3B1RHhlU21tOiBmaXggUzMgUmVzdW1lIGZvciBDUFUgaG90cGx1Zw0KDQpUaGUg IkFDUElfQ1BVX0RBVEEuTnVtYmVyT2ZDcHVzIiBmaWVsZCBpcyBzcGVjaWZpZWQgYXMgZm9sbG93 cywgaW4gIlVlZmlDcHVQa2cvSW5jbHVkZS9BY3BpQ3B1RGF0YS5oIiAocmV3cmFwcGVkIGZvciB0 aGlzIGNvbW1pdCBtZXNzYWdlKToNCg0KICAvLw0KICAvLyBUaGUgbnVtYmVyIG9mIENQVXMuICBJ ZiBhIHBsYXRmb3JtIGRvZXMgbm90IHN1cHBvcnQgaG90IHBsdWcgQ1BVcywNCiAgLy8gdGhlbiB0 aGlzIGlzIHRoZSBudW1iZXIgb2YgQ1BVcyBkZXRlY3RlZCB3aGVuIHRoZSBwbGF0Zm9ybSBpcyBi b290ZWQsDQogIC8vIHJlZ2FyZGxlc3Mgb2YgYmVpbmcgZW5hYmxlZCBvciBkaXNhYmxlZC4gIElm IGEgcGxhdGZvcm0gZG9lcyBzdXBwb3J0DQogIC8vIGhvdCBwbHVnIENQVXMsIHRoZW4gdGhpcyBp cyB0aGUgbWF4aW11bSBudW1iZXIgb2YgQ1BVcyB0aGF0IHRoZQ0KICAvLyBwbGF0Zm9ybSBzdXBw b3J0cy4NCiAgLy8NCg0KVGhlIEluaXRpYWxpemVDcHVCZWZvcmVSZWJhc2UoKSBhbmQgSW5pdGlh bGl6ZUNwdUFmdGVyUmViYXNlKCkgZnVuY3Rpb25zIGluICJVZWZpQ3B1UGtnL1BpU21tQ3B1RHhl U21tL0NwdVMzLmMiIHRyeSB0byByZXN0b3JlIENQVSBjb25maWd1cmF0aW9uIG9uIHRoZSBTMyBS ZXN1bWUgcGF0aCBmb3IgKmFsbCogQ1BVcyBhY2NvdW50ZWQgZm9yIGluICJBQ1BJX0NQVV9EQVRB Lk51bWJlck9mQ3B1cyIuIFRoaXMgaXMgd3JvbmcsIGFzIHdpdGggQ1BVIGhvdHBsdWcsIG5vdCBh bGwgb2YgdGhlIHBvc3NpYmxlIENQVXMgbWF5IGJlIHByZXNlbnQgYXQgdGhlIHRpbWUgb2YgUzMg U3VzcGVuZCAvIFJlc3VtZS4NClRoZSBzeW1wdG9tIGlzIGFuIGluZmluaXRlIHdhaXQuDQoNCklu c3RlYWQsIHRoZSAibU51bWJlck9mQ3B1cyIgdmFyaWFibGUgc2hvdWxkIGJlIHVzZWQsIHdoaWNo IGlzIHByb3Blcmx5IG1haW50YWluZWQgdGhyb3VnaCB0aGUgRUZJX1NNTV9DUFVfU0VSVklDRV9Q Uk9UT0NPTCBpbXBsZW1lbnRhdGlvbiAoc2VlIFNtbUFkZFByb2Nlc3NvcigpLCBTbW1SZW1vdmVQ cm9jZXNzb3IoKSwgU21tQ3B1VXBkYXRlKCkgaW4gIlVlZmlDcHVQa2cvUGlTbW1DcHVEeGVTbW0v Q3B1U2VydmljZS5jIikuDQoNCldoZW4gQ1BVIGhvdHBsdWcgaXMgZGlzYWJsZWQsICJtTnVtYmVy T2ZDcHVzIiBpcyBjb25zdGFudCwgYW5kIGVxdWFscyAiQUNQSV9DUFVfREFUQS5OdW1iZXJPZkNw dXMiIGF0IGFsbCB0aW1lcy4NCg0KQ2M6IEFyZCBCaWVzaGV1dmVsIDxhcmQuYmllc2hldXZlbEBs aW5hcm8ub3JnPg0KQ2M6IEVyaWMgRG9uZyA8ZXJpYy5kb25nQGludGVsLmNvbT4NCkNjOiBJZ29y IE1hbW1lZG92IDxpbWFtbWVkb0ByZWRoYXQuY29tPg0KQ2M6IEppZXdlbiBZYW8gPGppZXdlbi55 YW9AaW50ZWwuY29tPg0KQ2M6IEpvcmRhbiBKdXN0ZW4gPGpvcmRhbi5sLmp1c3RlbkBpbnRlbC5j b20+DQpDYzogTWljaGFlbCBLaW5uZXkgPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPg0KQ2M6 IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4NCkNjOiBSYXkgTmkg PHJheS5uaUBpbnRlbC5jb20+DQpSZWY6IGh0dHBzOi8vYnVnemlsbGEudGlhbm9jb3JlLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUxMg0KU2lnbmVkLW9mZi1ieTogTGFzemxvIEVyc2VrIDxsZXJzZWtA cmVkaGF0LmNvbT4NCkFja2VkLWJ5OiBBcmQgQmllc2hldXZlbCA8YXJkLmJpZXNoZXV2ZWxAbGlu YXJvLm9yZz4NCi0tLQ0KDQpOb3RlczoNCiAgICB2MjoNCiAgICANCiAgICAtIFBpY2sgdXAgQXJk J3MgQWNrZWQtYnksIHdoaWNoIGlzIGNvbmRpdGlvbmFsIG9uIGFwcHJvdmFsIGZyb20gSW50ZWwN CiAgICAgIHJldmlld2VycyBvbiBDYy4gKEknZCBsaWtlIHRvIHNhdmUgQXJkIHRoZSBjaHVybiBv ZiByZS1hY2tpbmcNCiAgICAgIHVubW9kaWZpZWQgcGF0Y2hlcy4pDQoNCiBVZWZpQ3B1UGtnL1Bp U21tQ3B1RHhlU21tL0NwdVMzLmMgfCAxNCArKysrKysrKysrKystLQ0KIDEgZmlsZSBjaGFuZ2Vk LCAxMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvVWVmaUNw dVBrZy9QaVNtbUNwdUR4ZVNtbS9DcHVTMy5jIGIvVWVmaUNwdVBrZy9QaVNtbUNwdUR4ZVNtbS9D cHVTMy5jDQppbmRleCBiYTVjYzAxOTRjMmQuLjFlMDg0MDExOTcyNCAxMDA2NDQNCi0tLSBhL1Vl ZmlDcHVQa2cvUGlTbW1DcHVEeGVTbW0vQ3B1UzMuYw0KKysrIGIvVWVmaUNwdVBrZy9QaVNtbUNw dUR4ZVNtbS9DcHVTMy5jDQpAQCAtNTk3LDc1ICs1OTcsODUgQEAgUHJlcGFyZUFwU3RhcnR1cFZl Y3RvciAoICB9DQogDQogLyoqDQogICBUaGUgZnVuY3Rpb24gaXMgaW52b2tlZCBiZWZvcmUgU01C QVNFIHJlbG9jYXRpb24gaW4gUzMgcGF0aCB0byByZXN0b3JlcyBDUFUgc3RhdHVzLg0KIA0KICAg VGhlIGZ1bmN0aW9uIGlzIGludm9rZWQgYmVmb3JlIFNNQkFTRSByZWxvY2F0aW9uIGluIFMzIHBh dGguIEl0IGRvZXMgZmlyc3QgdGltZSBtaWNyb2NvZGUgbG9hZA0KICAgYW5kIHJlc3RvcmVzIE1U UlJzIGZvciBib3RoIEJTUCBhbmQgQVBzLg0KIA0KICoqLw0KIFZPSUQNCiBJbml0aWFsaXplQ3B1 QmVmb3JlUmViYXNlICgNCiAgIFZPSUQNCiAgICkNCiB7DQogICBMb2FkTXRyckRhdGEgKG1BY3Bp Q3B1RGF0YS5NdHJyVGFibGUpOw0KIA0KICAgU2V0UmVnaXN0ZXIgKFRSVUUpOw0KIA0KICAgUHJv Z3JhbVZpcnR1YWxXaXJlTW9kZSAoKTsNCiANCiAgIFByZXBhcmVBcFN0YXJ0dXBWZWN0b3IgKG1B Y3BpQ3B1RGF0YS5TdGFydHVwVmVjdG9yKTsNCiANCi0gIG1OdW1iZXJUb0ZpbmlzaCA9IG1BY3Bp Q3B1RGF0YS5OdW1iZXJPZkNwdXMgLSAxOw0KKyAgaWYgKEZlYXR1cmVQY2RHZXQgKFBjZENwdUhv dFBsdWdTdXBwb3J0KSkgew0KKyAgICBBU1NFUlQgKG1OdW1iZXJPZkNwdXMgPD0gbUFjcGlDcHVE YXRhLk51bWJlck9mQ3B1cyk7ICB9IGVsc2Ugew0KKyAgICBBU1NFUlQgKG1OdW1iZXJPZkNwdXMg PT0gbUFjcGlDcHVEYXRhLk51bWJlck9mQ3B1cyk7ICB9ICANCisgbU51bWJlclRvRmluaXNoID0g bU51bWJlck9mQ3B1cyAtIDE7DQogICBtRXhjaGFuZ2VJbmZvLT5BcEZ1bmN0aW9uICA9IChWT0lE ICopIChVSU5UTikgSW5pdGlhbGl6ZUFwOw0KIA0KICAgLy8NCiAgIC8vIEV4ZWN1dGUgY29kZSBm b3IgYmVmb3JlIFNtbUJhc2VSZWxvYy4gTm90ZTogVGhpcyBmbGFnIGlzIG1haW50YWluZWQgYWNy b3NzIFMzIGJvb3RzLg0KICAgLy8NCiAgIG1Jbml0QXBzQWZ0ZXJTbW1CYXNlUmVsb2MgPSBGQUxT RTsNCiANCiAgIC8vDQogICAvLyBTZW5kIElOSVQgSVBJIC0gU0lQSSB0byBhbGwgQVBzDQogICAv Lw0KICAgU2VuZEluaXRTaXBpU2lwaUFsbEV4Y2x1ZGluZ1NlbGYgKChVSU5UMzIpbUFjcGlDcHVE YXRhLlN0YXJ0dXBWZWN0b3IpOw0KIA0KICAgd2hpbGUgKG1OdW1iZXJUb0ZpbmlzaCA+IDApIHsN CiAgICAgQ3B1UGF1c2UgKCk7DQogICB9DQogfQ0KIA0KIC8qKg0KICAgVGhlIGZ1bmN0aW9uIGlz IGludm9rZWQgYWZ0ZXIgU01CQVNFIHJlbG9jYXRpb24gaW4gUzMgcGF0aCB0byByZXN0b3JlcyBD UFUgc3RhdHVzLg0KIA0KICAgVGhlIGZ1bmN0aW9uIGlzIGludm9rZWQgYWZ0ZXIgU01CQVNFIHJl bG9jYXRpb24gaW4gUzMgcGF0aC4gSXQgcmVzdG9yZXMgY29uZmlndXJhdGlvbiBhY2NvcmRpbmcg dG8NCiAgIGRhdGEgc2F2ZWQgYnkgbm9ybWFsIGJvb3QgcGF0aCBmb3IgYm90aCBCU1AgYW5kIEFQ cy4NCiANCiAqKi8NCiBWT0lEDQogSW5pdGlhbGl6ZUNwdUFmdGVyUmViYXNlICgNCiAgIFZPSUQN CiAgICkNCiB7DQotICBtTnVtYmVyVG9GaW5pc2ggPSBtQWNwaUNwdURhdGEuTnVtYmVyT2ZDcHVz IC0gMTsNCisgIGlmIChGZWF0dXJlUGNkR2V0IChQY2RDcHVIb3RQbHVnU3VwcG9ydCkpIHsNCisg ICAgQVNTRVJUIChtTnVtYmVyT2ZDcHVzIDw9IG1BY3BpQ3B1RGF0YS5OdW1iZXJPZkNwdXMpOyAg fSBlbHNlIHsNCisgICAgQVNTRVJUIChtTnVtYmVyT2ZDcHVzID09IG1BY3BpQ3B1RGF0YS5OdW1i ZXJPZkNwdXMpOyAgfSAgDQorIG1OdW1iZXJUb0ZpbmlzaCA9IG1OdW1iZXJPZkNwdXMgLSAxOw0K IA0KICAgLy8NCiAgIC8vIFNpZ25hbCB0aGF0IFNNTSBiYXNlIHJlbG9jYXRpb24gaXMgY29tcGxl dGUgYW5kIHRvIGNvbnRpbnVlIGluaXRpYWxpemF0aW9uIGZvciBhbGwgQVBzLg0KICAgLy8NCiAg IG1Jbml0QXBzQWZ0ZXJTbW1CYXNlUmVsb2MgPSBUUlVFOw0KIA0KICAgLy8NCiAgIC8vIE11c3Qg YmVnaW4gc2V0IHJlZ2lzdGVyIGFmdGVyIGFsbCBBUHMgaGF2ZSBjb250aW51ZSB0aGVpciBpbml0 aWFsaXphdGlvbi4NCiAgIC8vIFRoaXMgaXMgYSByZXF1aXJlbWVudCB0byBzdXBwb3J0IHNlbWFw aG9yZSBtZWNoYW5pc20gaW4gcmVnaXN0ZXIgdGFibGUuDQogICAvLyBCZWNhdXNlIGlmIHNlbWFw aG9yZSdzIGRlcGVuZGVuY2UgdHlwZSBpcyBwYWNrYWdlIHR5cGUsIHNlbWFwaG9yZSB3aWxsIHdh aXQNCiAgIC8vIGZvciBhbGwgQXBzIGluIG9uZSBwYWNrYWdlIGZpbmlzaGluZyB0aGVpciB0YXNr cyBiZWZvcmUgc2V0IG5leHQgcmVnaXN0ZXINCiAgIC8vIGZvciBhbGwgQVBzLiBJZiB0aGUgQXBz IG5vdCBiZWdpbiBpdHMgdGFzayBkdXJpbmcgQlNQIGRvaW5nIGl0cyB0YXNrLCB0aGUNCiAgIC8v IEJTUCB0aHJlYWQgd2lsbCBoYW5nIGJlY2F1c2UgaXQgaXMgd2FpdGluZyBmb3Igb3RoZXIgQXBz IGluIHRoZSBzYW1lDQogICAvLyBwYWNrYWdlIGZpbmlzaGluZyB0aGVpciB0YXNrLg0KICAgLy8N CiAgIFNldFJlZ2lzdGVyIChGQUxTRSk7DQogDQogICB3aGlsZSAobU51bWJlclRvRmluaXNoID4g MCkgew0KICAgICBDcHVQYXVzZSAoKTsNCiAgIH0NCiB9DQogDQotLQ0KMi4xOS4xLjMuZzMwMjQ3 YWE1ZDIwMQ0KDQoNCg0KDQoNCg==