Re: [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

["Dong, Eric" <eric.dong@intel.com>]

Hi Laszlo,

Reviewed-by: Eric Dong <eric.dong@intel.com>

Thanks,
Eric
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, February 27, 2020 6:12 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Dong, Eric
> <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Igor Mammedov
> <imammedo@redhat.com>; Wang, Jian J <jian.j.wang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Philippe Mathieu-Daudé
> <philmd@redhat.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start
> failure
> 
> In the CoreStartImage() function
> [MdeModulePkg/Core/Dxe/Image/Image.c], if the image entry point returns
> a failure code, then the DXE Core logs a helpful DEBUG_ERROR message,
> with the following format string:
> 
>   "Error: Image at %11p start failed: %r\n"
> 
> Do similarly in the SMM Core (update the message slightly).
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> 
> Notes:
>     v2:
> 
>     - Pick up Ard's Acked-by, which is conditional on approval from Intel
>       reviewers on Cc. (I'd like to save Ard the churn of re-acking
>       unmodified patches.)
> 
>  MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> index 9bec731e5312..76ee9e0b89cc 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> @@ -883,44 +883,50 @@ SmmDispatcher (
>        RemoveEntryList (&DriverEntry->ScheduledLink);
> 
>        REPORT_STATUS_CODE_WITH_EXTENDED_DATA (
>          EFI_PROGRESS_CODE,
>          EFI_SOFTWARE_SMM_DRIVER | EFI_SW_PC_INIT_BEGIN,
>          &DriverEntry->ImageHandle,
>          sizeof (DriverEntry->ImageHandle)
>          );
> 
>        //
>        // Cache state of SmmEntryPointRegistered before calling entry point
>        //
>        PreviousSmmEntryPointRegistered = gSmmCorePrivate-
> >SmmEntryPointRegistered;
> 
>        //
>        // For each SMM driver, pass NULL as ImageHandle
>        //
>        RegisterSmramProfileImage (DriverEntry, TRUE);
>        PERF_START_IMAGE_BEGIN (DriverEntry->ImageHandle);
>        Status = ((EFI_IMAGE_ENTRY_POINT)(UINTN)DriverEntry-
> >ImageEntryPoint)(DriverEntry->ImageHandle, gST);
>        PERF_START_IMAGE_END (DriverEntry->ImageHandle);
>        if (EFI_ERROR(Status)){
> +        DEBUG ((
> +          DEBUG_ERROR,
> +          "Error: SMM image at %11p start failed: %r\n",
> +          DriverEntry->SmmLoadedImage.ImageBase,
> +          Status
> +          ));
>          UnregisterSmramProfileImage (DriverEntry, TRUE);
>          SmmFreePages(DriverEntry->ImageBuffer, DriverEntry-
> >NumberOfPage);
>          //
>          // Uninstall LoadedImage
>          //
>          Status = gBS->UninstallProtocolInterface (
>                          DriverEntry->ImageHandle,
>                          &gEfiLoadedImageProtocolGuid,
>                          DriverEntry->LoadedImage
>                          );
>          if (!EFI_ERROR (Status)) {
>            if (DriverEntry->LoadedImage->FilePath != NULL) {
>              gBS->FreePool (DriverEntry->LoadedImage->FilePath);
>            }
>            gBS->FreePool (DriverEntry->LoadedImage);
>          }
>          Status = SmmUninstallProtocolInterface (
>                     DriverEntry->SmmImageHandle,
>                     &gEfiLoadedImageProtocolGuid,
>                     &DriverEntry->SmmLoadedImage
>                     );
>          if (!EFI_ERROR(Status)) {
> --
> 2.19.1.3.g30247aa5d201
>