From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.12123.1583332512692655365 for ; Wed, 04 Mar 2020 06:35:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.dong@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 06:35:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,514,1574150400"; d="scan'208";a="263618767" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 04 Mar 2020 06:35:10 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 06:35:10 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 06:35:09 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.50]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.137]) with mapi id 14.03.0439.000; Wed, 4 Mar 2020 22:35:07 +0800 From: "Dong, Eric" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue. Thread-Topic: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue. Thread-Index: AQHV8hnEgekHMsl+gkiNGs0to4g7EKg4f+aw Date: Wed, 4 Mar 2020 14:35:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmU0OWM2M2QtYWIxMi00MjA3LTkzMWUtNDNlZjdiM2VlZmE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGMrejZseW5mSGE0T2hvYnJQOVwvSTBoclBUQVh4UThQb0FLTzZ6TWx0ZWppZWNtT1d6aFdJclZ1bVYxU2NaMXkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: devel@edk2.groups.io On Behalf Of GuoMinJ Sent: Wednesday, March 4, 2020 7:39 PM To: devel@edk2.groups.io Cc: GuoMinJ ; Dong, Eric ; Ni= , Ray ; Laszlo Ersek Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2553 The comment haven't indicate the output attribute. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: GuoMinJ --- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/= MpInitLib/DxeMpLib.c index a987c32109..096d1c9b4b 100644 --- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c @@ -821,7 +821,7 @@ MpInitLibEnableDisableAP ( This funtion will try to invoke platform specific microcode shadow logi= c to relocate microcode update patches into memory. =20 - @param[in] CpuMpData The pointer to CPU MP Data structure. + @param[in, out] CpuMpData The pointer to CPU MP Data structure. =20 @retval EFI_SUCCESS Shadow microcode success. @retval EFI_OUT_OF_RESOURCES No enough resource to complete the ope= ration. diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpI= nitLib/MpLib.h index 455cb3f09a..06556197c3 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -658,7 +658,7 @@ GetProcessorNumber ( This funtion will try to invoke platform specific microcode shadow logi= c to relocate microcode update patches into memory. =20 - @param[in] CpuMpData The pointer to CPU MP Data structure. + @param[in, out] CpuMpData The pointer to CPU MP Data structure. =20 @retval EFI_SUCCESS Shadow microcode success. @retval EFI_OUT_OF_RESOURCES No enough resource to complete the ope= ration. diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/= MpInitLib/PeiMpLib.c index 17b60903c5..a548fed23f 100644 --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c @@ -644,7 +644,7 @@ MpInitLibEnableDisableAP ( This funtion will try to invoke platform specific microcode shadow logi= c to relocate microcode update patches into memory. =20 - @param[in] CpuMpData The pointer to CPU MP Data structure. + @param[in, out] CpuMpData The pointer to CPU MP Data structure. =20 @retval EFI_SUCCESS Shadow microcode success. @retval EFI_OUT_OF_RESOURCES No enough resource to complete the ope= ration. --=20 2.17.1