From: "Dong, Eric" <eric.dong@intel.com>
To: "Luo, Heng" <heng.luo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround
Date: Wed, 1 Apr 2020 04:36:38 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66225A01C018@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200331034913.1986-3-heng.luo@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Luo, Heng
> Sent: Tuesday, March 31, 2020 11:49 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to
> TemporaryBuildWorkaround
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
>
> Need to add LogoFeaturePkg to TemporaryBuildWorkaround because
> OpenBoard still includes TemporaryBuildWorkaround for building BIOS.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
>
> Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempora
> ryBuildWorkaround.dsc | 4 +++-
> Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempora
> ryBuildWorkaround.inf | 5 ++++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git
> a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> raryBuildWorkaround.dsc
> b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> raryBuildWorkaround.dsc
> index 227ae00908..c62f9ecc6e 100644
> ---
> a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> raryBuildWorkaround.dsc
> +++
> b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> ra
> +++ ryBuildWorkaround.dsc
> @@ -13,7 +13,7 @@
> # When the BaseTools update is complete, this file can entirely be removed
> # from this package. #-# Copyright (c) 2019, Intel Corporation. All rights
> reserved.<BR>+# Copyright (c) 2019 - 2020, Intel Corporation. All rights
> reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -49,6
> +49,8 @@
> gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable
> |FALSE
> gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable
> |FALSE
> gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnabl
> e |FALSE+ gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable
> |FALSE+ gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable
> |FALSE !endif #diff --git
> a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> raryBuildWorkaround.inf
> b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> raryBuildWorkaround.inf
> index 74176d1989..00818fbe0a 100644
> ---
> a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> raryBuildWorkaround.inf
> +++
> b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo
> ra
> +++ ryBuildWorkaround.inf
> @@ -13,7 +13,7 @@
> # When the BaseTools update is complete, this file can entirely be removed
> # from this package. #-# Copyright (c) 2019, Intel Corporation. All rights
> reserved.<BR>+# Copyright (c) 2019 - 2020, Intel Corporation. All rights
> reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -40,6
> +40,7 @@
> PowerManagement/S3FeaturePkg/S3FeaturePkg.dec
> SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
> UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec+
> UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec [FeaturePcd]
> gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable@@ -
> 49,6 +50,8 @@
> gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable
> gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable
> gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnabl
> e+ gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable+
> gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable [Sources]
> TemporaryBuildWorkaround.c--
> 2.24.0.windows.2
next prev parent reply other threads:[~2020-04-01 4:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 3:49 [Patch V2 0/3] Fix build error of OpenBoard Heng Luo
2020-03-31 3:49 ` [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path Heng Luo
2020-04-01 4:36 ` Dong, Eric
2020-04-01 6:04 ` Ni, Ray
2020-03-31 3:49 ` [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Heng Luo
2020-04-01 4:36 ` Dong, Eric [this message]
2020-03-31 3:49 ` [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Heng Luo
2020-04-01 4:36 ` Dong, Eric
2020-03-31 5:18 ` [edk2-devel] [Patch V2 0/3] Fix build error of OpenBoard Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E66225A01C018@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox