From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.114.1585715803013664988 for ; Tue, 31 Mar 2020 21:36:43 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: eric.dong@intel.com) IronPort-SDR: GPPY6bfJDd2bPtLWlUZWKLGFnols+aStGYasWk6tIxaO0nTYGMHiEQJ3OWPDgUGXSite17/w/g azGiLUL26bTA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 21:36:42 -0700 IronPort-SDR: cJlWnY/iHw3D+tPsxQqIQaWUPKsDkNmD/4Ws5zcMX4u16bp7Le2s3DyF5x5T2WnyJhnHC7Zb6j Vs5LuRm3VpMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,330,1580803200"; d="scan'208";a="284253207" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 31 Mar 2020 21:36:42 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 21:36:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 21:36:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.138]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.209]) with mapi id 14.03.0439.000; Wed, 1 Apr 2020 12:36:39 +0800 From: "Dong, Eric" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Ni, Ray" Subject: Re: [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Thread-Topic: [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Thread-Index: AQHWBw9nHHlhb7DAN0C3ga3C6whqPqhjsByA Date: Wed, 1 Apr 2020 04:36:38 +0000 Message-ID: References: <20200331034913.1986-1-heng.luo@intel.com> <20200331034913.1986-3-heng.luo@intel.com> In-Reply-To: <20200331034913.1986-3-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Luo, Heng > Sent: Tuesday, March 31, 2020 11:49 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > Subject: [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to > TemporaryBuildWorkaround >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 >=20 > Need to add LogoFeaturePkg to TemporaryBuildWorkaround because > OpenBoard still includes TemporaryBuildWorkaround for building BIOS. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Heng Luo > --- >=20 > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempora > ryBuildWorkaround.dsc | 4 +++- > Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempora > ryBuildWorkaround.inf | 5 ++++- > 2 files changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > raryBuildWorkaround.dsc > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > raryBuildWorkaround.dsc > index 227ae00908..c62f9ecc6e 100644 > --- > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > raryBuildWorkaround.dsc > +++ > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > ra > +++ ryBuildWorkaround.dsc > @@ -13,7 +13,7 @@ > # When the BaseTools update is complete, this file can entirely be remov= ed > # from this package. #-# Copyright (c) 2019, Intel Corporation. All right= s > reserved.
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -49,6 > +49,8 @@ > gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > |FALSE > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > |FALSE > gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnabl > e |FALSE+ gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable > |FALSE+ gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable > |FALSE !endif #diff --git > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > raryBuildWorkaround.inf > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > raryBuildWorkaround.inf > index 74176d1989..00818fbe0a 100644 > --- > a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > raryBuildWorkaround.inf > +++ > b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tempo > ra > +++ ryBuildWorkaround.inf > @@ -13,7 +13,7 @@ > # When the BaseTools update is complete, this file can entirely be remov= ed > # from this package. #-# Copyright (c) 2019, Intel Corporation. All right= s > reserved.
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -40,6 > +40,7 @@ > PowerManagement/S3FeaturePkg/S3FeaturePkg.dec > SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec > UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec+ > UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec [FeaturePcd] > gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable@@ - > 49,6 +50,8 @@ > gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnabl > e+ gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable+ > gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable [Sources] > TemporaryBuildWorkaround.c-- > 2.24.0.windows.2