From: "Dong, Eric" <eric.dong@intel.com>
To: "Luo, Heng" <heng.luo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes
Date: Wed, 1 Apr 2020 04:36:45 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66225A01C028@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200331034913.1986-4-heng.luo@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Luo, Heng
> Sent: Tuesday, March 31, 2020 11:49 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 3/3] Features/Intel: Correct wrong codes and remove
> unnecessary codes
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644
>
> Correct wrong codes and remove unnecessary codes in LogoFeaturePkg.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
> Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9
> ---------
> Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf | 2
> +-
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git
> a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> index fca0bfd540..d2dcdeb36a 100644
> ---
> a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc
> +++
> b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.ds
> +++ c
> @@ -25,15 +25,6 @@
> !error "DXE_ARCH must be specified to build this feature!" !endif -
> ##########################################################
> ######################-#-# Packages Section - Make sure PCD can be
> directly used in a conditional statement-# in a DSC which includes this DSC
> file.-#-
> ##########################################################
> ######################-[Packages]-
> LogoFeaturePkg/LogoFeaturePkg.dec-
> ##########################################################
> ###################### # # Library Class section - list of all Library
> Classes needed by this feature.diff --git
> a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> index 080c87223c..fead9f3b02 100644
> ---
> a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> +++
> b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf
> @@ -6,7 +6,7 @@
> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##-!if
> gSmbiosFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE+!if
> gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable == TRUE INF
> LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf !else INF
> LogoFeaturePkg/LogoDxe/LogoDxe.inf--
> 2.24.0.windows.2
next prev parent reply other threads:[~2020-04-01 4:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 3:49 [Patch V2 0/3] Fix build error of OpenBoard Heng Luo
2020-03-31 3:49 ` [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path Heng Luo
2020-04-01 4:36 ` Dong, Eric
2020-04-01 6:04 ` Ni, Ray
2020-03-31 3:49 ` [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Heng Luo
2020-04-01 4:36 ` Dong, Eric
2020-03-31 3:49 ` [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Heng Luo
2020-04-01 4:36 ` Dong, Eric [this message]
2020-03-31 5:18 ` [edk2-devel] [Patch V2 0/3] Fix build error of OpenBoard Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E66225A01C028@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox