From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.116.1585715810401259789 for ; Tue, 31 Mar 2020 21:36:50 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.dong@intel.com) IronPort-SDR: /58tnVVRyGNjERkZbw3PaIJ2JAs7t0Oz9nDjPv+/BTl7IuvMc7wNGRaYDdfhR0dUrZJ/iSeDro nO4+B+lAq8CQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 21:36:49 -0700 IronPort-SDR: MRRfdO+zT3zVTstEMEn384HvGnEhMA7lz5E40/efmqknVLgFsD1C35j4Rq5OMOohKyZ323PNSD nUx5u5TZborw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,330,1580803200"; d="scan'208";a="284253228" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 31 Mar 2020 21:36:49 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 21:36:49 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 31 Mar 2020 21:36:48 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 31 Mar 2020 21:36:48 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.138]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.191]) with mapi id 14.03.0439.000; Wed, 1 Apr 2020 12:36:46 +0800 From: "Dong, Eric" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Ni, Ray" Subject: Re: [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Thread-Topic: [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Thread-Index: AQHWBw9y/cavGrZI7UigFUarOnN+/KhjsCdQ Date: Wed, 1 Apr 2020 04:36:45 +0000 Message-ID: References: <20200331034913.1986-1-heng.luo@intel.com> <20200331034913.1986-4-heng.luo@intel.com> In-Reply-To: <20200331034913.1986-4-heng.luo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Luo, Heng > Sent: Tuesday, March 31, 2020 11:49 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > Subject: [Patch V2 3/3] Features/Intel: Correct wrong codes and remove > unnecessary codes >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 >=20 > Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Signed-off-by: Heng Luo > --- > Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9 > --------- > Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf | 2 > +- > 2 files changed, 1 insertion(+), 10 deletions(-) >=20 > diff --git > a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > index fca0bfd540..d2dcdeb36a 100644 > --- > a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc > +++ > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.ds > +++ c > @@ -25,15 +25,6 @@ > !error "DXE_ARCH must be specified to build this feature!" !endif - > ########################################################## > ######################-#-# Packages Section - Make sure PCD can be > directly used in a conditional statement-# in a DSC which includes this D= SC > file.-#- > ########################################################## > ######################-[Packages]- > LogoFeaturePkg/LogoFeaturePkg.dec- > ########################################################## > ###################### # # Library Class section - list of all Library > Classes needed by this feature.diff --git > a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > index 080c87223c..fead9f3b02 100644 > --- > a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > +++ > b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf > @@ -6,7 +6,7 @@ > # SPDX-License-Identifier: BSD-2-Clause-Patent # ##-!if > gSmbiosFeaturePkgTokenSpaceGuid.PcdJpgEnable =3D=3D TRUE+!if > gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable =3D=3D TRUE INF > LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf !else INF > LogoFeaturePkg/LogoDxe/LogoDxe.inf-- > 2.24.0.windows.2