From: "Dong, Eric" <eric.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>
Cc: "Ni, Ray" <ray.ni@intel.com>,
"Kumar, Chandana C" <chandana.c.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.
Date: Thu, 23 Apr 2020 00:58:20 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66225A02F29E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <3c028212-e539-53bf-c883-bdbc518ff5fd@redhat.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, April 23, 2020 5:41 AM
> To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Kumar, Chandana C
> <chandana.c.kumar@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT
> context for APs.
>
> Eric,
>
> On 04/22/20 11:01, Dong, Eric wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
>
> I don't know what patches I'm supposed to review now. You seem to have
> sent 4 (four) versions of this patch set to the list, but you didn't call them {v1,
> v2, v3, v4}; you called them {v1, v2, v2, v2}. I can only work off of the
> dates/times at which you sent the paches.
Laszlo,
Sorry, It's my mistake to send out error patches. I have send out patch three times:
1) Send v1 patch set.
2) Try to send V2 patch set, but I missed the "V2" tag for the 1/2 and 2/2 patches, just add it to 0/2.
3) only send 1/2 and 2/2 of V2 patch and add "V2" tag on these two patches.
So please just review the patches which has V2 tag and ignore the other error patches.
Thanks,
Eric
>
> To make the confusion worse:
>
> - your third (v3?) posting says "0/2" in the cover letter, but I can only see one
> patch below it.
>
> - your last (v4?) posting (that I can see) doesn't even have a cover letter.
>
> (a) [edk2-devel] [PATCH 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP
> procedure.
> https://edk2.groups.io/g/devel/message/57772
>
> Date: Wed, 22 Apr 2020 09:34:54 +0800
>
> (b) [edk2-devel] [PATCH v2 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP
> procedure
> https://edk2.groups.io/g/devel/message/57786
>
> Date: Wed, 22 Apr 2020 16:45:56 +0800
> (~7 hours after (a))
>
> (c) [edk2-devel] [PATCH v2 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP
> procedure
> https://edk2.groups.io/g/devel/message/57791
>
> Date: Wed, 22 Apr 2020 16:52:51 +0800
> (~7 minutes after (b))
>
> (d) [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context
> for APs.
> https://edk2.groups.io/g/devel/message/57794
>
> Date: Wed, 22 Apr 2020 17:01:10 +0800
> (~8 minutes after (c))
>
> And your latest comment on the bugzilla ticket, at
> <https://bugzilla.tianocore.org/show_bug.cgi?id=2683#c2>, seems to
> indicate that (b) is what you consider the most up-to-date version. But you
> send two versions ((c) and (d)) after that.
>
> I think I won't review any of these patches now.
>
> (I don't even know under which I should send this response.)
>
> Thanks
> Laszlo
>
>
>
next prev parent reply other threads:[~2020-04-23 0:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 9:01 [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs Dong, Eric
2020-04-22 9:01 ` [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI Dong, Eric
2020-04-22 11:23 ` Ni, Ray
2020-04-24 16:39 ` [edk2-devel] " Laszlo Ersek
2020-04-22 11:47 ` [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs Ni, Ray
2020-04-24 16:37 ` [edk2-devel] " Laszlo Ersek
2020-04-22 21:41 ` Laszlo Ersek
2020-04-23 0:58 ` Dong, Eric [this message]
2020-04-24 16:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E66225A02F29E@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox