From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.1641.1588728688919918819 for ; Tue, 05 May 2020 18:31:29 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: eric.dong@intel.com) IronPort-SDR: xiT9tiBVA+P7lCmLiLVdHX1/syR1402o2w7napkmhzR47TGehEkmcF5uzB82BQhJXvhepet4MU Ec74jYmc33ig== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 18:31:25 -0700 IronPort-SDR: bJtcTVON11N439G2YztIEvSy0191D0KjXdKFxpNbcWPS0/pfMZWYGoxnCnjskYKrfEbJINjd+H zIFBIOSMC08w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,357,1583222400"; d="scan'208,217";a="251064322" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 05 May 2020 18:31:22 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 18:31:23 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 5 May 2020 18:31:21 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 5 May 2020 18:31:21 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.38]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.210]) with mapi id 14.03.0439.000; Wed, 6 May 2020 09:31:19 +0800 From: "Dong, Eric" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Ni, Ray" CC: Leo Duran Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h Thread-Index: AQHWGCj9sDK0i+j3MEOcuz/APh22WaiE10YAgBTaPoCAAKlH4A== Date: Wed, 6 May 2020 01:31:19 +0000 Message-ID: References: <1587506704-2232-1-git-send-email-leo.duran@amd.com> <28114eaf-fa05-0c50-4648-3b1b35f850e1@redhat.com> <6be78f19-09d1-0811-2155-d62937680903@redhat.com> In-Reply-To: <6be78f19-09d1-0811-2155-d62937680903@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: eric.dong@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_ED077930C258884BBCB450DB737E66225A05AC18shsmsx102ccrcor_" --_000_ED077930C258884BBCB450DB737E66225A05AC18shsmsx102ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Eric Dong Hi Laszlo, I saw you already provided Review-by tag and I can't verify the change, so= I don't add comments for this patch. I will provide Acked-by tag for the similar case next time. I have pushed this change. Thanks, Eric From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Lasz= lo Ersek Sent: Wednesday, May 6, 2020 7:22 AM To: devel@edk2.groups.io; Dong, Eric ; Ni, Ray Cc: Leo Duran Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable = attribute from MpLib.h Eric, Ray, can one of you please approve, and also merge, this patch? It's been on the list for two weeks now (and you were CC'd). I didn't want to go ahead and merge it myself without at least an ACK from one of you. Thanks Laszlo On 04/22/20 18:55, Laszlo Ersek wrote: > On 04/22/20 00:05, Leo Duran wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2678 >> >> This patch fixes a file permission issue introduced by accident. >> >> Cc: Eric Dong > >> Cc: Ray Ni > >> Cc: Laszlo Ersek > >> Signed-off-by: Leo Duran > >> --- >> UefiCpuPkg/Library/MpInitLib/MpLib.h | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> mode change 100755 =3D> 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/= MpInitLib/MpLib.h >> old mode 100755 >> new mode 100644 >> > > Reviewed-by: Laszlo Ersek > > > Thanks, Leo! > Laszlo > > > > --_000_ED077930C258884BBCB450DB737E66225A05AC18shsmsx102ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Acked-by: Eric Dong <eric.dong@in= tel.com>

 

Hi Laszlo,

 

I saw you already provided Review-by= tag and I can’t verify the change, so I don’t add comments for= this patch.

 

I will provide Acked-by tag for the = similar case next time.

 

I have pushed this change.

 

Thanks,

Eric

From: devel@edk2.groups.io [mailto:= devel@edk2.groups.io] On Behalf Of Laszlo Ersek
Sent: Wednesday, May 6, 2020 7:22 AM
To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; N= i, Ray <ray.ni@intel.com>
Cc: Leo Duran <leo.duran@amd.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Exec= utable attribute from MpLib.h

 

Eric, Ray,

can one of you please = ;approve, and also merge, this patch?

It's been on the list = ;for two weeks now (and you were CC'd).&= nbsp;I didn't
want to go ahead and = merge it myself without at least an ACK&= nbsp;from one of
you.

Thanks
Laszlo

On 04/22/20 18:55, Laszlo = ;Ersek wrote:
> On 04/22/20 00:05, Leo=  Duran wrote:
>> REF: https://bugzilla.tianocore.org/s= how_bug.cgi?id=3D2678
>>
>> This patch fixes a=  file permission issue introduced by accident= .
>>
>> Cc: Eric Dong <= eric.dong@intel.com> >> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Laszlo Ersek &= lt;lersek@redhat.com> >> Signed-off-by: Leo Dura= n <leo.duran@amd.com>
>> ---
>>  UefiCpuPkg/Library/MpInitLi= b/MpLib.h | 0
>>  1 file changed,&n= bsp;0 insertions(+), 0 deletions(-)
>>  mode change 10075= 5 =3D> 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h=
>>
>> diff --git a/UefiCpuPkg= /Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
>> old mode 100755<= br> >> new mode 100644<= br> >>
> 
> Reviewed-by: Laszlo Ersek=  <lersek@redhat.com>
> 
> Thanks, Leo!
> Laszlo
> 
> 
> 
> 


--_000_ED077930C258884BBCB450DB737E66225A05AC18shsmsx102ccrcor_--