public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jianyong Wu <Jianyong.Wu@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	Justin He <Justin.He@arm.com>
Subject: Re: [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib
Date: Tue, 6 Sep 2022 07:45:55 +0000	[thread overview]
Message-ID: <EDBFE7F4-4B9E-44F5-802A-0C6E44E35BD3@arm.com> (raw)
In-Reply-To: <20220906073921.90729-1-jianyong.wu@arm.com>

Hi Jianyong,

If you push your branch with these patches to Github, then you could do a draft pull request to check that your patches pass the edk2 CI.

I normally include the link for my Github branch in the cover letter. This also helps the reviewer to apply the patches locally, if the mail client damages the patches by changing line breaks etc.

Regards,

Sami Mujawar


On 06/09/2022, 08:39, "Jianyong Wu" <jianyong.wu@arm.com> wrote:

    Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory
    layout for cloud hypervisor is changed, it needs a new meminfo lib.

    Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>

    Jianyong Wu (2):
      CloudHv/arm: add PeiMemInfoLib
      CloudHv/arm: switch PeiMemLib to its own

     ArmVirtPkg/ArmVirtCloudHv.dsc                 |   2 +-
     .../CloudHvVirtMemInfoLib.c                   | 243 ++++++++++++++++++
     .../CloudHvVirtMemInfoLib.h                   |  42 +++
     .../CloudHvVirtMemInfoPeiLib.inf              |  47 ++++
     4 files changed, 333 insertions(+), 1 deletion(-)
     create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
     create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h
     create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf

    --
    2.17.1


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  parent reply	other threads:[~2022-09-06  7:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  7:39 [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib Jianyong Wu
2022-09-06  7:39 ` [PATCH v4 1/2] CloudHv/arm: add PeiMemInfoLib Jianyong Wu
2022-09-06  7:39 ` [PATCH v4 2/2] CloudHv/arm: switch PeiMemLib to its own Jianyong Wu
2022-09-06  7:45 ` Sami Mujawar [this message]
2022-09-06  9:07   ` [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib Jianyong Wu
2022-09-06 16:55     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EDBFE7F4-4B9E-44F5-802A-0C6E44E35BD3@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox