public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Joey Gouly <Joey.Gouly@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "ray.ni@intel.com" <ray.ni@intel.com>, nd <nd@arm.com>,
	"zhichao.gao@intel.com" <zhichao.gao@intel.com>
Subject: Re: [PATCH v1 1/4] ShellPkg: Rename Address Size to Access size
Date: Thu, 15 Apr 2021 12:28:39 +0000	[thread overview]
Message-ID: <EE224A1F-3429-4B31-85E0-C849CC8091CA@arm.com> (raw)
In-Reply-To: <20210415121720.11553-2-joey.gouly@arm.com>

Adding Zhichao.

Regards,

Sami Mujawar

On 15/04/2021, 13:19, "Joey Gouly" <joey.gouly@arm.com> wrote:

    This matches the ACPI spec 6.3, table 5.1: Generic Address Structure.

    Signed-off-by: Joey Gouly <joey.gouly@arm.com>
    ---
     ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
    index 01ac9a9bafeb2ca12c1ba19f406d626b108f5fe2..74056e72c359c732758563a9fe14ff2582f39f21 100644
    --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
    +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
    @@ -1,7 +1,7 @@
     /** @file
       ACPI parser

    -  Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
    +  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
       SPDX-License-Identifier: BSD-2-Clause-Patent
     **/

    @@ -628,7 +628,7 @@ STATIC CONST ACPI_PARSER GasParser[] = {
       {L"Address Space ID", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
       {L"Register Bit Width", 1, 1, L"0x%x", NULL, NULL, NULL, NULL},
       {L"Register Bit Offset", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
    -  {L"Address Size", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
    +  {L"Access Size", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
       {L"Address", 8, 4, L"0x%lx", NULL, NULL, NULL, NULL}
     };

    -- 
    Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



  reply	other threads:[~2021-04-15 12:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 12:17 [PATCH v1 0/4] DynamicTablesPkg: Add access size parameter for serial ports Joey Gouly
2021-04-15 12:17 ` [PATCH v1 1/4] ShellPkg: Rename Address Size to Access size Joey Gouly
2021-04-15 12:28   ` Sami Mujawar [this message]
     [not found]   ` <167607D852D7D23D.10637@groups.io>
2021-04-16 11:43     ` [edk2-devel] " Sami Mujawar
2021-04-19  3:17       ` Gao, Zhichao
2021-04-15 12:17 ` [PATCH v1 2/4] DynamicTablesPkg: Add access size to CM_ARM_SERIAL_PORT_INFO Joey Gouly
2021-04-16 11:51   ` Sami Mujawar
2021-04-15 12:17 ` [PATCH v1 3/4] DynamicTablesPkg: Set the Access size for the SPCR table Joey Gouly
2021-04-16 11:51   ` Sami Mujawar
2021-04-15 12:17 ` [PATCH v1 4/4] DynamicTablesPkg: Set the Access size for the DBG2 table Joey Gouly
2021-04-16 11:52   ` Sami Mujawar
2021-04-19 14:37 ` [PATCH v1 0/4] DynamicTablesPkg: Add access size parameter for serial ports Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EE224A1F-3429-4B31-85E0-C849CC8091CA@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox