Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo

["Dongyan Qian" <qiandongyan@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 2390 bytes --]

Hi Liming,

Please can you give me a review?

Thanks
Dongyan

> 2024年1月16日 20:11，Chao Li <lichao@loongson.cn> 写道：
> 
> Looks good to me.
> 
> Reviewed-by: Chao Li <lichao@loongson.cn> <mailto:lichao@loongson.cn>
> Hi Liming,
> 
> Please help review this patch.
> 
> 
> Thanks,
> Chao
> On 2024/1/16 15:11, Dongyan Qian wrote:
>> This fixes messages like:
>> "Image type X64 can't be loaded on <Unknown> UEFI system"
>> 
>> Cc: Liming Gao <gaoliming@byosoft.com.cn> <mailto:gaoliming@byosoft.com.cn>
>> Cc: Chao Li <lichao@loongson.cn> <mailto:lichao@loongson.cn>
>> Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn> <mailto:qiandongyan@loongson.cn>
>> ---
>>  MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>> 
>> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c
>> index 6bc3a549ae..66d9840b7b 100644
>> --- a/MdeModulePkg/Core/Dxe/Image/Image.c
>> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c
>> @@ -77,12 +77,13 @@ typedef struct {
>>  } MACHINE_TYPE_INFO;
>>  
>>  GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] = {
>> -  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
>> -  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
>> -  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
>> -  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
>> -  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
>> -  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
>> +  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
>> +  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
>> +  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
>> +  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
>> +  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
>> +  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
>> +  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
>>  };
>>  
>>  UINT16  mDxeCoreImageMachineType = 0;
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114865): https://edk2.groups.io/g/devel/message/114865
Mute This Topic: https://groups.io/mt/103757732/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4270 bytes --]