From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0326C941547 for ; Wed, 31 Jan 2024 07:01:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tT9V8GBr9PFSpp8FwvLC316B7o/ajNgri0Kkwm9gbXQ=; c=relaxed/simple; d=groups.io; h=From:Message-Id:Mime-Version:Subject:Date:In-Reply-To:Cc:To:References:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706684459; v=1; b=Yf51UW1rtO2bRfOThmx/M0wVgrCA4hjO3bGnHHZas+NrhH7wYV+L6Tpqj9x20DdUHMIg6liz +Zo5jRvO3CcT2hhXswOpaSvqlooZMdp/si5tR/quSUAcitwo7fCm1+8edQtJ4csZK7Rq1gSR07n UPsSHsgnxmDqnOMaR5vJtJq4= X-Received: by 127.0.0.2 with SMTP id HuxqYY7687511xNOzc0ZBabS; Tue, 30 Jan 2024 23:00:59 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.9026.1706684457820375351 for ; Tue, 30 Jan 2024 23:00:58 -0800 X-Received: from loongson.cn (unknown [112.96.225.56]) by gateway (Coremail) with SMTP id _____8BxC+kl8LllwM0IAA--.7031S3; Wed, 31 Jan 2024 15:00:53 +0800 (CST) X-Received: from smtpclient.apple (unknown [112.96.225.56]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxvhMf8LllVbApAA--.41236S3; Wed, 31 Jan 2024 15:00:49 +0800 (CST) From: "Dongyan Qian" Message-Id: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Date: Wed, 31 Jan 2024 15:00:47 +0800 In-Reply-To: <747a22f8-8c4b-44cf-bb64-07d6a97b0175@loongson.cn> Cc: lichao@loongson.cn To: devel@edk2.groups.io, Liming Gao References: <20240116071133.38331-1-qiandongyan@loongson.cn> <747a22f8-8c4b-44cf-bb64-07d6a97b0175@loongson.cn> X-CM-TRANSID: AQAAf8DxvhMf8LllVbApAA--.41236S3 X-CM-SenderInfo: htld0v5rqj5t3q6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoW7tw1xWFW7KFWxJF1UAF1kJFc_yoW8CF15pF 18Z3s8Ka4Iq3yjkay8Xr1jqr18ArZ7XrZ7Xan7tw4UC3sYya4jg3yrZ3WSgr48JF4DKa1j v34rC34Iq3WUJ3cCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ34c02F40En4AKxVAvwIkv4cxYr27v73VFW2AGmfu7bjvjm3AaLaJ3UjIY CTnIWjp_UUUYx7kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcI k0rVWrJVCq3wAFIxvE14AKwVWUGVWUXwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK 021l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40En4AKxVAvwIkv4cxYr24lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCjr7xvwVCIw2I0I7 xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG 67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17MI IYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E 14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJV W8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07j8iSdU UUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,qiandongyan@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0Vx0uceHlFt0llJXYefQ6ZQjx7686176AA= Content-Type: multipart/alternative; boundary="Apple-Mail=_34CCF67F-EBB1-4C74-BED5-5DE0FA534195" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Yf51UW1r; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --Apple-Mail=_34CCF67F-EBB1-4C74-BED5-5DE0FA534195 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Liming, Please can you give me a review? Thanks Dongyan > 2024=E5=B9=B41=E6=9C=8816=E6=97=A5 20:11=EF=BC=8CChao Li =E5=86=99=E9=81=93=EF=BC=9A >=20 > Looks good to me. >=20 > Reviewed-by: Chao Li > Hi Liming, >=20 > Please help review this patch. >=20 >=20 > Thanks, > Chao > On 2024/1/16 15:11, Dongyan Qian wrote: >> This fixes messages like: >> "Image type X64 can't be loaded on UEFI system" >>=20 >> Cc: Liming Gao >> Cc: Chao Li >> Signed-off-by: Dongyan Qian >> --- >> MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >>=20 >> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe= /Image/Image.c >> index 6bc3a549ae..66d9840b7b 100644 >> --- a/MdeModulePkg/Core/Dxe/Image/Image.c >> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c >> @@ -77,12 +77,13 @@ typedef struct { >> } MACHINE_TYPE_INFO; >> =20 >> GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO mMachineTypeInfo[] =3D= { >> - { EFI_IMAGE_MACHINE_IA32, L"IA32" }, >> - { EFI_IMAGE_MACHINE_IA64, L"IA64" }, >> - { EFI_IMAGE_MACHINE_X64, L"X64" }, >> - { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM" }, >> - { EFI_IMAGE_MACHINE_AARCH64, L"AARCH64" }, >> - { EFI_IMAGE_MACHINE_RISCV64, L"RISCV64" }, >> + { EFI_IMAGE_MACHINE_IA32, L"IA32" }, >> + { EFI_IMAGE_MACHINE_IA64, L"IA64" }, >> + { EFI_IMAGE_MACHINE_X64, L"X64" }, >> + { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM" }, >> + { EFI_IMAGE_MACHINE_AARCH64, L"AARCH64" }, >> + { EFI_IMAGE_MACHINE_RISCV64, L"RISCV64" }, >> + { EFI_IMAGE_MACHINE_LOONGARCH64, L"LOONGARCH64" }, >> }; >> =20 >> UINT16 mDxeCoreImageMachineType =3D 0; >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114865): https://edk2.groups.io/g/devel/message/114865 Mute This Topic: https://groups.io/mt/103757732/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --Apple-Mail=_34CCF67F-EBB1-4C74-BED5-5DE0FA534195 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi Liming,
=
Please can you give me a review?

Thanks
= Dongyan

2024=E5=B9=B41=E6=9C=8816=E6=97=A5 20:11=EF=BC=8CChao= Li <lichao@loongson.cn= > =E5=86=99=E9=81=93=EF=BC=9A

=20

Looks good to m= e.

Reviewed-by: Chao Li= <= lichao@loongson.cn>

Hi Liming,

Please help review this patc= h.


Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:<= br class=3D""> 
This fixes messages like:
"Image type X64 can't be loaded on <Unknown> UEFI system"

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 MdeModulePkg/Core/Dxe/Image/Image.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Im=
age/Image.c
index 6bc3a549ae..66d9840b7b 100644
--- a/MdeModulePkg/Core/Dxe/Image/Image.c
+++ b/MdeModulePkg/Core/Dxe/Image/Image.c
@@ -77,12 +77,13 @@ typedef struct {
 } MACHINE_TYPE_INFO;
=20
 GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] =3D {
-  { EFI_IMAGE_MACHINE_IA32,           L"IA32"    },
-  { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
-  { EFI_IMAGE_MACHINE_X64,            L"X64"     },
-  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
-  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
-  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
+  { EFI_IMAGE_MACHINE_IA32,           L"IA32"        },
+  { EFI_IMAGE_MACHINE_IA64,           L"IA64"        },
+  { EFI_IMAGE_MACHINE_X64,            L"X64"         },
+  { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"         },
+  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64"     },
+  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64"     },
+  { EFI_IMAGE_MACHINE_LOONGARCH64,    L"LOONGARCH64" },
 };
=20
 UINT16  mDxeCoreImageMachineType =3D 0;
=20

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#114865) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--Apple-Mail=_34CCF67F-EBB1-4C74-BED5-5DE0FA534195--