Re: [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()

["Marvin Häuser" <mhaeuser@posteo.de>]

> On 17. Feb 2023, at 21:14, Pedro Falcato <pedro.falcato@gmail.com> wrote:
> 
> @@ -169,5 +170,20 @@ Ext4StrCmpInsensitive (
>   IN CHAR16  *Str2
>   )
> {
> +  ASSERT (gUnicodeCollationInterface != NULL);
>   return gUnicodeCollationInterface->StriColl (gUnicodeCollationInterface, Str1, Str2);
> }

Off-topic (should merge either way), but is there a reason such a function is not in BaseLib?
@Ard Do you happen to know?

> /**
> @@ -761,6 +753,19 @@ Ext4Bind (
>   BlockIo = NULL;
>   DiskIo  = NULL;
> 
> +  // Note: We initialize collation here since this is called in BDS, when we are likely
> +  // to have the Unicode Collation protocols available.
> +  if (!Ext4IsCollationInitialized ()) {

Why do we need to expose this? I.e., why can't this be an internal decision of Ext4InitialiseUnicodeCollation()?

> +    Status = Ext4InitialiseUnicodeCollation (BindingProtocol->ImageHandle);