From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web11.10546.1676723463058309432
 for <devel@edk2.groups.io>;
 Sat, 18 Feb 2023 04:31:03 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=Qal5JxrB;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 1599F2400A6
	for <devel@edk2.groups.io>; Sat, 18 Feb 2023 13:31:00 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1676723461; bh=yTBBWDzWjRd90mXzVyPx8gHNB0gj+W2/StzV+eYFXYM=;
	h=Subject:From:Date:Cc:To:From;
	b=Qal5JxrBRzh7fYjKpjm3u3/sm+ERqyWvf9I5WBr63zyy8ici4sRKtasn4x9bZ0M+P
	 UzLIIZx8vvT9xfHnK7m9/X6rUch/RSJqeK5cktDN1a2K0IXf+fRMtMqN5plB5FByrl
	 uVs9ibLImVhWUC3Gi/pVFWLTUVoFz8ZPAisG6PZ6O45sciCkdZzgqs7rpOhcRZDtDG
	 QvrIhxgRVvuNlDXFN0d2Em7xqwgwaVMOCV+ZR6pBjL3WWPIavwYMqz4cUCq8SJw8XS
	 Cit/t4rLkZLxy+y7cbcuZHauT/NZU3E74RWOQO7lyjn7MIU/AlOmqlpHHKims4vudO
	 QVNXWnXW1gYrg==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4PJp1v6z72z9rxR;
	Sat, 18 Feb 2023 13:30:59 +0100 (CET)
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\))
Subject: Re: [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
In-Reply-To: <20230217201427.139581-1-pedro.falcato@gmail.com>
Date: Sat, 18 Feb 2023 12:30:49 +0000
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
 Ard Biesheuvel <ardb@kernel.org>
Message-Id: <EF2BDE6E-B565-423C-B05C-8B9DE2231DF5@posteo.de>
References: <20230217201427.139581-1-pedro.falcato@gmail.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable


> On 17. Feb 2023, at 21:14, Pedro Falcato <pedro.falcato@gmail.com> =
wrote:
>=20
> @@ -169,5 +170,20 @@ Ext4StrCmpInsensitive (
>   IN CHAR16  *Str2
>   )
> {
> +  ASSERT (gUnicodeCollationInterface !=3D NULL);
>   return gUnicodeCollationInterface->StriColl =
(gUnicodeCollationInterface, Str1, Str2);
> }

Off-topic (should merge either way), but is there a reason such a =
function is not in BaseLib?
@Ard Do you happen to know?

> /**
> @@ -761,6 +753,19 @@ Ext4Bind (
>   BlockIo =3D NULL;
>   DiskIo  =3D NULL;
>=20
> +  // Note: We initialize collation here since this is called in BDS, =
when we are likely
> +  // to have the Unicode Collation protocols available.
> +  if (!Ext4IsCollationInitialized ()) {

Why do we need to expose this? I.e., why can't this be an internal =
decision of Ext4InitialiseUnicodeCollation()?

> +    Status =3D Ext4InitialiseUnicodeCollation =
(BindingProtocol->ImageHandle);