From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: tien.hock.loh@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 09 May 2019 02:05:54 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 02:05:53 -0700 X-ExtLoop1: 1 Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203]) by fmsmga001.fm.intel.com with ESMTP; 09 May 2019 02:05:51 -0700 Received: from pgsmsx110.gar.corp.intel.com ([169.254.13.159]) by pgsmsx114.gar.corp.intel.com ([169.254.4.194]) with mapi id 14.03.0415.000; Thu, 9 May 2019 17:05:28 +0800 From: "Loh, Tien Hock" To: "Wu, Hao A" , "devel@edk2.groups.io" , "thloh85@gmail.com" CC: tien.hock.loh , "Wang, Jian J" , "Zhu, Yonghong" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI Thread-Topic: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI Thread-Index: AQHVBMV7rVAdP7oim0CMB/jOf2hXeqZh04IAgACvXyA= Date: Thu, 9 May 2019 09:05:27 +0000 Message-ID: References: <1557227281-170969-1-git-send-email-tien.hock.loh@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGM5M2MyMDgtNTcxMS00ZGVjLTk3OTYtY2U0MmI1MjI3MjhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMDRxYzJoVjIyWGdxYm5kZDRod0YzYkh3eVQ5WEZueXJhZWFCWWFjMzRYSXFlZ2xQUitcL0hPZnpkWElRTDhIb3gifQ== x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, May 9, 2019 2:37 PM > To: devel@edk2.groups.io; Loh, Tien Hock ; > thloh85@gmail.com > Cc: tien.hock.loh ; Wang, Jian J > ; Zhu, Yonghong > Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg: > BaseSerialPortLib16550: Update Mmio32 to UNI >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Loh, Tien Hock > > Sent: Tuesday, May 07, 2019 7:08 PM > > To: devel@edk2.groups.io; thloh85@gmail.com > > Cc: tien.hock.loh; Loh, Tien Hock; Wang, Jian J; Wu, Hao A; Zhu, > > Yonghong > > Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: > BaseSerialPortLib16550: > > Update Mmio32 to UNI > > >=20 > Hello Tien Hock, >=20 > > From: "tien.hock.loh" >=20 > Is the above information automatically generated when formatting the > patch? > It seems a bit weird to me. Yeah, must be a broken config. I'll fix this. >=20 > Also, could you help to add the Bugzilla link reference information in t= he > commit message? Like: >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1771 OK noted. Will generate a patch v2.=20 >=20 > > > > Some busses doesn't allow 8 bit MMIO read/write, this adds support for > > 32 bits read/write. This patch adds the UNI information on the new Pcd > > introduced - PcdSerialRegisterAccessWidth > > > > Signed-off-by: "Tien Hock, Loh" > > Cc: Jian J Wang > > Cc: Hao Wu > > Cc: "Zhu, YongHong" > > > > Signed-off-by: tien.hock.loh >=20 > There are 2 'Signed-off' tags here, could you help to cleanup to drop th= e > unneeded one? Yeah, I must've broken my config. I'll fix and send a new patch.=20 >=20 > > --- > > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.uni > > b/MdeModulePkg/MdeModulePkg.uni index cf2aefa7ad..654dfeadb0 > 100644 > > --- a/MdeModulePkg/MdeModulePkg.uni > > +++ b/MdeModulePkg/MdeModulePkg.uni > > @@ -160,6 +160,12 @@ > > > > "TRUE - 16550 serial port registers are in MMIO space.
\n" > > > > "FALSE - 16550 serial port registers are in I/O space.
" > > > > +#string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_PR > O > > MPT #language en-US "Serial port registers access width" > > + > > +#string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HE > LP > > #language en-US "Sets the 16550 serial port registers access width in > > MMIO space. Default is 8 bits access.

\n" >=20 > IMO, you can directly use the text: > 'Indicates the access width for 16550 serial port registers.' > in MdeModulePkg.dec here for > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HE > LP. >=20 > > + > > + "8 - 16550 serial port > > MMIO register access are in 8 bits mode.
\n" > > + > > + "32 - 16550 serial port > > MMIO registers acess are in 32 bits mode..
" >=20 > acess -> access > Please also help to remove the extra '.' for the above line. >=20 > Best Regards, > Hao Wu >=20 > > + > > #string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowContr > ol_P > > ROMPT #language en-US "Enable serial port hardware flow control" > > > > #string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowContr > ol_ > > HELP #language en-US "Indicates if the 16550 serial port hardware > > flow control will be enabled. Default is FALSE.

\n" > > -- > > 2.13.0 > > > > > >=20