From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: tien.hock.loh@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 11 Sep 2019 21:59:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 21:59:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,495,1559545200"; d="scan'208";a="209891666" Received: from pgsmsx112-dag.png.intel.com (HELO PGSMSX112.gar.corp.intel.com) ([10.108.55.234]) by fmsmga004.fm.intel.com with ESMTP; 11 Sep 2019 21:59:25 -0700 Received: from pgsmsx106.gar.corp.intel.com (10.221.44.98) by PGSMSX112.gar.corp.intel.com (10.108.55.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Sep 2019 12:59:16 +0800 Received: from pgsmsx110.gar.corp.intel.com ([169.254.13.150]) by PGSMSX106.gar.corp.intel.com ([169.254.9.23]) with mapi id 14.03.0439.000; Thu, 12 Sep 2019 12:59:16 +0800 From: "Loh, Tien Hock" To: Haojian Zhuang , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" , "christopher.Co@microsoft.com" CC: "devel@edk2.groups.io" , "thloh85@gmail.com" Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver Thread-Topic: [PATCH v2 0/3] add DwMmcHcDxe driver Thread-Index: AQHVQgHjv9n2w3nTgkexcjW/jhKm4abiR+kAgBnGCbCAG8pEAIAP8Svw Date: Thu, 12 Sep 2019 04:59:15 +0000 Message-ID: References: <20190724092606.185319-1-tien.hock.loh@intel.com> <20190730073300.GH6058@gmail.com> <20190902093116.GA29393@hackbox2.linaro.org> In-Reply-To: <20190902093116.GA29393@hackbox2.linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY1YTI0ZmMtMDFjMS00MmJhLTllNWItOWU5ZmEzNGNmOGJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9pSTFHdFVDNU9SSUd5cVBFSzBYbDZSQkJlT1dzeVhpWVdJemRFUHU2SWZaMERDUURrYjF4S3NhamFRNGZNNmQifQ== x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Return-Path: tien.hock.loh@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard, Leif, Christopher, Any comments on the patches? Thanks! Tien Hock=20 > -----Original Message----- > From: Haojian Zhuang > Sent: Monday, September 2, 2019 5:31 PM > To: Loh, Tien Hock > Cc: leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > christopher.Co@microsoft.com; devel@edk2.groups.io; thloh85@gmail.com > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver >=20 > Hi Leif, Ard, Christopher, >=20 > Could you help to share the comments on this patch set? Thanks a lot. >=20 > Best Regards > Haojian >=20 > On Thu, Aug 15, 2019 at 09:09:19AM +0000, Loh, Tien Hock wrote: > > Hi Leif, Ard, Christopher, > > > > Haojian and I have tested the driver on 2 platforms, any further commen= ts > on this? > > > > Thanks > > Tien Hock > > > > > -----Original Message----- > > > From: Haojian Zhuang > > > Sent: Tuesday, July 30, 2019 3:33 PM > > > To: Loh, Tien Hock ; > > > leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; > > > christopher.Co@microsoft.com > > > Cc: devel@edk2.groups.io; thloh85@gmail.com > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > > > On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock.loh@intel.com > wrote: > > > > From: "Tien Hock, Loh" > > > > > > > > Changelog: > > > > v3: > > > > * Fix an issue in NonDiscoverableDeviceDxe driver where it did > > > > not > > > invalidate > > > > cache before copying the memory. > > > > v2: > > > > *Split DwMmcHcDxe driver into two patches. One is for > > > > PlatformDwMmc > > > protocol, > > > > and the other is for DwMmcHcDxe driver. > > > > v1: > > > > *Add NonDiscoverableDeviceDxe for embedded platform. Make > > > DwMmcHcDxe driver > > > > to support both eMMC and SD controller. > > > > > > > > Haojian Zhuang (3): > > > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > > > > EmbeddedPkg: add PlatformDwMmc protocol > > > > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > > > > > > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 > > > +++++++++ > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 > ++++++ > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 > > > +++++++++++++++++ > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 +++++++ > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 > ++++++++ > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > > > > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > > > > .../NonDiscoverableDeviceDxe.c | 243 ++ > > > > .../NonDiscoverableDeviceDxe.inf | 52 + > > > > .../NonDiscoverableDeviceIo.c | 976 +++++++ > > > > .../NonDiscoverableDeviceIo.h | 92 + > > > > 16 files changed, 9495 insertions(+) create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > > > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > > > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > > > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > > > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > > > > create mode 100644 > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > > > > create mode 100644 > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > > > > create mode 100644 > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > eDx > > > > e.c create mode 100644 > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > eDx > > > > e.inf create mode 100644 > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > eIo > > > > .c create mode 100644 > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > eIo > > > > .h > > > > > > > > -- > > > > 2.19.0 > > > > > > > > > > Hi Leif, Ard & Chris, > > > > > > Could you help to share your comments on this patch set? > > > > > > Best Regards > > > Haojian