[PATCH 1/3] Maintainers.txt: List Tianocore Stewards

[PATCH 1/3] Maintainers.txt: List Tianocore Stewards

[Jordan Justen]

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
 Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 9d1b9fb941..a5e2e0af46 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -34,6 +34,12 @@ T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
 T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
 T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
 
+Tianocore Stewards
+------------------
+M: Andrew Fish <afish@apple.com>
+M: Leif Lindholm <leif.lindholm@linaro.org>
+M: Michael D Kinney <michael.d.kinney@intel.com>
+
 Responsible Disclosure, Reporting Security Issues
 -------------------------------------------------
 W: https://github.com/tianocore/tianocore.github.io/wiki/Security
-- 
2.14.0

[PATCH 2/3] Maintainers.txt: Update Package Maintainer description

[Jordan Justen]

Add note that the Package Maintainer is responsible for reviewing and
pushing package changes to source control.

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
 Maintainers.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index a5e2e0af46..92a1fd974f 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -11,7 +11,8 @@ Descriptions of section entries:
 
   L: Mailing list that is relevant to this area (default is edk2-devel)
      Patches and questions should be sent to the email list.
-  M: Cc address for patches and questions (ie, the package maintainer)
+  M: Package Maintainer: Cc address for patches and questions. Responsible
+     for reviewing and pushing package changes to source control.
   W: Web-page with status/info
   T: SCM tree type and location.  Type is one of: git, svn.
   S: Status, one of the following:
-- 
2.14.0

[PATCH 3/3] Maintainers.txt: Add Package Reviewer role

[Jordan Justen]

Although everyone is encouraged to review patches and add their
Reviewed-by reply for a patch, with the Package Reviewer role we
identify additional community members that will be Cc'd for patches
made to a package.

A distinction between a Package Maintainer and Reviewer is that
Maintainers will always have source control push access to the package
whereas Reviewers will not. (The Reviewer may have push access if they
are also Package Maintainer for another package.)

Currently we have an limit of 2 Package Maintainers per package, but
the Package Maintainers for each package decide how to manage the
Package Reviewer list.

Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
 Maintainers.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 92a1fd974f..6317a392e7 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -5,7 +5,8 @@ This file provides information about the primary maintainers for
 EDK II.
 
 In general, you should not privately email the maintainer. You should
-email the edk2-devel list, but you can also Cc the maintainer.
+email the edk2-devel list, and Cc the package maintainers and
+reviewers.
 
 Descriptions of section entries:
 
@@ -13,6 +14,8 @@ Descriptions of section entries:
      Patches and questions should be sent to the email list.
   M: Package Maintainer: Cc address for patches and questions. Responsible
      for reviewing and pushing package changes to source control.
+  R: Package Reviewer: Cc address for patches and questions. Reviewers help
+     maintainers review code, but don't have push access.
   W: Web-page with status/info
   T: SCM tree type and location.  Type is one of: git, svn.
   S: Status, one of the following:
-- 
2.14.0

Re: [PATCH 1/3] Maintainers.txt: List Tianocore Stewards

[Leif Lindholm]

I don't actually have a strong opinion that the number of maintainers
per package need to be kept at 2, and I'm not sure we have actually
codified that anywhere. But I also don't have any issues with any of
the changes suggested in this series.

So, in order to keep the noise down, for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

On Thu, Aug 10, 2017 at 03:11:27PM -0700, Jordan Justen wrote:
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 9d1b9fb941..a5e2e0af46 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -34,6 +34,12 @@ T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
>  T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>  T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
>  
> +Tianocore Stewards
> +------------------
> +M: Andrew Fish <afish@apple.com>
> +M: Leif Lindholm <leif.lindholm@linaro.org>
> +M: Michael D Kinney <michael.d.kinney@intel.com>
> +
>  Responsible Disclosure, Reporting Security Issues
>  -------------------------------------------------
>  W: https://github.com/tianocore/tianocore.github.io/wiki/Security
> -- 
> 2.14.0
> 

Re: [PATCH 1/3] Maintainers.txt: List Tianocore Stewards

[Kinney, Michael D]

Series 

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Justen, Jordan L
> Sent: Thursday, August 10, 2017 3:11 PM
> To: edk2-devel@lists.01.org
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH 1/3] Maintainers.txt: List Tianocore Stewards
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 9d1b9fb941..a5e2e0af46 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -34,6 +34,12 @@ T: git (mirror) -
> https://bitbucket.org/tianocore/edk2.git
>  T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>  T: svn (read-only, deprecated) -
> https://svn.code.sf.net/p/edk2/code/trunk/edk2
> 
> +Tianocore Stewards
> +------------------
> +M: Andrew Fish <afish@apple.com>
> +M: Leif Lindholm <leif.lindholm@linaro.org>
> +M: Michael D Kinney <michael.d.kinney@intel.com>
> +
>  Responsible Disclosure, Reporting Security Issues
>  -------------------------------------------------
>  W:
> https://github.com/tianocore/tianocore.github.io/wiki/Security
> --
> 2.14.0

Re: [PATCH 1/3] Maintainers.txt: List Tianocore Stewards

[Andrew Fish]

Series

Reviewed-by: Andrew Fish <afish@apple.com <mailto:afish@apple.com>>

> On Aug 10, 2017, at 4:13 PM, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> 
> Series 
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
>> -----Original Message-----
>> From: Justen, Jordan L
>> Sent: Thursday, August 10, 2017 3:11 PM
>> To: edk2-devel@lists.01.org
>> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
>> <afish@apple.com>; Leif Lindholm <leif.lindholm@linaro.org>;
>> Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: [PATCH 1/3] Maintainers.txt: List Tianocore Stewards
>> 
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
>> ---
>> Maintainers.txt | 6 ++++++
>> 1 file changed, 6 insertions(+)
>> 
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 9d1b9fb941..a5e2e0af46 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -34,6 +34,12 @@ T: git (mirror) -
>> https://bitbucket.org/tianocore/edk2.git
>> T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>> T: svn (read-only, deprecated) -
>> https://svn.code.sf.net/p/edk2/code/trunk/edk2
>> 
>> +Tianocore Stewards
>> +------------------
>> +M: Andrew Fish <afish@apple.com>
>> +M: Leif Lindholm <leif.lindholm@linaro.org>
>> +M: Michael D Kinney <michael.d.kinney@intel.com>
>> +
>> Responsible Disclosure, Reporting Security Issues
>> -------------------------------------------------
>> W:
>> https://github.com/tianocore/tianocore.github.io/wiki/Security
>> --
>> 2.14.0
> 

Re: [PATCH 1/3] Maintainers.txt: List Tianocore Stewards

[Leif Lindholm]

On Thu, Aug 10, 2017 at 03:11:27PM -0700, Jordan Justen wrote:
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>

Series pushed as fc9f971e97..d75b8ac278.
Thanks!

> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 9d1b9fb941..a5e2e0af46 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -34,6 +34,12 @@ T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
>  T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>  T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
>  
> +Tianocore Stewards
> +------------------
> +M: Andrew Fish <afish@apple.com>
> +M: Leif Lindholm <leif.lindholm@linaro.org>
> +M: Michael D Kinney <michael.d.kinney@intel.com>
> +
>  Responsible Disclosure, Reporting Security Issues
>  -------------------------------------------------
>  W: https://github.com/tianocore/tianocore.github.io/wiki/Security
> -- 
> 2.14.0
>