From: "Andrew Fish" <afish@apple.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>, bret@corthon.com
Cc: Laszlo Ersek <lersek@redhat.com>,
Bret Barkelew <bret.barkelew@microsoft.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Dandan Bi <dandan.bi@intel.com>,
Chao Zhang <chao.b.zhang@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Hao A Wu <hao.a.wu@intel.com>,
"liming.gao" <liming.gao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature
Date: Wed, 23 Sep 2020 14:32:45 -0700 [thread overview]
Message-ID: <EFFE7ADD-1B08-4AFA-8F64-5D0A073435C1@apple.com> (raw)
In-Reply-To: <CA+ZiHMg-vOF0aNutRgX690bQftYKVZDi3t-GA0t0+VSWFaW0Jw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
> On Sep 23, 2020, at 2:14 PM, Bret Barkelew <bret@corthon.com> wrote:
>
> As far as I can tell, this is exposing a pre-existing race condition in EndOfDxe. It just so HAPPENS that the old "Disable RequestToLock" callback executed after this TcgMor callback, whereas the new VariablePolicy callback executes first.
>
> I'm going to poke around for a solution, but this seems like an architectural problem with EndOfDxe.
>
The architecture does not guarantee order for the events. So if the events are dependent on the order of other events that is a bug in implementation. These kind of bugs are hard to notice as the DXE Core implementation event dispatch in a fixed order, I think in the order the event was registered. So it looks correct until you add more events.
Thanks,
Andrew Fish
> On Wed, Sep 23, 2020 at 6:02 AM Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>> wrote:
> Hi Bret,
>
> On 09/23/20 08:12, Bret Barkelew via groups.io <http://groups.io/> wrote:
> > To whom it may concern,
> > This is as done as it’s going to get.
> >
> > Thank you all for your help!
>
> I tried to merge this via <https://github.com/tianocore/edk2/pull/954 <https://github.com/tianocore/edk2/pull/954>>,
> but it failed. Please review the build report, and submit v9 if necessary.
>
> Thanks!
> Laszlo
>
>
[-- Attachment #2: Type: text/html, Size: 2575 bytes --]
next prev parent reply other threads:[~2020-09-23 21:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 6:07 [PATCH v8 00/14] Add the VariablePolicy feature Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 01/14] MdeModulePkg: Define the VariablePolicy protocol interface Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 02/14] MdeModulePkg: Define the VariablePolicyLib Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 03/14] MdeModulePkg: Define the VariablePolicyHelperLib Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 04/14] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 10/14] MdeModulePkg: Allow VariablePolicy state to delete protected variables Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables Bret Barkelew
2020-09-23 6:11 ` Yao, Jiewen
2020-09-23 6:07 ` [PATCH v8 12/14] MdeModulePkg: Change TCG MOR variables to use VariablePolicy Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 13/14] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver Bret Barkelew
2020-09-23 6:07 ` [PATCH v8 14/14] MdeModulePkg: Add a shell-based functional test for VariablePolicy Bret Barkelew
2020-09-23 6:12 ` [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature Bret Barkelew
2020-09-23 8:45 ` [edk2-devel] " Laszlo Ersek
2020-09-23 9:22 ` Ard Biesheuvel
2020-09-23 9:43 ` Laszlo Ersek
2020-09-23 10:04 ` Laszlo Ersek
2020-09-23 10:17 ` Ard Biesheuvel
2020-09-23 19:46 ` Sean
2020-09-23 13:02 ` Laszlo Ersek
2020-09-23 21:14 ` Bret Barkelew
2020-09-23 21:32 ` Andrew Fish [this message]
2020-09-23 21:34 ` Bret Barkelew
2020-09-24 21:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EFFE7ADD-1B08-4AFA-8F64-5D0A073435C1@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox