[edk2-devel] ACPI table generator unit test

["yodagump via groups.io" <yodagump=google.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

Hi,

I plan to use EDK2 unit test framework (https://github.com/SophiaWang-Google/edk2/tree/master/UnitTestFrameworkPkg) to test ACPI table generator, such as https://github.com/tianocore/edk2/blob/master/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c

However, ACPI table generator only has two non-static function exposed:
EFI_STATUS
EFIAPI
AcpiGtdtLibConstructor (
IN  EFI_HANDLE        ImageHandle,
IN  EFI_SYSTEM_TABLE  *SystemTable
)

EFI_STATUS
EFIAPI
AcpiGtdtLibDestructor (
IN  EFI_HANDLE        ImageHandle,
IN  EFI_SYSTEM_TABLE  *SystemTable
)

So if we want to use GoogleTest gMock to unit test ACPI table generator, I guess we need to expose API :
STATIC
EFI_STATUS
EFIAPI
BuildGtdtTable (
IN  CONST ACPI_TABLE_GENERATOR                  *CONST  This,
IN  CONST CM_STD_OBJ_ACPI_TABLE_INFO            *CONST  AcpiTableInfo,
IN  CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL  *CONST  CfgMgrProtocol,
OUT       EFI_ACPI_DESCRIPTION_HEADER          **CONST  Table
)
to non-static

Please let me whether this is the approach upstream target for, or any better solutions on this?

Thank you,
Sophia


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121226): https://edk2.groups.io/g/devel/message/121226
Mute This Topic: https://groups.io/mt/111930977/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2692 bytes --]