From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by mx.groups.io with SMTP id smtpd.web12.13560.1599540656336022954 for ; Mon, 07 Sep 2020 21:50:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@scott.ph header.s=protonmail header.b=OZ9bPqB/; spf=pass (domain: scott.ph, ip: 185.70.40.133, mailfrom: scott@scott.ph) Date: Tue, 08 Sep 2020 04:50:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scott.ph; s=protonmail; t=1599540653; bh=tivgJZQaxpAf3fT1gKPMO1CzpqjL4pj+VvdAprBw3cI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=OZ9bPqB/urJ1gGBTtwM3KAll/Xq+JnyWX11yCD9Fw08gm7Cy4HeC2gR8Cycjl3YM/ WiDsXtfTQGLLIXOYVicJQbbv9L1hqiENHOZSf8L2h/YSWv3uy4o2FIFmA6sehmZyJG Fju54sOHcn/ba2DxdW0ib+ugfBGitGJrlYPQmxyZgDoSSAa/AMlMl1ZDFDRtAAc19M kgKyjPUWUrZyEidpmm/l6bXbrAtDrSgCOhVECmWWwOenTQpV71MHN+ZnURFUcC2484 OBZwqdOiH1fwHo8XXBPhLefLkLOpRWA27WiSw/pSsViEprrzU5VGDGCmQSe53nf5q8 Z2//9J+fAAimQ== To: Laszlo Ersek From: "D Scott Phillips" Cc: "devel@edk2.groups.io" , Rebecca Cran Reply-To: D Scott Phillips Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: Clear TlsChildHandle during cleanup Message-ID: In-Reply-To: References: <20200905011540.6847-1-scott@scott.ph> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, September 7, 2020 4:33 AM, Laszlo Ersek wrot= e: > Hi Scott, > > (+Rebecca) > > On 09/05/20 03:15, D Scott Phillips wrote: > > > From: D Scott Phillips d.scott.phillips@amperecomputing.com > > Leaving TlsChildHandle with the stale handle causes later use of https > > with the http instance to incorrectly skip tls reconfiguration, use > > the stale handle, and eventually call a garbage function pointer. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1917 > > Signed-off-by: D Scott Phillips d.scott.phillips@amperecomputing.com > > > > -----------------------------------------------------------------------= ------------------------------------------------------- > > > > NetworkPkg/HttpDxe/HttpProto.c | 1 + > > 1 file changed, 1 insertion(+) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpPr= oto.c > > index 3c7c6ff9f0..afc7db5a72 100644 > > --- a/NetworkPkg/HttpDxe/HttpProto.c > > +++ b/NetworkPkg/HttpDxe/HttpProto.c > > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > > // Destroy the TLS instance. > > // > > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->T= lsChildHandle); > > > > - HttpInstance->TlsChildHandle =3D NULL; > > } > > > > > > if (HttpInstance->Tcp4ChildHandle !=3D NULL) { > > thanks a lot for tracking this down! > > I've reopened BZ#1917, and linked your patch email in a new comment. > > But, I'd also like to assign the BZ to you, if that's OK with you. Can > you please register in the TianoCore bugzilla instance for that? Certainly, account created and assignment taken. Thanks Laszlo. Scott