From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1CC2A7803D8 for ; Fri, 23 Feb 2024 11:31:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=U/5nqOcaNbDcAIejLtAIappOy2V+81XSyERjlMaHeho=; c=relaxed/simple; d=groups.io; h=From:Message-Id:Mime-Version:Subject:Date:In-Reply-To:Cc:To:References:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1708687916; v=1; b=rREHSwLi2S4UywXuReGQmuVp+dNG3Ok6EgQupo9OOQO8lRqbgLu7F+rElFQJ3JDd1wtdGPSv Qv3GJTjAh53airrJTIzEiQuCvn24ccNDJ/R64AZPYygCW+YF3CUExZsz8YzFDU4ABzQOf04KlOq A9ci+9KudbZ8HiRfzTfVJN6o= X-Received: by 127.0.0.2 with SMTP id 22OLYY7687511xwuHEKmA5z2; Fri, 23 Feb 2024 03:31:56 -0800 X-Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx.groups.io with SMTP id smtpd.web11.8546.1708687915721195275 for ; Fri, 23 Feb 2024 03:31:56 -0800 X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-512e4f4e463so1029325e87.1 for ; Fri, 23 Feb 2024 03:31:55 -0800 (PST) X-Gm-Message-State: DkNfQGviG0J5relkhswxes7yx7686176AA= X-Google-Smtp-Source: AGHT+IEq1c+mokiUJVp19S6l5f3sK+X22WvXsvQDIi3Gmv4hccca0ZvvxVvb9Jgf993T3WllMCmSpg== X-Received: by 2002:a19:f718:0:b0:512:dc21:d89c with SMTP id z24-20020a19f718000000b00512dc21d89cmr1097315lfe.38.1708687912957; Fri, 23 Feb 2024 03:31:52 -0800 (PST) X-Received: from smtpclient.apple ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id k22-20020a05651210d600b00512e7c46618sm190601lfg.254.2024.02.23.03.31.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2024 03:31:52 -0800 (PST) From: "Mike Maslenkin" Message-Id: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Date: Fri, 23 Feb 2024 14:31:51 +0300 In-Reply-To: Cc: "devel@edk2.groups.io" , Abner Chang , Igor Kulchytskyy To: Nickle Wang References: <20240221200628.74174-1-mike.maslenkin@gmail.com> <20240221200628.74174-3-mike.maslenkin@gmail.com> <17B60D9667B989F2.14827@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="Apple-Mail=_CB01816E-6BA5-436E-BE8B-77051736F513" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rREHSwLi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --Apple-Mail=_CB01816E-6BA5-436E-BE8B-77051736F513 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Nickle, I've updated commit message with your R-b and pushed it to PR. Regards, Mike. > On 23. 2. 2024., at 12:38, Nickle Wang wrote: >=20 > Hi @Mike Maslenkin , > =20 > Can you please help me to add my reviewed-by to this commit message? http= s://github.com/tianocore/edk2-redfish-client/pull/76/commits/7110d17629d613= 1030a3c382ca46d9331e13f2af Then I can mer= ge this pull request. > =20 > Thanks, > Nickle > =20 > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Nickle Wang > > via groups.io > > Sent: Thursday, February 22, 2024 10:14 AM > > To: Mike Maslenkin >; devel@edk2.groups.io > > Cc: Abner Chang >; Igo= r Kulchytskyy > > > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishCl= ientPkg: > > refine RedfishExternalResourceResourceFeatureCallback > >=20 > > External email: Use caution opening links or attachments > >=20 > >=20 > > Thanks for addressing my comment. > >=20 > >=20 > > Reviewed-by: Nickle Wang > > >=20 > > Regards, > > Nickle > >=20 > > > -----Original Message----- > > > From: Mike Maslenkin > > > > Sent: Thursday, February 22, 2024 4:06 AM > > > To: devel@edk2.groups.io > > > Cc: Mike Maslenkin >; Nickle Wang > > > >; Abner Chang >; Igor > > > Kulchytskyy > > > > Subject: [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine > > > RedfishExternalResourceResourceFeatureCallback > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Use local variable for BiosUri passed to HandleResource() to avoid > > > problems in case of Private->Uri is overriden down the call stack. > > > > > > Suggested-by: Nickle Wang > > > > Cc: Abner Chang > > > > Cc: Nickle Wang > > > > Cc: Igor Kulchytskyy > > > > Signed-off-by: Mike Maslenkin > > > > --- > > > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++----- > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > > index f40f2d85af80..db77ed3dfccb 100644 > > > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > > > @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback ( > > > REDFISH_SERVICE RedfishService; > > > > > > REDFISH_RESOURCE_COMMON_PRIVATE *Private; > > > > > > EFI_STRING ResourceUri; > > > > > > + EFI_STRING BiosUri; > > > > > > > > > > > > if (FeatureAction !=3D CallbackActionStartOperation) { > > > > > > return EFI_UNSUPPORTED; > > > > > > @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback = ( > > > // > > > > > > // Initialize collection path > > > > > > // > > > > > > - Private->Uri =3D RedfishGetUri (ResourceUri); > > > > > > - if (Private->Uri =3D=3D NULL) { > > > > > > + BiosUri =3D RedfishGetUri (ResourceUri); > > > > > > + if (BiosUri =3D=3D NULL) { > > > > > > ASSERT (FALSE); > > > > > > FreePool (ResourceUri); > > > > > > return EFI_OUT_OF_RESOURCES; > > > > > > } > > > > > > > > > > > > - Status =3D HandleResource (Private, Private->Uri); > > > > > > + Status =3D HandleResource (Private, BiosUri); > > > > > > if (EFI_ERROR (Status)) { > > > > > > - DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: = %r\n", > > > __func__, Private->Uri, Status)); > > > > > > + DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed: > > > + %r\n", __func__, BiosUri, Status)); > > > > > > } > > > > > > > > > > > > - FreePool (Private->Uri); > > > > > > + FreePool (BiosUri); > > > > > > FreePool (ResourceUri); > > > > > > return Status; > > > > > > } > > > > > > -- > > > 2.32.0 (Apple Git-132) > >=20 > >=20 > >=20 > >=20 > >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115882): https://edk2.groups.io/g/devel/message/115882 Mute This Topic: https://groups.io/mt/104495956/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --Apple-Mail=_CB01816E-6BA5-436E-BE8B-77051736F513 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi Nickle,
I've updated commit mess= age with your R-b and pushed it to PR.
<= font face=3D"Calibri, sans-serif" class=3D"">
Regards,
= Mike.

On 23. 2. 2024., at 12:38, Nickle Wang <nicklew@nvidia.com> wrote:=

Hi&nbs= p;@Mike Maslenkin,
 
C= an you please help me to add my reviewed-by to this commit message? https://github.com/tianocore/edk2-redfish-client/pull/76/commits/7= 110d17629d6131030a3c382ca46d9331e13f2af  Then I can merge this pul= l request.
 =
Thanks,
Nickle
 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@e= dk2.groups.io> On Behalf Of Nickle Wang
> via=  groups.io
> Sent: Thursday, February 22, 2= 024 10:14 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; = devel@edk2.groups.io
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytsk= yy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] Re= dfishClientPkg:
> refine RedfishExternalResourceReso= urceFeatureCallback
> 
> External email: Use caution o= pening links or attachments
> 
> 
> Thanks for addressin= g my comment.
> 
> 
> Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> 
> Regards,
> Nickle
&g= t; 
&= gt; > -----Original Message-----
> > From: Mik= e Maslenkin <mike.maslenkin@gmail.co= m>
> > Sent: Thursday, February 22,= 2024 4:06 AM
> > To: devel@edk2.groups.io=
> > Cc: Mike Maslenkin <mike.maslenkin@gmail.com>; Nickle W= ang
> > <<= span style=3D"color: windowtext; text-decoration: none;" class=3D"">nicklew= @nvidia.com>; Abner Chang <= abner.chang@amd.com>; Igor
> > Kulc= hytskyy <igork@ami.com>
> > Subject: [edk2-redfish-client][PATCH v2 2/4] RedfishCl= ientPkg: refine
> > RedfishExternalResourceResour= ceFeatureCallback
> >
> &g= t; External email: Use caution opening links or attachments
> >
> >
> >= Use local variable for BiosUri passed to HandleResource() to avoid
> > problems in case of Private->Uri is overriden dow= n the call stack.
> >
> &g= t; Suggested-by: Nickle Wang <nicklew@nvid= ia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytsk= yy <igork@ami.com>
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
>= > ---
> >  RedfishClientPkg/Features/Bio= s/v1_0_9/Dxe/BiosDxe.c | 11 ++++++-----
> > = 1 file changed, 6 insertions(+), 5 deletions(-)
> &= gt;
> > diff --git a/RedfishClientPkg/Features/Bi= os/v1_0_9/Dxe/BiosDxe.c
> > b/RedfishClientPkg/Fe= atures/Bios/v1_0_9/Dxe/BiosDxe.c
> > index f40f2d= 85af80..db77ed3dfccb 100644
> > --- a/RedfishClie= ntPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
> > +++ = b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
&= gt; > @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback= (
> >    REDFISH_SERVICE &nb= sp;            =     RedfishService;
> >
> >    REDFISH_RESOURCE_COMMON_PRIVATE = *Private;
> >
> > = ;   EFI_STRING        &nb= sp;            =   ResourceUri;
> >
> = > +  EFI_STRING        &nbs= p;            &= nbsp; BiosUri;
> >
> ><= /div>
> >
> >  &nbs= p; if (FeatureAction !=3D CallbackActionStartOperation) {
> >
> >     = return EFI_UNSUPPORTED;
> >
= > > @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallb= ack (
> >    //
> >
> >    // Initialize c= ollection path
> >
> >&= nbsp;   //
> >
>= > -  Private->Uri =3D RedfishGetUri (ResourceUri);
> >
> > -  if (Private->Uri= =3D=3D NULL) {
> >
> >= +  BiosUri =3D RedfishGetUri (ResourceUri);
> = >
> > +  if (BiosUri =3D=3D NULL) {
=
> >
> >   &nb= sp;  ASSERT (FALSE);
> >
> >      FreePool (ResourceUri);
> >
> >    &n= bsp; return EFI_OUT_OF_RESOURCES;
> >
> >    }
> >
<= div style=3D"margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif= ;" class=3D"">> >
> >
&= gt; > -  Status =3D HandleResource (Private, Private->Uri);
> >
> > +  Status =3D = HandleResource (Private, BiosUri);
> >
> >    if (EFI_ERROR (Status)) {
> >
> > -    DEBUG = ((DEBUG_ERROR, "%a, process external resource: %a failed: %r\n",
> > __func__, Private->Uri, Status));
> >
> > +    DEBUG ((DEBUG= _ERROR, "%a, process external resource: %s failed:
>= > + %r\n", __func__, BiosUri, Status));
> >
> >    }
> &= gt;
> >
> >
> > -  FreePool (Private->Uri);
= > >
> > +  FreePool (BiosUri);
> >
> >    Free= Pool (ResourceUri);
> >
> = >    return Status;
> >
> >  }
> >
> > --
> > 2.32.0 (Apple Git-132)
> 
> 
> <= /div>
>
> 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#115882) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--Apple-Mail=_CB01816E-6BA5-436E-BE8B-77051736F513--