public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Andrew Fish" <afish@apple.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>, rebecca@bsdio.com
Cc: Mike Kinney <michael.d.kinney@intel.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
Date: Sun, 02 May 2021 13:20:08 -0700	[thread overview]
Message-ID: <F149D92F-5DB4-4E06-9702-144E30566B55@apple.com> (raw)
In-Reply-To: <e7c1b3b1-6ccd-e50a-fbe5-1db30e5c25c4@bsdio.com>

[-- Attachment #1: Type: text/plain, Size: 3971 bytes --]

Rebecca,

I don’t think `-z` is a valid argument to ld64 (macOS linker). My guess is XCODE is inheriting a GCC flag from a platform DSC file. 

$ git grep "z common-page-size" -- *.dsc
OvmfPkg/OvmfPkgIa32.dsc:89:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32.dsc:97:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32X64.dsc:93:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32X64.dsc:101:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgX64.dsc:93:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgX64.dsc:101:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfXen.dsc:84:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfXen.dsc:92:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
StandaloneMmPkg/StandaloneMmPkg.dsc:116:GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp -mstrict-align

Thanks,

Andrew Fish

> On May 2, 2021, at 12:06 PM, Rebecca Cran <rebecca@bsdio.com> wrote:
> 
> It doesn't seem to apply against
> 1e6b0394d6c001802dc454ecff19076aaa80f51c (master as of today):
> 
> patching file BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py
> Hunk #1 FAILED at 181.
> Hunk #2 FAILED at 632.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py.rej
> patching file BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> Hunk #1 FAILED at 1391.
> Hunk #2 FAILED at 1534.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/AutoGen/PlatformAutoGen.py.rej
> patching file BaseTools/Source/Python/build/build.py
> Hunk #1 FAILED at 897.
> Hunk #2 FAILED at 930.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/build/build.py.rej
> 
> -- 
> Rebecca Cran
> 
> On 5/2/21 12:04 PM, Kinney, Michael D wrote:
>> Please try this patch:
>> 
>> 	https://edk2.groups.io/g/devel/message/74684 <https://edk2.groups.io/g/devel/message/74684>
>> 
>> If it works, can you please also do a review?  Many community members are offline this week and I want to get these fixes in.
>> 
>> Mike
>> 
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> On Behalf Of Rebecca Cran
>>> Sent: Saturday, May 1, 2021 9:05 PM
>>> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Andrew Fish <afish@apple.com <mailto:afish@apple.com>>; Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>>
>>> Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
>>> 
>>> I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.
>>> 
>>> If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
>>> get quite far, but then tries to run ld with "-z common-page-size",
>>> causing the error:
>>> 
>>> 
>>> "ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
>>> -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
>>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
>>> -z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
>>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
>>> -filelist
>>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>> untimeDxe/OUTPUT/static_library_files.lst
>>> Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
>>> make: Nothing to be done for `tbuild'.
>>> ld: unknown option: -z
>>> 
>>> 
>>> --
>>> 
>>> Rebecca Cran
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
> 
> 
> 
> 
> 


[-- Attachment #2: Type: text/html, Size: 29358 bytes --]

  reply	other threads:[~2021-05-02 20:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02  4:04 Error building OVMF on x86 macOS with Xcode 12.5 Rebecca Cran
2021-05-02 18:04 ` [edk2-devel] " Michael D Kinney
2021-05-02 19:06   ` Rebecca Cran
2021-05-02 20:20     ` Andrew Fish [this message]
2021-05-02 22:23       ` Michael D Kinney
2021-05-02 22:20     ` Michael D Kinney
2021-05-02 23:21       ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F149D92F-5DB4-4E06-9702-144E30566B55@apple.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox