From: Andrew Fish <afish@apple.com>
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel@lists.01.org, Yonghong Zhu <yonghong.zhu@intel.com>
Subject: Re: [Patch] BaseTools: Update tools_def.template to remove old XCLANG and XCODE32
Date: Mon, 03 Jul 2017 10:32:59 -0700 [thread overview]
Message-ID: <F3FDF183-6581-4448-AE9A-A1C33F961E6E@apple.com> (raw)
In-Reply-To: <1499059690-6448-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Andrew Fish <afish@apple.com>
> On Jul 2, 2017, at 10:28 PM, Liming Gao <liming.gao@intel.com> wrote:
>
> Per Andrew Fish recommendation, XCLANG and XCODE32 are not used anymore.
> https://bugzilla.tianocore.org/show_bug.cgi?id=562
> https://bugzilla.tianocore.org/show_bug.cgi?id=563
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 176 --------------------------------------
> 1 file changed, 176 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 65f2106..7d3f542 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -7251,182 +7251,6 @@ NOOPT_MYTOOLS_IPF_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /LTCG /DLL /OPT
> *_MYTOOLS_EBC_DLINK_FLAGS = "C:\Program Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /MAP /ALIGN:32 /DRIVER
>
>
> -####################################################################################
> -#
> -# Xcode Support for building on Mac OS X (Snow Leopard)
> -#
> -####################################################################################
> -# XCODE32 - Xcode 3.2 Tools (Snow Leopard)
> -*_XCODE32_*_*_FAMILY = GCC
> -*_XCODE32_*_*_BUILDRULEFAMILY = XCODE
> -*_XCODE32_*_*_BUILDRULEORDER = S s nasm
> -
> -
> -*_XCODE32_*_ASL_PATH = /usr/bin/iasl
> -
> -*_XCODE32_*_MAKE_PATH = make
> -
> -*_XCODE32_*_DSYMUTIL_PATH = /usr/bin/dsymutil
> -
> -# This tool needs to be installed seperatly from Xcode 3.2
> -*_XCODE32_*_MTOC_PATH = /usr/local/bin/mtoc
> -
> - DEBUG_XCODE32_*_MTOC_FLAGS = -align 0x20 -d $(DEBUG_DIR)/$(MODULE_NAME).dll
> -RELEASE_XCODE32_*_MTOC_FLAGS = -align 0x20
> -
> -##################
> -# IA32 definitions
> -##################
> -*_XCODE32_IA32_CC_PATH = gcc
> -*_XCODE32_IA32_SLINK_PATH = libtool
> -*_XCODE32_IA32_DLINK_PATH = ld
> -*_XCODE32_IA32_ASM_PATH = as
> -*_XCODE32_IA32_PP_PATH = gcc
> -*_XCODE32_IA32_VFRPP_PATH = gcc
> -*_XCODE32_IA32_ASL_PATH = iasl
> -*_XCODE32_IA32_ASLCC_PATH = gcc
> -*_XCODE32_IA32_ASLPP_PATH = gcc
> -*_XCODE32_IA32_ASLDLINK_PATH = ld
> -
> - DEBUG_XCODE32_IA32_DLINK_FLAGS = -arch i386 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -RELEASE_XCODE32_IA32_DLINK_FLAGS = -arch i386 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x220 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -*_XCODE32_IA32_SLINK_FLAGS = -static -o
> - DEBUG_XCODE32_IA32_ASM_FLAGS = -arch i386 -g
> -RELEASE_XCODE32_IA32_ASM_FLAGS = -arch i386
> -*_XCODE32_IA32_NASM_FLAGS = -f macho32
> -*_XCODE32_IA32_PP_FLAGS = -arch i386 -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
> -*_XCODE32_IA32_VFRPP_FLAGS = -arch i386 -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> - DEBUG_XCODE32_IA32_CC_FLAGS = -arch i386 -save-temps -g -O0 -combine -mms-bitfields -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h -mdynamic-no-pic -fno-stack-protector
> -RELEASE_XCODE32_IA32_CC_FLAGS = -arch i386 -Oz -combine -mms-bitfields -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -fomit-frame-pointer -c -include AutoGen.h -mdynamic-no-pic -fno-stack-protector
> -
> -*_XCODE32_IA32_ASLCC_FLAGS = -arch i386 -x c -save-temps -g -O0 -mms-bitfields -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h -mdynamic-no-pic
> -*_XCODE32_IA32_ASLDLINK_FLAGS = -arch i386 -e _main -preload -segalign 0x20 -pie -seg1addr 0x220 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -*_XCODE32_IA32_ASLPP_FLAGS = -arch i386 -x c -E -include AutoGen.h
> -*_XCODE32_IA32_ASL_FLAGS =
> -
> -##################
> -# X64 definitions - still a work in progress. This tool chain does not produce
> -# the correct ABI, it is just used to compile the code....
> -##################
> -*_XCODE32_X64_CC_PATH = gcc
> -*_XCODE32_X64_SLINK_PATH = libtool
> -*_XCODE32_X64_DLINK_PATH = ld
> -*_XCODE32_X64_ASM_PATH = as
> -*_XCODE32_X64_PP_PATH = gcc
> -*_XCODE32_X64_VFRPP_PATH = gcc
> -*_XCODE32_X64_ASL_PATH = iasl
> -*_XCODE32_X64_ASLCC_PATH = gcc
> -*_XCODE32_X64_ASLPP_PATH = gcc
> -*_XCODE32_X64_ASLDLINK_PATH = ld
> -
> -*_XCODE32_X64_DLINK_FLAGS = -arch x86_64 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -*_XCODE32_X64_SLINK_FLAGS = -static -o
> -
> - DEBUG_XCODE32_X64_ASM_FLAGS = -arch x86_64 -g
> -RELEASE_XCODE32_X64_ASM_FLAGS = -arch x86_64
> -*_XCODE32_X64_NASM_FLAGS = -f macho64
> -*_XCODE32_X64_PP_FLAGS = -arch x86_64 -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
> -*_XCODE32_X64_VFRPP_FLAGS = -arch x86_64 -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> -
> - DEBUG_XCODE32_X64_CC_FLAGS = -arch x86_64 -save-temps -g -O0 -mms-bitfields -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -Wno-address -fomit-frame-pointer -static -c -include AutoGen.h -fno-stack-protector
> -RELEASE_XCODE32_X64_CC_FLAGS = -arch x86_64 -Oz -mms-bitfields -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -Wno-address -fomit-frame-pointer -static -c -include AutoGen.h -fno-stack-protector
> -
> -##################
> -# ARM definitions - (Assumes iPhone SDK installed on Snow Leopard)
> -##################
> -
> -*_XCODE32_ARM_ARCHCC_FLAGS = -arch armv7 -march=armv7 -mthumb
> -*_XCODE32_ARM_ARCHASM_FLAGS = -arch armv7
> -*_XCODE32_ARM_ARCHDLINK_FLAGS = -arch armv7
> -*_XCODE32_ARM_PLATFORM_FLAGS =
> -
> -*_XCODE32_ARM_CC_PATH = DEF(IPHONE_TOOLS)/usr/bin/gcc
> -*_XCODE32_ARM_SLINK_PATH = DEF(IPHONE_TOOLS)/usr/bin/libtool
> -*_XCODE32_ARM_DLINK_PATH = ld
> -*_XCODE32_ARM_ASM_PATH = DEF(IPHONE_TOOLS)/usr/bin/as
> -*_XCODE32_ARM_PP_PATH = DEF(IPHONE_TOOLS)/usr/bin/gcc
> -*_XCODE32_ARM_VFRPP_PATH = DEF(IPHONE_TOOLS)/usr/bin/gcc
> -
> - DEBUG_XCODE32_ARM_DLINK_FLAGS = $(ARCHDLINK_FLAGS) -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x220 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -RELEASE_XCODE32_ARM_DLINK_FLAGS = $(ARCHDLINK_FLAGS) -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x220 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -
> -*_XCODE32_ARM_SLINK_FLAGS = -static -o
> -
> - DEBUG_XCODE32_ARM_ASM_FLAGS = $(ARCHASM_FLAGS) -g
> -RELEASE_XCODE32_ARM_ASM_FLAGS = $(ARCHASM_FLAGS)
> -*_XCODE32_ARM_PP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
> -*_XCODE32_ARM_VFRPP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> -
> - DEBUG_XCODE32_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -mthumb-interwork -g -Oz -mabi=aapcs -mapcs -fno-short-enums -save-temps -combine -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -fomit-frame-pointer -c -include AutoGen.h
> -RELEASE_XCODE32_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -mthumb-interwork -Oz -mabi=aapcs -mapcs -fno-short-enums -save-temps -combine -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -fomit-frame-pointer -c -include AutoGen.h
> -
> -
> -####################################################################################
> -#
> -# Clang Support for building on Mac OS X
> -#
> -####################################################################################
> -# CLANG - clang that produce Mach-O with EFI x86_64 ABI
> -*_XCLANG_*_*_FAMILY = GCC
> -*_XCLANG_*_*_BUILDRULEFAMILY = XCODE
> -*_XCLANG_*_*_BUILDRULEORDER = S s nasm
> -
> -*_XCLANG_*_ASL_PATH = /usr/bin/iasl
> -
> -*_XCLANG_*_MAKE_PATH = make
> -*_XCLANG_*_DSYMUTIL_PATH = /usr/bin/dsymutil
> -
> - *_*_*_MTOC_PATH = /usr/local/bin/mtoc
> -
> - DEBUG_XCLANG_*_MTOC_FLAGS = -align 0x20 -d $(DEBUG_DIR)/$(MODULE_NAME).dll
> -RELEASE_XCLANG_*_MTOC_FLAGS = -align 0x20
> -
> -
> -*_XCLANG_*_CC_PATH = ENV(CLANG_BIN)clang
> -*_XCLANG_*_SLINK_PATH = libtool
> -*_XCLANG_*_DLINK_PATH = ld
> -*_XCLANG_*_ASM_PATH = as
> -*_XCLANG_*_PP_PATH = ENV(CLANG_BIN)clang
> -*_XCLANG_*_VFRPP_PATH = ENV(CLANG_BIN)clang
> -*_XCLANG_*_ASL_PATH = iasl
> -*_XCLANG_*_ASLCC_PATH = ENV(CLANG_BIN)clang
> -*_XCLANG_*_ASLPP_PATH = ENV(CLANG_BIN)clang
> -*_XCLANG_*_ASLDLINK_PATH = ld
> -
> -####################
> -# IA-32 definitions
> -####################
> - DEBUG_XCLANG_IA32_DLINK_FLAGS = -arch i386 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -RELEASE_XCLANG_IA32_DLINK_FLAGS = -arch i386 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x220 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -*_XCLANG_IA32_SLINK_FLAGS = -static -o
> - DEBUG_XCLANG_IA32_ASM_FLAGS = -arch i386 -g
> -RELEASE_XCLANG_IA32_ASM_FLAGS = -arch i386
> -*_XCLANG_IA32_NASM_FLAGS = -f macho32
> -
> - DEBUG_XCLANG_IA32_CC_FLAGS = -arch i386 -c -g -O0 -Wall -Werror -include AutoGen.h -fno-stack-protector -fno-builtin -fshort-wchar -mdynamic-no-pic -mno-sse -mno-mmx -Wno-empty-body -Wno-pointer-sign -Wno-unused-function -Wno-unused-value -Wno-missing-braces -Wno-tautological-compare -Wreturn-type -Wno-unused-variable -fasm-blocks -mms-bitfields -msoft-float -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> -RELEASE_XCLANG_IA32_CC_FLAGS = -arch i386 -c -Os -Wall -Werror -include AutoGen.h -fno-stack-protector -fno-builtin -fshort-wchar -mdynamic-no-pic -mno-sse -mno-mmx -Wno-empty-body -Wno-pointer-sign -Wno-unused-function -Wno-unused-value -Wno-missing-braces -Wno-tautological-compare -Wreturn-type -Wno-unused-variable -fasm-blocks -mms-bitfields -msoft-float -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> -
> -
> -##################
> -# X64 definitions
> -##################
> - DEBUG_XCLANG_X64_DLINK_FLAGS = -arch x86_64 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -RELEASE_XCLANG_X64_DLINK_FLAGS = -arch x86_64 -u _$(IMAGE_ENTRY_POINT) -e _$(IMAGE_ENTRY_POINT) -preload -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x220 -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -*_XCLANG_X64_SLINK_FLAGS = -static -o
> - DEBUG_XCLANG_X64_ASM_FLAGS = -arch x86_64 -g
> -RELEASE_XCLANG_X64_ASM_FLAGS = -arch x86_64
> -*_XCLANG_X64_NASM_FLAGS = -f macho64
> -*_XCLANG_*_PP_FLAGS = -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
> -*_XCLANG_*_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE -include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> -
> -
> - DEBUG_XCLANG_X64_CC_FLAGS = -ccc-host-triple x86_64-pc-win32-macho -c -g -O0 -Wall -Werror -include AutoGen.h -fno-stack-protector -fno-builtin -fshort-wchar -mdynamic-no-pic -Wno-empty-body -Wno-pointer-sign -Wno-unused-function -Wno-unused-value -Wno-missing-braces -Wno-tautological-compare -Wreturn-type -Wno-unused-variable -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> -RELEASE_XCLANG_X64_CC_FLAGS = -ccc-host-triple x86_64-pc-win32-macho -c -Os -Wall -Werror -include AutoGen.h -fno-stack-protector -fno-builtin -fshort-wchar -mdynamic-no-pic -Wno-empty-body -Wno-pointer-sign -Wno-unused-function -Wno-unused-value -Wno-missing-braces -Wno-tautological-compare -Wreturn-type -Wno-unused-variable -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> -*_XCLANG_*_ASLCC_FLAGS = -x c -save-temps -g -O0 -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h -mdynamic-no-pic
> -*_XCLANG_*_ASLDLINK_FLAGS = -e _main -preload -segalign 0x20 -pie -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
> -*_XCLANG_*_ASLPP_FLAGS = -x c -E -include AutoGen.h
> -*_XCLANG_*_ASL_FLAGS =
> -
> #
> # XCODE5 support
> #
> --
> 2.8.0.windows.1
>
prev parent reply other threads:[~2017-07-03 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 5:28 [Patch] BaseTools: Update tools_def.template to remove old XCLANG and XCODE32 Liming Gao
2017-07-03 17:32 ` Andrew Fish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3FDF183-6581-4448-AE9A-A1C33F961E6E@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox