From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonic315-13.consmr.mail.bf2.yahoo.com (sonic315-13.consmr.mail.bf2.yahoo.com [74.6.134.123]) by mx.groups.io with SMTP id smtpd.web08.9258.1610031117981438704 for ; Thu, 07 Jan 2021 06:51:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@yahoo.com header.s=s2048 header.b=hd4ERVLU; spf=neutral (domain: yahoo.com, ip: 74.6.134.123, mailfrom: croberts4464@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610031117; bh=1mKTUffDJNuqOInrdAmXRV8rFrsXSM4Lgb+8rJH+RCE=; h=From:Subject:Date:References:In-Reply-To:To:From:Subject; b=hd4ERVLU4khkiqlGg5iAZ08j3JcqDQKE/f1IFTnFMeEd9C1YMHdfxBd3bX3IP/FfO8OM01+xupgf1R8+3N+DnKJBaxs9RGgMuw6s24h24EmBaf89yiij1BzbfoP3vdrXCk9cXa+GytF8sDriGrz2iUH9KyfoKkmxDXL/GfkDxN8tGJZvtgDjVhLJiPtV/oCmIJCkWvy5yYLtvy8F8hb1uMGedLN6aelggzEUNSF7/xbZ2KEEJYC5Lsa/CWz2lBer0gCJrGSrSpRrYTlhlSmzyDIHoA8Ob4l6sVIVYUu+W9OU6IxB+VD+HA95nZG16bAhwJJ0CfCFnTHzAajpOleXGA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610031117; bh=xyxqc/uNSTRn5xmIpS+kDObB+33Qnz0psjWUghUMTqE=; h=From:Subject:Date:To:From:Subject; b=hAQyHxklkDqShSSNTjWsO8RTsIsPnk2sJNK9vnNWPnAynqVSYoz4xs9cnWFBwCSlk9BlnbL7Ckm83bJsizG5wKMNK3XcW5yz26RB5tj/yYSV9DuL28iQ0FQAooSJe8buGCd9AEYC0kFNk+TcvbR+Wm1Ze37nrv1PhoCw8WGcQ5k+uY02s7YSrtMXgnZ+5RLxHr7/CJMc7LvSEXM8flG1f4s3H4p8GqppHO/V/EhsgstVSqaq+mJExqFP6n/wlSuZoS/TsaTouAJSvIu4ZfIW4vzt7kmRRebtoRkSTUy4rgMujAi9bET0oH8mJepCZ499Kmx3xnMhPgyjdUx3bDNM0w== X-YMail-OSG: 5d2HsKcVM1lyKTnlErSzWnsSBNE97AGbCzuXrcxbovFOBXa.9KJ52up1lbHnxpQ im3ENLP1gVJwq7J7K40S0_uAlkVCB_oiiFxldq1eZtz3oydOzpopRLMpjKrvahqwbGgLg5LH3bVf 7L_Pj8v2vjcV4l6XNK0ryKLNCZA4K29cRE9MNey4MoB_ADYgjc37rtjUZLHcbbKqG.xhe0_x2SNT ZKVkxqSlUn_xxFkBlVEPxm.O82MBuU4z_q035Cs4rLW106sjpn0JOLvN.isezR0dic4Et4i32YSx wHbWoSubpzOA10gOK4U20Sxwq37DXprMMEuLpKye0ujZQst6oJe5fUoAKH0ymskQEDU3sAeMujbq lBeUFQN5K7rwIcb19epSmrZqlimi_hw.2FwGG5A.t_7J5CqlwRFFn_S.n2.yRvou03WWTibJdZpy IQ2_QPZrCsoeAteSTG.BPSy_kjaxxr6cf6DvGD9fw_6RxOz7Zy_y.dOIzME8LSCN5D6EQYGTYd7d 5jkks73ovYXuN0gi9EkmnKuzeHvBOQh_1n7vsHXdUzhDeMXbTmfjqNFdwBY0f_4zYBTyMzn1NIXf OOoyOkonc3fOAKsSTrokdQfHjKhEwQo_sk73K9ogFNF9S9cCj1T.ntZz9.n262gyvEsANpsmWDBw uWuwn9dwLXXBYH2YJzRLXbMSprPAWKPTiukxpmnN30w9ekM2TkDYQIz6TbIn0F1shm4TQAW0NT4d O2BLiXRbdnRgZva1vSNXZppD13XITRH7yag4.c95_hvmKGgB_wneWgTLqamJfauJRYn9tHgMtiTo OfJasCI3dDRkUnGPE8QTV1eC180whb5rglNe3F1HNyC.5J03itkU7nhOlxMwYOQlpM2m4Nu4WC2P j5J6AOQtKheFLYX_BebVi8d1JBR_.6JwhzTvv9smg3NeASy.4CeMC4QBbP9QOdXSdsQtAmMqanZ4 6LmQTlwBHvrNJNoebb3kaeDZYN_.BFh9LmcdcTu0i_nvmcJphgUgofZpd5X34xHXgpZ5FFTRwWjP N.U5G_2TMiEZ00P.eB87WmYYhO3pOCrx6rx6T_Brod1CWezaR9_7N2xeUDSf8qjucokuiekBBup4 OmO2lP_vjsruWUZcMmN57osk8AomzlL_HcaUJKQucR28A5Y3R3GwhSKDfYHi_fx48ER5h_ePMrhw klsaWOL0XWwejIn3n4cJ5UDdVEMQ2Bq9OZNe9vbSz9hAj3vI82RPBVlRMpLQKTzuCWmloF4_7Jlg 99nlQ70mE05EO6nhFHES6LqrGwbyIiX2TNw.yWj4GIChHcYsBFPSKtdMT1185wkCJO4d3280cYck wXFYWzxxFMISXl4dPKHzJEw6qWv.xZFrd5n75b1duh2NwxzGmkK4lnYYygiFw8cSwbqghQn94tiZ 8.zkQqqSWcjMsy.c1Lc7ayi5ZFNfZS_4.Y3OgTIwtA1w9HIH_eH5DPHmDQsbX8jiayrc5wqARiG. 7z4BrHJerQp6Z3b2watSiu8RBcAdmgIAmzdaVE1Ax6p.VXYT9Qz4qDRo.VFKtH6oO6zqqoo_Aimf 9Eym4CyOd3r3eKG8eeHVDbSBTHnU5rUwLlDGvDm4iMsB1s5xH3I0Fh66CaScJPfS5va9_0kPTkmR vDzHAzvi0tI2V.TfxfUXq3RnjXuafu3ysxSiXQUgf5NCSrmcblEXQlO70lXkZbo7Boh2ZLFNnZ_E 8k.f7d0ASC9bVbp4tXOUsntEHC_p4aO.nkIFiDZ0qUAi2jX12Dg6ys20wYpCZ.p2cKs.i.JPfPhg 6Lb0RckuGeCNNmE6uiIsMF11kaKSw_Fa22sziVDWmxainh0mmY0xH5j3LpgVfcPyeLstWlDuo_Jz 0hERHiJKn.nD3fMD8BGd8m4srLcjAnG3zhI.uU7KULH4OrChclYOhhH.WzHXynePk2P1pg7ECQ4Z a_pBPRXHC238FjEgI4o71.YMcY_i5Xjy8Miq9UuRO3g4tLiIiScKGbaKFAOggT2x5BQ8F5sbCX7d cxrbJHsLSh7ZEOGzq.CrSso0IwEck5bFddSp.vpuHghq68mnOACG5x1gKWLozMqj1dv97WSq3sZv ikglSv1Nf3A7vwSCwpiUMshUGvHgzwGXAMB9cEx1Eh0VQY_rZqFH9y1d.DROswb96hYjYaKhXlgo 6URfhnmRnO3GTzX1aB__tdGm2hmxx_WeL5G5w3V65lpYMqIATOUHD0uYzuRHoMjK7TcUnCCqbsM7 3s4vFNTQbi6dNjyovIv86A5GJgUA_xml8_B6v7yAJ8CULyo6EiAt5.oMLe6ohe7r3vOsXh_wrvPY hMnqqGLAu9.CB1Cebaf7N2zbJY9GoTJZ6sLx6oNBYvKdD0o7aTDfVUhNTok3qCjGJyQPnL0QQkkT w9fMN.eByVtCgTMjaR6p2d2h6tif5KfHHxtdvXI2E9CUH1fq0bTfZUep3ws_tN_hDTE189EFIiWE IE1NbqytTTtIKYSY9zgehAG2gvcGiSVtHmEOOuyc4kXA_XVpNH5y9oezSZCAN2TqOZJ.Mut8yK9E Fn.0KZ1_sLHO_ugaBPFM- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.bf2.yahoo.com with HTTP; Thu, 7 Jan 2021 14:51:57 +0000 Received: by smtp405.mail.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 332699f9d9b4773269d1282cd29693d5; Thu, 07 Jan 2021 14:51:52 +0000 (UTC) From: Cindy Roberts Mime-Version: 1.0 (1.0) Subject: Re: [edk2-devel] [PATCH 1/2] MdePkg: Define structures for Resizable BAR Capability Date: Thu, 7 Jan 2021 06:51:44 -0800 Message-Id: References: In-Reply-To: To: devel@edk2.groups.io, heng.luo@intel.com X-Mailer: iPhone Mail (18B92) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stop! Cindy > On Jan 7, 2021, at 12:32 AM, Heng Luo wrote: >=20 > =EF=BB=BFHi Liming, > Ray and I have evaluated the impact, we think only UefiShellDebug1Comman= dsLib/Pci.c uses this structure, I have change this file in this patch, we= think it doesn't impact Edk2 and Edk2Platforms. >=20 > Thanks, > Heng >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of >> gaoliming >> Sent: Tuesday, December 29, 2020 9:46 AM >> To: devel@edk2.groups.io; Luo, Heng >> Cc: Ni, Ray ; Wu, Hao A >> Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH 1/2] MdePkg: Define st= ructures for >> Resizable BAR Capability >>=20 >> Heng: >> This is the incompatible change. Have you evaluated its impact in Edk2= and >> Edk2Platforms? >>=20 >> Thanks >> Liming >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+69477+4905953+8761045@groups= .io >>> =E4=BB=A3=E8=A1=A8 Heng= Luo >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=8828=E6=97= = =A5 16:26 >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >>> =E6=8A=84=E9=80=81: Ray Ni ; Hao A Wu >>> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/2] MdePkg: Define structures= for Resizable >>> BAR Capability >>>=20 >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3138 >>>=20 >>> Define structures for Resizable BAR Capability in >>> MdePkg/Include/IndustryStandard/PciExpress21.h, >>> Change ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >>> to use new structures. >>>=20 >>> Cc: Ray Ni >>> Cc: Hao A Wu >>> Signed-off-by: Heng Luo >>> --- >>> MdePkg/Include/IndustryStandard/PciExpress21.h | 30 >>> +++++++++++++++++++++++++----- >>> ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 6 +++--- >>> 2 files changed, 28 insertions(+), 8 deletions(-) >>>=20 >>> diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h >>> b/MdePkg/Include/IndustryStandard/PciExpress21.h >>> index 2c07cb560e..b7629444eb 100644 >>> --- a/MdePkg/Include/IndustryStandard/PciExpress21.h >>> +++ b/MdePkg/Include/IndustryStandard/PciExpress21.h >>> @@ -1,7 +1,7 @@ >>> /** @file >>>=20 >>> Support for the latest PCI standard. >>>=20 >>>=20 >>>=20 >>> - Copyright (c) 2006 - 2018, Intel Corporation. All rights >>> reserved.
>>>=20 >>> + Copyright (c) 2006 - 2020, Intel Corporation. All rights >>> + reserved.
>>>=20 >>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>>>=20 >>> SPDX-License-Identifier: BSD-2-Clause-Patent >>>=20 >>>=20 >>>=20 >>> @@ -632,10 +632,30 @@ typedef struct { #define >>> PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_ID >>> 0x0015 >>>=20 >>> #define PCI_EXPRESS_EXTENDED_CAPABILITY_RESIZABLE_BAR_VER1 0x1 >>>=20 >>>=20 >>>=20 >>> +typedef union { >>>=20 >>> + struct { >>>=20 >>> + UINT32 Reserved:4; >>>=20 >>> + UINT32 BarSizeCapability:28; >>>=20 >>> + } Bits; >>>=20 >>> + UINT32 Uint32; >>>=20 >>> +} PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CAPABILITY; >>>=20 >>> + >>>=20 >>> + >>>=20 >>> +typedef union { >>>=20 >>> + struct { >>>=20 >>> + UINT32 BarIndex:3; >>>=20 >>> + UINT32 Reserved:2; >>>=20 >>> + UINT32 ResizableBarNumber:3; >>>=20 >>> + UINT32 BarSize:6; >>>=20 >>> + UINT32 Reserved2:2; >>>=20 >>> + UINT32 BarSizeCapability:16; >>>=20 >>> + } Bits; >>>=20 >>> + UINT32 Uint32; >>>=20 >>> +} PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CONTROL; >>>=20 >>> + >>>=20 >>> typedef struct { >>>=20 >>> - UINT32 >>> ResizableBarCapability; >>>=20 >>> - UINT16 >>> ResizableBarControl; >>>=20 >>> - UINT16 >>> Reserved; >>>=20 >>> + PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CAPABILITY >>> ResizableBarCapability; >>>=20 >>> + PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_CONTROL >>> ResizableBarControl; >>>=20 >>> } PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_ENTRY; >>>=20 >>>=20 >>>=20 >>> typedef struct { >>>=20 >>> @@ -643,7 +663,7 @@ typedef struct { >>> PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR_ENTRY >>> Capability[1]; >>>=20 >>> } PCI_EXPRESS_EXTENDED_CAPABILITIES_RESIZABLE_BAR; >>>=20 >>>=20 >>>=20 >>> -#define GET_NUMBER_RESIZABLE_BARS(x) >>> (((x->Capability[0].ResizableBarControl) & 0xE0) >> 5) >>>=20 >>> +#define GET_NUMBER_RESIZABLE_BARS(x) >>> (x->Capability[0].ResizableBarControl.Bits.ResizableBarNumber) >>>=20 >>>=20 >>>=20 >>> #define PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_ID >>> 0x000E >>>=20 >>> #define PCI_EXPRESS_EXTENDED_CAPABILITY_ARI_CAPABILITY_VER1 0x1 >>>=20 >>> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >>> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >>> index 3e138188ce..5077d56fed 100644 >>> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >>> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c >>> @@ -1,7 +1,7 @@ >>> /** @file >>>=20 >>> Main file for Pci shell Debug1 function. >>>=20 >>>=20 >>>=20 >>> - Copyright (c) 2005 - 2019, Intel Corporation. All rights >>> reserved.
>>>=20 >>> + Copyright (c) 2005 - 2020, Intel Corporation. All rights >>> + reserved.
>>>=20 >>> (C) Copyright 2013-2015 Hewlett-Packard Development Company, >>> L.P.
>>>=20 >>> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>>>=20 >>> SPDX-License-Identifier: BSD-2-Clause-Patent >>>=20 >>> @@ -5534,8 +5534,8 @@ >>> PrintInterpretedExtendedCompatibilityResizeableBar ( >>> STRING_TOKEN (STR_PCI_EXT_CAP_RESIZE_BAR), >>>=20 >>> gShellDebug1HiiHandle, >>>=20 >>> ItemCount+1, >>>=20 >>> - Header->Capability[ItemCount].ResizableBarCapability, >>>=20 >>> - Header->Capability[ItemCount].ResizableBarControl >>>=20 >>> + Header->Capability[ItemCount].ResizableBarCapability.Uint32, >>>=20 >>> + Header->Capability[ItemCount].ResizableBarControl.Uint32 >>>=20 >>> ); >>>=20 >>> } >>>=20 >>>=20 >>>=20 >>> -- >>> 2.24.0.windows.2 >>>=20 >>>=20 >>>=20 >>> -=3D-=3D-=3D-=3D-=3D-=3D >>> Groups.io Links: You receive all messages sent to this group. >>> View/Reply Online (#69477): >>> https://edk2.groups.io/g/devel/message/69477 >>> Mute This Topic: https://groups.io/mt/79265864/4905953 >>> Group Owner: devel+owner@edk2.groups.io >>> Unsubscribe: https://edk2.groups.io/g/devel/unsub >>> [gaoliming@byosoft.com.cn] >>> -=3D-=3D-=3D-=3D-=3D-=3D >>>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >=20 >=20 >=20 >=20 >=20 >=20