Re: [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver

["Li, Songpeng" <songpeng.li@intel.com>]

Thanks for the review, this patch and its version 2 are both dropped.


Best,
Songpeng


-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@linaro.org] 
Sent: Monday, October 29, 2018 7:40 PM
To: Li, Songpeng <songpeng.li@intel.com>
Cc: edk2-devel@lists.01.org; Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: Re: [edk2] [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver

Hi Songpeng,

On Mon, Oct 29, 2018 at 09:53:22AM +0800, Songpeng Li wrote:
> Please refer to the log message of each commit for more details.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1278
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Songpeng Li (4):
>   MdeModulePkg: Add Tag Protocol for PxeBc Driver Conflict Detection.
>   MdeModulePkg/UefiPxeBcDxe: Add Conflict Detection Process.
>   NetworkPkg/UefiPxeBcDxe: Add Conflict Detection Process.
>   NetworkPkg/TcpDxe: Modify the Version of Driver Binding Protocol
> 
>  MdeModulePkg/Include/Protocol/PxeBcTag.h      | 26 ++++++++++++
>  MdeModulePkg/MdeModulePkg.dec                 |  5 +++
>  .../Network/UefiPxeBcDxe/PxeBcDriver.c        | 19 ++++++++-
>  .../Network/UefiPxeBcDxe/PxeBcImpl.h          |  3 +-
>  .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf     |  1 +

Can you ensure you use the options specified in
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
when generating your patches?

This way we don't need to guess which files are being modified when looking at the summary. And it sorts the files modified by decreasing level of abstraction - so we (for example) see changes to structs before we see changes to how structs are used.

(This comment does not in itself motivate a v2.)

Best Regards,

Leif

>  NetworkPkg/TcpDxe/TcpDriver.c                 |  4 +-
>  NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c         | 42 ++++++++++++++++++-
>  NetworkPkg/UefiPxeBcDxe/PxeBcImpl.h           |  1 +
>  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf      |  1 +
>  9 files changed, 96 insertions(+), 6 deletions(-)  create mode 100644 
> MdeModulePkg/Include/Protocol/PxeBcTag.h
>
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel