From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=songpeng.li@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E9DD2117D758 for ; Mon, 29 Oct 2018 19:22:14 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2018 19:22:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,442,1534834800"; d="scan'208";a="96117890" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2018 19:22:13 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 19:22:13 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Tue, 30 Oct 2018 10:22:11 +0800 From: "Li, Songpeng" To: Leif Lindholm CC: "edk2-devel@lists.01.org" , "Ye, Ting" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [edk2] [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver Thread-Index: AQHUb3wuKzZaw+eCBkqoy1H1zhin7KU3DTzA Date: Tue, 30 Oct 2018 02:22:11 +0000 Message-ID: References: <20181029015326.8528-1-songpeng.li@intel.com> <20181029114014.mr44nd673siy6w5x@bivouac.eciton.net> In-Reply-To: <20181029114014.mr44nd673siy6w5x@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQ1ODFiNjAtNzQyOS00ZTg4LThiYmUtOGY3MTNjNzE3ZTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWDliUnU5TnRCSFwvZG9EazJ5SzYzNGU1ZExreWwxZ0NrYm15YWJkMDdMVGh5TEdpNjNFcjRqcDJEc3Rmbm55S2YifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 02:22:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the review, this patch and its version 2 are both dropped. Best, Songpeng -----Original Message----- From: Leif Lindholm [mailto:leif.lindholm@linaro.org]=20 Sent: Monday, October 29, 2018 7:40 PM To: Li, Songpeng Cc: edk2-devel@lists.01.org; Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: Re: [edk2] [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver Hi Songpeng, On Mon, Oct 29, 2018 at 09:53:22AM +0800, Songpeng Li wrote: > Please refer to the log message of each commit for more details. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1278 > Cc: Ye Ting > Cc: Wu Jiaxin > Cc: Fu Siyuan > Songpeng Li (4): > MdeModulePkg: Add Tag Protocol for PxeBc Driver Conflict Detection. > MdeModulePkg/UefiPxeBcDxe: Add Conflict Detection Process. > NetworkPkg/UefiPxeBcDxe: Add Conflict Detection Process. > NetworkPkg/TcpDxe: Modify the Version of Driver Binding Protocol >=20 > MdeModulePkg/Include/Protocol/PxeBcTag.h | 26 ++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 5 +++ > .../Network/UefiPxeBcDxe/PxeBcDriver.c | 19 ++++++++- > .../Network/UefiPxeBcDxe/PxeBcImpl.h | 3 +- > .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 1 + Can you ensure you use the options specified in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-= guide-for-edk2-contributors-and-maintainers#contrib-23 when generating your patches? This way we don't need to guess which files are being modified when looking= at the summary. And it sorts the files modified by decreasing level of abs= traction - so we (for example) see changes to structs before we see changes= to how structs are used. (This comment does not in itself motivate a v2.) Best Regards, Leif > NetworkPkg/TcpDxe/TcpDriver.c | 4 +- > NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 42 ++++++++++++++++++- > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.h | 1 + > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 1 + > 9 files changed, 96 insertions(+), 6 deletions(-) create mode 100644=20 > MdeModulePkg/Include/Protocol/PxeBcTag.h > > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel