From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=songpeng.li@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 52E53211BA45F for ; Thu, 24 Jan 2019 21:08:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 21:08:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,519,1539673200"; d="scan'208";a="269768724" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 24 Jan 2019 21:08:26 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 24 Jan 2019 21:08:26 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 24 Jan 2019 21:08:26 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.207]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.174]) with mapi id 14.03.0415.000; Fri, 25 Jan 2019 13:08:22 +0800 From: "Li, Songpeng" To: Vladimir Olovyannikov , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" , "Ni, Ray" Thread-Topic: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper status Thread-Index: AQHUs0lVw2s54+TyoUeXAqzNupiW/KW/cS2w Date: Fri, 25 Jan 2019 05:08:21 +0000 Message-ID: References: <20190123182615.3184-1-vladimir.olovyannikov@broadcom.com> In-Reply-To: <20190123182615.3184-1-vladimir.olovyannikov@broadcom.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/TftpDynamicCommand: Return proper status X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 05:08:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Songpeng Li Sorry, the previous email did not include edk2 mailing list. Best, Songpeng > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Vladimir Olovyannikov via edk2-devel > Sent: Thursday, January 24, 2019 2:26 AM > To: Carsey, Jaben ; Ni, Ray ; > edk2-devel@lists.01.org > Cc: Vladimir Olovyannikov > Subject: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper > status >=20 > Tftp command always returned "SHELL_NOT_FOUND" which is treated as an > error by callers. Add missing line to clean the ShellStatus on > successful operation. If operation has failed, return the error status > if available. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vladimir Olovyannikov > > --- > ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > index ba753a279b00..88e3988a554e 100644 > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c > @@ -548,6 +548,8 @@ RunTftp ( > goto NextHandle; > } >=20 > + ShellStatus =3D SHELL_SUCCESS; > + > NextHandle: >=20 > CloseProtocolAndDestroyServiceChild ( > @@ -575,6 +577,10 @@ RunTftp ( > FreePool (Handles); > } >=20 > + if ((ShellStatus !=3D SHELL_SUCCESS) && (EFI_ERROR(Status))) { > + ShellStatus =3D Status & ~MAX_BIT; > + } > + > return ShellStatus; > } >=20 > -- > 2.20.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel