Re: [edk2-devel] [PATCH v2 085/105] .mailmap: Add an entry for Songpeng Li

["Li, Aaron" <aaron.li@intel.com>]

Hi Laszlo,

Thanks for your suggestion, I agree with that, Aaron Li <aaron.li@intel.com> 
is my canonical name.


Best,
Aaron

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, December 10, 2019 12:26 AM
> To: devel@edk2.groups.io; Li, Aaron <aaron.li@intel.com>; Philippe Mathieu-
> Daude <philmd@redhat.com>
> Subject: Re: [edk2-devel] [PATCH v2 085/105] .mailmap: Add an entry for
> Songpeng Li
> 
> Hi Aaron,
> 
> On 12/09/19 02:51, Li, Aaron wrote:
> > Reviewed-by: Songpeng Li <songpeng.li@intel.com>
> >
> > Also, my name is changed to Aaron Li <aaron.li@intel.com>
> > You can also add this name to the list, thanks.
> 
> which one is the "authoritative" first name that you would like to use
> in edk2 context?
> 
> For example, if you sent a patch tomorrow, would it come from
> 
> - Aaron Li <aaron.li@intel.com>
> 
> or
> 
> - Songpeng Li <songpeng.li@intel.com>
> 
> ?
> 
> The idea of the mailmap file is that we establish a "canonical" and
> "live" {name, email-address} pair for each contributor, and map
> everything else that has stood for the same contributor in the past to
> the canonical pair.
> 
> (We have to be careful with cross-domain mappings, such as
> cross-employer mappings -- which is why every contributor is asked to
> R-b such changes, from their current (hence canonical) address.)
> 
> In fact your present email contains R-b from "Songpeng" in the body, but
> the "From:" header on your email says "Aaron". So I would suggest that
> Phil capture "Aaron" as your canonical name, and map "Songpeng" to it.
> Then we'd ask you to R-b that patch from your "Aaron" address.
> 
> Does that make sense?
> 
> Thanks,
> Laszlo
> 
> 
> >> -----Original Message-----
> >> From: Philippe Mathieu-Daude <philmd@redhat.com>
> >> Sent: Friday, December 6, 2019 7:26 PM
> >> To: devel@edk2.groups.io
> >> Cc: Philippe Mathieu-Daude <philmd@redhat.com>; Li, Aaron
> >> <aaron.li@intel.com>
> >> Subject: [PATCH v2 085/105] .mailmap: Add an entry for Songpeng Li
> >>
> >> We use .mailmap to display contributors email addresses in an
> >> uniform format.
> >>
> >> Add an entry for Songpeng Li to have his name and email address
> >> displayed properly in the git history.
> >>
> >> Cc: Songpeng Li <songpeng.li@intel.com>
> >> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> >> ---
> >> [Due to MTA restricting the recipient list to 100, I can not Cc all the
> >>  named developers in the cover. Therefore I'm adapting the explaination
> >>  from the cover in each patch]
> >>
> >> This patch won't get merged if Songpeng Li doesn't give his
> >> approval, by replying to this patch with:
> >>   Reviewed-by: Songpeng Li <songpeng.li@intel.com>
> >>
> >> If you think this patch is inappropriate, you don't need to justify,
> >> reply with:
> >>   NAcked-by: Songpeng Li <songpeng.li@intel.com>
> >> or simply:
> >>   NACK
> >>
> >> If your Firstname Lastname order is incorrect, tell me and I will fix it.
> >>
> >> You can also ignore this mail, but I might resend it and keep bothering
> >> you.
> >>
> >> Regards,
> >>
> >> Phil.
> >> ---
> >>  .mailmap | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/.mailmap b/.mailmap
> >> index faafd9614e42..20610fcf221d 100644
> >> --- a/.mailmap
> >> +++ b/.mailmap
> >> @@ -165,3 +165,4 @@ Siyuan Fu <siyuan.fu@intel.com>
> >>  Siyuan Fu <siyuan.fu@intel.com> <C:/Program Files
> >> (x86)/Git/o=Intel/ou=Exchange Administrative Group
> >> (FYDIBOHF23SPDLT)/cn=Recipients/cn=sfu5>
> >>  Siyuan Fu <siyuan.fu@intel.com> <sfu5@6f19259b-4bc3-4df7-8a09-
> >> 765794883524>
> >>  Siyuan Fu <siyuan.fu@intel.com> <sfu5@Edk2>
> >> +Songpeng Li <songpeng.li@intel.com>
> >> --
> >> 2.21.0
> >
> >
> > 
> >