Re: [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI

["Li, Songpeng" <songpeng.li@intel.com>]

The variable in memory is stored as little endian, so the byte 0 is actually stored in the last byte in memory.


Best,
Songpeng

> -----Original Message-----
> From: Fu, Siyuan
> Sent: Thursday, September 27, 2018 3:51 PM
> To: Li, Songpeng <songpeng.li@intel.com>; edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in
> DevPathToTextiSCSI
> 
> Hi, Songpeng
> 
> According to the iSCSI text device note in UEFI spec, the byte 0 of LUN should
> come first, seems there is no problem in original code logic. Could you please
> double confirm that?
> 	"The LUN is an 8 byte array that is displayed in hexadecimal format
> with byte 0 first (i.e., on the left) and byte 7 last (i.e, on the right), and is
> required."
> 
> 
> BestRegards
> Fu Siyuan
> 
> > -----Original Message-----
> > From: Li, Songpeng
> > Sent: Thursday, September 27, 2018 3:37 PM
> > To: edk2-devel@lists.01.org
> > Cc: Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>;
> > Gao, Liming <liming.gao@intel.com>
> > Subject: [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in
> > DevPathToTextiSCSI
> >
> > In DevPathToTextiSCSI(), ISCSIDevPath->Lun is printed in reversed orders.
> >
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1216
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Songpeng Li <songpeng.li@intel.com>
> > ---
> >  MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > index 7d8d304f6f..3f6478e43c 100644
> > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> > @@ -1548,7 +1548,7 @@ DevPathToTextiSCSI (
> >      ISCSIDevPath->TargetName,
> >      ISCSIDevPath->TargetPortalGroupTag
> >      );
> > -  for (Index = 0; Index < sizeof (ISCSIDevPath->Lun) / sizeof (UINT8);
> > Index++) {
> > +  for (Index = sizeof (ISCSIDevPath->Lun) / sizeof (UINT8) - 1; Index >=
> > 0; Index--) {
> >      UefiDevicePathLibCatPrint (Str, L"%02x", ((UINT8 *)&ISCSIDevPath-
> > >Lun)[Index]);
> >    }
> >    Options = ISCSIDevPath->LoginOption;
> > --
> > 2.18.0.windows.1