From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.7999.1576658210609870384 for ; Wed, 18 Dec 2019 00:36:51 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: daniel.pawel.banaszek@intel.com) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 00:36:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,328,1571727600"; d="diff'223?zip'223,48?scan'223,48,48,217,208,223";a="205771243" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga007.jf.intel.com with ESMTP; 18 Dec 2019 00:36:48 -0800 Received: from irsmsx112.ger.corp.intel.com ([169.254.1.125]) by IRSMSX153.ger.corp.intel.com ([169.254.9.183]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 08:36:47 +0000 From: "Banaszek, Daniel Pawel" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Ni, Ray" Subject: Re: ASAP Issue in PciExpress21.h Thread-Topic: ASAP Issue in PciExpress21.h Thread-Index: AdWo/dsoRNStWlG3RdynV5VYlDmDbwAIMMVgAxe/25A= Importance: high X-Priority: 1 Date: Wed, 18 Dec 2019 08:36:46 +0000 Message-ID: References: <734D49CCEBEEF84792F5B80ED585239D5C389063@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C389063@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODM0YzU1NTMtZmYxYy00M2FlLTg1OTUtM2NlMWFiOTZmM2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibFNscEZuZTdiUTNTYzBDajZDcGV5TFdHWlVMd0pGM3VvQ2dcL012TEcxS0dvdTZPU0dFMExTRkoxUWpJSVwvYVwvVyJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.182] MIME-Version: 1.0 X-Groupsio-MsgNum: 52360 Content-Language: en-US Content-Type: multipart/mixed; boundary="_004_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_" --_004_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_ Content-Type: multipart/alternative; boundary="_000_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_" --_000_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable I attached a patch witch change that is needed in EDK2 code as it is descri= bed. PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !! Issue is UINT16 LtrMechanism There is 2 instead of 1. - UINT16 LtrMechanism : 2; + UINT16 LtrMechanism : 1; Daniel Banaszek BIOS Engineer - IGK1-245 Intel Server UEFI Firmware Development Team ___________________________________________________________________________= ___ From: Ni, Ray Sent: Monday, 2 December, 2019 15:45 To: Banaszek, Daniel Pawel Cc: Gao, Liming Subject: RE: ASAP Issue in PciExpress21.h Daniel, thank you for finding such a critical issue. Can you please submit an open source patch for this? Thanks, Ray From: Banaszek, Daniel Pawel > Sent: Monday, December 2, 2019 6:54 PM To: Ni, Ray > Subject: ASAP Issue in PciExpress21.h Hi There I an issue in MdePkg/Include/IndustryStandard/PciExpress21.h PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !! Issue is UINT16 LtrMechanism There is 2 instead of 1. - UINT16 LtrMechanism : 2; + UINT16 LtrMechanism : 1; Who can commit the change? Thanks Daniel Banaszek BIOS Engineer - IGK1-245 Intel Server UEFI Firmware Development Team Intel Technology Poland Sp. z o.o. -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited. --_000_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_ Content-Type: text/html; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

I attached a patch witch change that is needed in ED= K2 code as it is described.

 

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16= but has 17 bits !!

 

Issue is UINT16 LtrMechanism

There is 2 instead of 1.

-    UINT16 LtrMechanism : 2;

+    UINT16 LtrMechanism : 1;

 

 

 

Danie= l Banaszek

BI= OS Engineer – IGK1-245

In= tel Server UEFI Firmware Development Team

____________________________________________________= __________________________

 

From: Ni,= Ray <ray.ni@intel.com>
Sent: Monday, 2 December, 2019 15:45
To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com> Cc: Gao, Liming <liming.gao@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h

 

Daniel,

thank you for finding such a critical issue.

Can you please submit an open source patch for this?=

 

Thanks,

Ray

 

 

From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com&= gt;
Sent: Monday, December 2, 2019 6:54 PM
To: Ni, Ray <ray.ni@intel.com= >
Subject: ASAP Issue in PciExpress21.h

 

Hi

There I an issue in

MdePkg/Include/IndustryStandard/PciExpress21.h<= /o:p>

 

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but ha= s 17 bits !!

 

Issue is UINT16 LtrMechanism

There is 2 instead of 1.

-    UINT16 LtrMechanism : 2;

+    UINT16 LtrMechanism : 1;

 

Who can commit the change?

 

Thanks

Danie= l Banaszek

BI= OS Engineer – IGK1-245

In= tel Server UEFI Firmware Development Team

Intel Technology Poland Sp. z o.o.

 

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gd= ańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 = | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.

Ta wiadomość wraz z załącznikami jest przeznaczona d= la określonego adresata i może zawierać informacje poufne. W razie przypadkowego o= trzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usu= nięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by oth= ers is strictly prohibited.

--_000_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_-- --_004_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_ Content-Type: application/x-zip-compressed; name="18c9006.diff.zip" Content-Description: 18c9006.diff.zip Content-Disposition: attachment; filename="18c9006.diff.zip"; size=690; creation-date="Wed, 18 Dec 2019 08:33:36 GMT"; modification-date="Wed, 18 Dec 2019 08:33:36 GMT" Content-Transfer-Encoding: base64 UEsDBBQACAgIAOwskU8AAAAAAAAAAAAAAAAMAAAAMThjOTAwNi5kaWZmlVNdb5swFH23tP9w31MS GwgENk1pCV2RmiZKsr1MU+SPC/GamAxMP/br56TRtE7tpiKE5XvvOT7cc33Z1DtgI5lQGolyGAh/ WAZxmIhIjBCHLFSCIpVUUckjmNYGlrgHFgOl6fEFn1JGLh1NChNuNG5hzu/d94Ib3v7EW/igjuH+ /hDui1N4rI11W1nvPpIJt5jCqsOzA/MEpSNlCbAwDZLUH0KPMkrJshPfUdoUvs7PV9nVN5gqnN9W g0FhVNfa5nFpuVG8UYO51PnDvsG29VkK86xYL/JPa7fm60n+pcjydTa7WS1m1z44XCct6BY+Fzcr FoHoLGx4exAitG0JmeCdlghZbWxTb8GH5RHSNejq7hC4cei2wz6Ba9tMUW7c77Y78MBu0BU5av9I Bdq0FrmCugTWJ+SqVR62nlapM4AmwYgGoU9I5vAVeoULFyMlY8YQecKjkEec+QH3haJJGSvOKQoW i9J3qKWuDCqvLktPPKa/e3/23JL/O+F5HiFKlyV4XqUt8MGpyYWR207hv3vd34B4I4Boo/ABQt/n TI76fRXTiLneO8OjMDzoebMG0uv13q5jPAYvoOFZDL2nZTwmcHhOc3Fu652Ws31eHSAX21realOB 8+79u2eFhaoX+KPD1r6czOrdfotWu6v0lPf+yD+boBR8l+69nv6bPd9hU6GRj/P6HpsFKjen7pzX 5azQXGi74tWpBJvccLHFF0pnwg3Fk6JfUEsHCOTBDVcoAgAANAQAAFBLAQIUABQACAgIAOwskU/k wQ1XKAIAADQEAAAMAAAAAAAAAAAAAAAAAAAAAAAxOGM5MDA2LmRpZmZQSwUGAAAAAAEAAQA6AAAA YgIAAAAA --_004_F5F808F35CD2604094D883EDBD44909B5556A82Eirsmsx112gercor_--