From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rn-mailsvcp-ppex-lapp35.apple.com (rn-mailsvcp-ppex-lapp35.apple.com [17.179.253.44]) by mx.groups.io with SMTP id smtpd.web12.979.1636483891136734561 for ; Tue, 09 Nov 2021 10:51:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=jxoRwLOD; spf=pass (domain: apple.com, ip: 17.179.253.44, mailfrom: afish@apple.com) Received: from pps.filterd (rn-mailsvcp-ppex-lapp35.rno.apple.com [127.0.0.1]) by rn-mailsvcp-ppex-lapp35.rno.apple.com (8.16.1.2/8.16.1.2) with SMTP id 1A9Imsrn030762; Tue, 9 Nov 2021 10:51:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=xKROT14Qo8orwQ/7EGS8XuU4t13rTldmsmQbs2YGvKY=; b=jxoRwLODx9SI9VCh9xZqViQ4DRM/PoE1Sf8ul1uLYh8dy4May06Xdr9qa9mfqpDmQb1W t+NX9913gwy8tiNetLnnAhLzhNRmws2M33QO60R2klGPuXqjOKaKetawbN2fzL5kHlhF 7uGj4MbAm1O924wHLmtTCD4FO2vdkMyJxRLOmHQBdRP2vZM8c4BxiqZrDcyyjXu2Soiw vWy/6g6FgB3q8jgMimqTaM9WSOLQZWfWnm/adcTxIvy+sTQ6xX4/rXiQi7qnGJ1C9rOl 8DaJXDTFGAo2DaWM+T6gWjH1YlIQtQ0tnlCWRh2XID5+rRpuVt+b42N2GZN/ojTOYK66 1Q== Received: from rn-mailsvcp-mta-lapp01.rno.apple.com (rn-mailsvcp-mta-lapp01.rno.apple.com [10.225.203.149]) by rn-mailsvcp-ppex-lapp35.rno.apple.com with ESMTP id 3c5n87hn5y-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 09 Nov 2021 10:51:29 -0800 Received: from rn-mailsvcp-mmp-lapp03.rno.apple.com (rn-mailsvcp-mmp-lapp03.rno.apple.com [17.179.253.16]) by rn-mailsvcp-mta-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) with ESMTPS id <0R2B0056BJ1S7040@rn-mailsvcp-mta-lapp01.rno.apple.com>; Tue, 09 Nov 2021 10:51:28 -0800 (PST) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp03.rno.apple.com by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) id <0R2B00J00IT26X00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Tue, 09 Nov 2021 10:51:28 -0800 (PST) X-Va-A: X-Va-T-CD: 70a38c3f5b1d46c4b8dccb3b011be358 X-Va-E-CD: 1a9a78a1028e160eee879a88543a4be4 X-Va-R-CD: a22a84429969b2cfddda1fb1565349b2 X-Va-CD: 0 X-Va-ID: 848facd2-a602-4981-9221-3aa85539d957 X-V-A: X-V-T-CD: 70a38c3f5b1d46c4b8dccb3b011be358 X-V-E-CD: 1a9a78a1028e160eee879a88543a4be4 X-V-R-CD: a22a84429969b2cfddda1fb1565349b2 X-V-CD: 0 X-V-ID: b75e1a99-02ee-4aed-ade7-84aa8490312e X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-09_05:2021-11-08,2021-11-09 signatures=0 Received: from smtpclient.apple (unknown [17.235.8.214]) by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) with ESMTPSA id <0R2B00YK2J1ROI00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Tue, 09 Nov 2021 10:51:27 -0800 (PST) MIME-version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [edk2-devel] Update NASM to stable release 2.15.05 From: "Andrew Fish" In-reply-to: Date: Tue, 09 Nov 2021 10:51:26 -0800 Cc: Sean Brogan , "rfc@edk2.groups.io" Message-id: References: <1BD86940-6B6C-4390-8902-59E86057AEF6@apple.com> To: edk2-devel-groups-io , Mike Kinney X-Mailer: Apple Mail (2.3693.20.0.1.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-09_05:2021-11-08,2021-11-09 signatures=0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable > On Nov 9, 2021, at 10:39 AM, Michael D Kinney wrote: >=20 > Hi Andrew, >=20 > It looks like the EDK II CI agents were updated to use NASM 2.15.05 back = in March of this year. >=20 > https://github.com/tianocore/edk2/blob/0ecdcb6142037dd1cdd08660a2349960b= cf0270a/BaseTools/Bin/nasm_ext_dep.yaml >=20 > So I think the only remaining task is to update the developer documentati= on to require NASM 2.15.05 as the new minimum required version. >=20 > Do you agree? Yes sounds good. Thanks, Andrew Fish >=20 > Mike >=20 >> -----Original Message----- >> From: Andrew Fish >> Sent: Wednesday, October 20, 2021 11:05 AM >> To: edk2-devel-groups-io ; Kinney, Michael D >> Cc: rfc@edk2.groups.io >> Subject: Re: [edk2-devel] Update NASM to stable release 2.15.05 >>=20 >> Mike, >>=20 >> Sounds like a good plan. >>=20 >> Thanks, >>=20 >> Andrew Fish >>=20 >>> On Oct 20, 2021, at 9:51 AM, Michael D Kinney wrote: >>>=20 >>> Hello, >>>=20 >>> I would like to propose that we update to a newer version of NASM. >>>=20 >>> https://www.nasm.us/ >>>=20 >>> The most recent stable version is 2.15.05. >>>=20 >>> https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/ >>>=20 >>> NASM 2.15.05 Documentation: >>>=20 >>> https://nasm.us/xdoc/2.15.05/html/ >>> https://nasm.us/xdoc/2.15.05/nasmdoc.pdf >>>=20 >>>=20 >>> The reason to update is to use a version of NASM that supports >>> newer instructions that will allow the .nasm files with >>> DB statements for instructions to be updated to use >>> instruction names. This improves the readability/maintenance >>> of the .nasm source files: >>>=20 >>> https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41 >>>=20 >>> Also, the work on tools such as uncrustify to format source files >>> require tests to make sure the source format changes do not cause >>> any functional changes. Compilers support flags for reproducible >>> builds. NASM 2.15.05 added the --reproducible flag that provides >>> the same feature for OBJ files produces by NASM. >>>=20 >>> https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34 >>>=20 >>>=20 >>> 2.1.34 The --reproducible Option >>>=20 >>> If this option is given, NASM will not emit information that is >>> inherently dependent on the NASM version or different from run to >>> run (such as timestamps) into the output file. >>>=20 >>> Please let me know if there are any concerns with doing this tool updat= e. >>> If there are no concerns, I will work on patches required to update >>> EDK II CI to use NASM 2.15.05 and to update the developer documentation >>> to require NASM 2.15.05 as the new minimum version. >>>=20 >>> Thanks, >>>=20 >>> Mike >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >=20 >=20 >=20 >=20 >=20 >=20