From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E9E9211CFBFA for ; Wed, 6 Mar 2019 08:47:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 08:47:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,448,1544515200"; d="scan'208,217";a="138569870" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 06 Mar 2019 08:47:12 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Mar 2019 08:47:11 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.115]) by fmsmsx117.amr.corp.intel.com ([169.254.3.143]) with mapi id 14.03.0415.000; Wed, 6 Mar 2019 08:47:11 -0800 From: "Carsey, Jaben" To: Nariman Poushin CC: "Gao, Zhichao" , "edk2-devel@lists.01.org" , "Gao, Liming" Thread-Topic: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni Thread-Index: AQHU0+r2/o3RWmvDkU6Tcr33SSSm3qX+vmZwgACLgQD//4a/Tg== Date: Wed, 6 Mar 2019 16:47:10 +0000 Message-ID: References: <20190306070514.19220-1-zhichao.gao@intel.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 16:47:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good catch. After fixing this typo, my RB stands. On Mar 6, 2019, at 7:59 AM, Nariman Poushin > wrote: On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben > wrote: Reviewed-by: Jaben Carsey > > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, March 05, 2019 11:05 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray >; Carsey, Jaben <= jaben.carsey@intel.com>; > Gao, Liming > > Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note > in uni > Importance: High > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1146 > > Add DSDT and SSDT description in the help information. Depend > on the implement of UefiShellAcpiViewCommandLib, the "acpiview" > command support to show all present type in the system not only > support the listed type in the help information. So change the > help information of this command. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > > Cc: Ruiyu Ni > > Cc: Jaben Carsey > > Cc: Liming Gao > > --- > .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8 > +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > index 0762eeba53..f2a2400b91 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > @@ -74,10 +74,15 @@ > " 1. The AcpiTable parameter can match any installed table type.\r\n" > " Tables without specific handling will be displayed as a raw hex d= ump > (or\r\n" > " dumped to a file if -d is used).\r\n" > -" 2. Formatted display and checking is provided for these signature > types:\r\n" > +" 2. -s option supports to display the specified AcpiTable type that i= s > present\r\n" > +" in the system. For normal type AcpiTable, it would display the da= ta of > the\r\n" > +" AcpiTable and AcpiTable header. The following type may contain he= ader > type\r\n" > +" other than AcpiTable header. The acual header can refer to the AC= PI > spec 6.2\r\n" > +" Extra A. Particual types:\r\n" Should this be "Particular"? > " APIC - Multiple APIC Description Table (MADT)\r\n" > " BGRT - Boot Graphics Resource Table\r\n" > " DBG2 - Debug Port Table 2\r\n" > +" DSDT - Differentiated System Description Table\r\n" > " FACP - Fixed ACPI Description Table (FADT)\r\n" > " GTDT - Generic Timer Description Table\r\n" > " IORT - IO Remapping Table\r\n" > @@ -87,6 +92,7 @@ > " SLIT - System Locality Information Table\r\n" > " SPCR - Serial Port Console Redirection Table\r\n" > " SRAT - System Resource Affinity Table\r\n" > +" SSDT - Secondary SystemDescription Table\r\n" > " XSDT - Extended System Description Table\r\n" > " \r\n" > ".SH STANDARDS\r\n" > -- > 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel