Re: [staging/edk2-test PATCH 1/6] edk2-test: Update Readme.md

[Andrew Fish <afish@apple.com>]

> On Jan 31, 2017, at 2:41 PM, Supreeth Venkatesh <Supreeth.Venkatesh@arm.com> wrote:
> 
> On Tue, 2017-01-31 at 20:29 +0100, Michael Zimmermann wrote:
>> nothing of importance(and most likely not related to this commit
>> because it has been there before), but you misspelled staging as
>> 'stagaing' :)
>> 
> 1. Yes. I noticed it too. Will fix this with a new patch.
> 
> 2. I see that there are additional errors when I try to build it with
> warnings treated as error flag enabled.
> 
> Examples below:
> 
>    CHAR8               *P;
>                         ^
> cc1: all warnings being treated as errors
> 
> /home/supven01/edk2-test/edk2-staging/TestFrameworkPkg/Eftp/EftpRRQ.c:
> In function \u2018EftpRrqInitRcvData\u2019:
> /home/supven01/edk2-test/edk2-
> staging/TestFrameworkPkg/Eftp/EftpRRQ.c:770:24: error: variable
> \u2018Opt\u2019 set but not used [-Werror=unused-but-set-variable]
>    EFTP_OPTION         *Opt;
>                         ^
> /home/supven01/edk2-test/edk2-staging/TestFrameworkPkg/Eftp/EftpRRQ.c:
> In function \u2018EftpRrqActiveRcvData\u2019:
> /home/supven01/edk2-test/edk2-
> staging/TestFrameworkPkg/Eftp/EftpRRQ.c:1212:24: error: variable
> \u2018Rrq\u2019 set but not used [-Werror=unused-but-set-variable]
>    EFTP_RRQ_STATE      *Rrq;
>                         ^
> /home/supven01/edk2-test/edk2-
> staging/TestFrameworkPkg/Eftp/EftpRRQ.c:1211:24: error: variable
> \u2018Opt\u2019 set but not used [-Werror=unused-but-set-variable]
>    EFTP_OPTION         *Opt;
> 
> 3. For Linux build, there is a post build failure, GenFramework.sh
> corresponding to GenFramework.cmd is missing. Please let me know, if
> you already have this file, if not, will fix this in my next patch.
> 

Mike and I talked about that. I think he was looking into porting the script to Python so it would be portable across different operating systems. 

This failure brings up a more general issue that PREBUILD and POSTBUILD steps don't do a good job in a multi OS setting. 

Thanks,

Andrew Fish

> Thanks,
> Supreeth
>> On Tue, Jan 31, 2017 at 7:45 PM, Michael Kinney
>> <michael.d.kinney@intel.com> wrote:
>>> 
>>> * Add Supreeth Venkatesh to list of branch owners
>>> * Clean up environment variable for Windows builds
>>> * Add Linux Build Instructions
>>> 
>>> Cc: Andrew Fish <afish@apple.com>
>>> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
>>> ---
>>>  Readme.md | 50 +++++++++++++++++++++++++++++++++++++++++++++++---
>>>  1 file changed, 47 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/Readme.md b/Readme.md
>>> index 4ca0ffa..572014a 100644
>>> --- a/Readme.md
>>> +++ b/Readme.md
>>> @@ -5,6 +5,7 @@ edk2 repository and platform firmware that is based
>>> on the edk2 repository.
>>> 
>>>  ## **edk2-stagaing branch owners**
>>>  * Michael Kinney <michael.d.kinney@intel.com>
>>> +* Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
>>> 
>>>  ## **Features**
>>>  * Test harness that runs from the UEFI Shell
>>> @@ -76,13 +77,13 @@ build output directory.
>>> 
>>>  ```cmd
>>>  git clone https://github.com/tianocore/edk2.git
>>> -git clone https://github.com/tianocore/edk2-staging.git --brach
>>> edk2-test
>>> +git clone https://github.com/tianocore/edk2-staging.git --branch
>>> edk2-test
>>> 
>>>  set WORKSPACE=%CD%
>>>  set EDK_TOOLS_PATH=%WORKSPACE%\edk2\BaseTools
>>> +set EDK_TOOLS_BIN=%EDK_TOOLS_PATH%\BinWrappers\WindowsLike
>>>  set PACKAGES_PATH=%WORKSPACE%\edk2;%WORKSPACE%\edk2-staging
>>> -set EDK_TOOLS_BIN=%WORKSPACE%\BaseTools\BinWrappers\WindowsLike
>>> -path=%path%;%WORKSPACE%\edk2\BaseTools\Bin\Win32
>>> +path=%path%;%EDK_TOOLS_PATH%\Bin\Win32
>>> 
>>>  cd edk2
>>>  edkSetup.bat
>>> @@ -93,6 +94,49 @@ build -a IA32 -a X64 -t VS2015x86 -p
>>> TestCasePkg/TestCasePkg.dsc
>>> 
>>>  ## **Linux Build Instructions**
>>> 
>>> +### Pre-requisites
>>> +
>>> +* GIT client: Available from https://git-scm.com/downloads
>>> +* GCC 4.9 compiler or XCODE compiler
>>> +
>>> +Create a new directory for an EDK II WORKSPACE.
>>> +
>>> +The code block below shows the GIT clone operations required to
>>> pull the edk2
>>> +repository, and the edk2-test branch from the edk2-staging
>>> repository.
>>> +
>>> +Next it sets environment variables that must be set before running
>>> +```edksetup.bat```. Since content is being pulled from multiple
>>> repositories,
>>> +the EDK II [Multiple Workspace](
>>> +https://github.com/tianocore/tianocore.github.io/wiki/Multiple_Wor
>>> kspace)
>>> +feature is used.
>>> +
>>> +Next, the ```edksetup.bat``` file is run to complete the
>>> initialization of an
>>> +EDK II build environment.  Two example build commands are
>>> shown.  The first one
>>> +in ```TestFrameworkPkg/TestFrameworkPkg.dsc``` builds a test
>>> harness and creates
>>> +an installer in the build output directory.  The second one in
>>> +```TestCasePkg/TestCasePkg.dsc``` builds a sample test case using
>>> a test library
>>> +from the ```TestFrameworkPkg``` and adds the test case to the
>>> installer in the
>>> +build output directory.
>>> +
>>> +```cmd
>>> +git clone https://github.com/tianocore/edk2.git
>>> +git clone https://github.com/tianocore/edk2-staging.git --branch
>>> edk2-test
>>> +
>>> +export WORKSPACE=`pwd`
>>> +export EDK_TOOLS_PATH="$WORKSPACE/edk2/BaseTools"
>>> +export PACKAGES_PATH="$WORKSPACE/edk2:$WORKSPACE/edk2-staging"
>>> +export
>>> EDK_TOOLS_BIN="$WORKSPACE/edk2/BaseTools/BinWrappers/PosixLike"
>>> +export CONF_PATH="$WORKSPACE/edk2/Conf"
>>> +export PATH="$PATH:$EDK_TOOLS_BIN"
>>> +
>>> +cd edk2
>>> +make -C BaseTools
>>> +. edksetup.sh
>>> +
>>> +build -a IA32 -a X64 -t GCC49 -p
>>> TestFrameworkPkg/TestFrameworkPkg.dsc
>>> +build -a IA32 -a X64 -t GCC49 -p TestCasePkg/TestCasePkg.dsc
>>> +```
>>> +
>>>  ## **Installation Instructions**
>>> 
>>>  * Copy the Build/SctPackage directory to media for the target
>>> platform
>>> --
>>> 2.6.3.windows.1
>>> 
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>
> https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel>