From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in6.apple.com (mail-out6.apple.com [17.151.62.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 40B5881F73 for ; Tue, 31 Jan 2017 15:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1485903774; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JoL9gGyf7b14JxwALPh94Z1hBBa3z+tTnhg1twk+LF8=; b=V6lU4ZSN0f9aC0DyGFA4jAiupqnPMpLbegCfKnKyqlCbrcdHCQS4HyT+2TClt5c5 oTPSf6ft7xPvRqjPEmrxD21ccJgdoI65INqZArocBSpDCjtgS0B46HL3swIGlw1V 4ffD+TTk1fdy7QhPc8pnFhrP1vpsxzuYo1bK7r7GTGh9xAuZot+NanWXFlADYWRW /EkpzSoLaMPSCeDGM6K71VQG8TsjUve4R5tK+5G5MdDdXLSnAQX61VGT7kvgLpz0 8SwvQZ3BQVDDQvDpADLSo2v380MQJ8kYH0q+0IHBLM3WUY3lV0O7CzgRoevTUL4R 7SPBL9cYdQVRd3nM5NU4bQ==; Received: from relay6.apple.com (relay6.apple.com [17.128.113.90]) by mail-in6.apple.com (Apple Secure Mail Relay) with SMTP id F3.A8.09465.E9711985; Tue, 31 Jan 2017 15:02:54 -0800 (PST) X-AuditID: 11973e15-360719a0000024f9-c4-5891179e1bb8 Received: from nwk-mmpp-sz07.apple.com (nwk-mmpp-sz07.apple.com [17.128.115.240]) by relay6.apple.com (Apple SCV relay) with SMTP id 4B.69.00867.E9711985; Tue, 31 Jan 2017 15:02:54 -0800 (PST) MIME-version: 1.0 Received: from [17.153.47.30] (unknown [17.153.47.30]) by nwk-mmpp-sz07.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OKO000RG2OT9V60@nwk-mmpp-sz07.apple.com>; Tue, 31 Jan 2017 15:02:54 -0800 (PST) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Tue, 31 Jan 2017 15:02:52 -0800 In-reply-to: <1485902469.3497.7.camel@arm.com> Cc: Michael Zimmermann , Mike Kinney , "edk2-devel@lists.01.org" To: Supreeth Venkatesh References: <1485888322-56072-1-git-send-email-michael.d.kinney@intel.com> <1485888322-56072-2-git-send-email-michael.d.kinney@intel.com> <1485902469.3497.7.camel@arm.com> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsUi2FAYpTtPfGKEwZRZlhZ7Dh1ltujo+Mdk MXfqU1aLfYf6WR1YPNbMW8PosXPWXXaPxXteMnl0z/7HEsASxWWTkpqTWZZapG+XwJVx//FU xoK2x0wV6zbpNTBO2cnUxcjJISFgIvFy8XHWLkYuDiGBvYwS36fchktcb2pigkgcYpR4s7oJ LMErICjxY/I9FhCbWSBMonfWBTaIog4mibsN68ESwgLiEu/ObGIGsdkElCVWzP/ADtFsI7F9 6hMmiBpfiR+HDzOC2CwCqhLL+46A1XAK6En8mN4JdhKzwBRGicc33rCCJEQEjCUeTTrGCLHt G6PEwluvgRIcQLfKSsz+5QVx9ns2ie0n+CcwCs1CcuwsJMdC2FoS3x+1AsU5gGx5iYPnZSHC mhLP7n1ih7C1JZ68u8C6gJFtFaNQbmJmjm5mnpleYkFBTqpecn7uJkZQ3Ey3E93BeGaV1SFG AQ5GJR7eD6cnRAixJpYVV+YeYpTmYFES5w3jnhghJJCeWJKanZpakFoUX1Sak1p8iJGJg1Oq gTGO8WzKTRep7/tuJe3a/vLTRtWH/9XLLbpcLpSXKb1tqZv8w45Fop1NbFn9z0mzTiSy9Cks l2dc+LCwrWcp36m3f2u1XQ0S9ebcWGpyYffz9xNfOG9s5uns/pNUP+Nn5PRDIabbF838v6vS 42p6SMGWibuyFcV2rdhUfHr6pdYkgf4rp9X7hb2VWIozEg21mIuKEwGd+wb2fAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsUi2FD8QXee+MQIg62z9Cz2HDrKbNHR8Y/J Yu7Up6wW+w71szqweKyZt4bRY+esu+wei/e8ZPLonv2PJYAlissmJTUnsyy1SN8ugSvj/uOp jAVtj5kq1m3Sa2CcspOpi5GTQ0LAROJ6UxOULSZx4d56ti5GLg4hgUOMEm9WQyR4BQQlfky+ xwJiMwuESfTOugBV1MEkcbdhPVhCWEBc4t2ZTcwgNpuAssSK+R/YIZptJLZPfcIEUeMr8ePw YUYQm0VAVWJ53xGwGk4BPYkf0ztZQYYyC0xhlHh84w0rSEJEwFji0aRjjBDbvjFKLLz1GijB AXSrrMTsX14TGAVmITlwFpIDIWwtie+PWoHiHEC2vMTB87IQYU2JZ/c+sUPY2hJP3l1gXcDI topRoCg1J7HSTC+xoCAnVS85P3cTIzgCCqN2MDYstzrEKMDBqMTD++H0hAgh1sSy4spcYChx MCuJ8AqKTowQ4k1JrKxKLcqPLyrNSS0+xDiREejLicxSosn5wPjMK4k3NDExMDE2NjM2Njcx p6WwkjjvNCGgiwTSE0tSs1NTC1KLYI5i4uCUamCc27ZWtV/SZbW8jeHc5Taimy/t+Ry2OSEw smb7xZJciZzgh3ypYgb2znxf563q1/v7ccar43xiU79NaD5is6SHMb36266A5NSX4ew2JW/X /ZYuP6iTIMHR4x4rzLXSTqGylqtId/PJbIk0k9oHB58dX7r78prtv3u+8Z5jDU610+/nbzxd tlKJpTgj0VCLuag4EQBznwFI8wIAAA== X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [staging/edk2-test PATCH 1/6] edk2-test: Update Readme.md X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2017 23:02:55 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Jan 31, 2017, at 2:41 PM, Supreeth Venkatesh wrote: > > On Tue, 2017-01-31 at 20:29 +0100, Michael Zimmermann wrote: >> nothing of importance(and most likely not related to this commit >> because it has been there before), but you misspelled staging as >> 'stagaing' :) >> > 1. Yes. I noticed it too. Will fix this with a new patch. > > 2. I see that there are additional errors when I try to build it with > warnings treated as error flag enabled. > > Examples below: > > CHAR8 *P; > ^ > cc1: all warnings being treated as errors > > /home/supven01/edk2-test/edk2-staging/TestFrameworkPkg/Eftp/EftpRRQ.c: > In function \u2018EftpRrqInitRcvData\u2019: > /home/supven01/edk2-test/edk2- > staging/TestFrameworkPkg/Eftp/EftpRRQ.c:770:24: error: variable > \u2018Opt\u2019 set but not used [-Werror=unused-but-set-variable] > EFTP_OPTION *Opt; > ^ > /home/supven01/edk2-test/edk2-staging/TestFrameworkPkg/Eftp/EftpRRQ.c: > In function \u2018EftpRrqActiveRcvData\u2019: > /home/supven01/edk2-test/edk2- > staging/TestFrameworkPkg/Eftp/EftpRRQ.c:1212:24: error: variable > \u2018Rrq\u2019 set but not used [-Werror=unused-but-set-variable] > EFTP_RRQ_STATE *Rrq; > ^ > /home/supven01/edk2-test/edk2- > staging/TestFrameworkPkg/Eftp/EftpRRQ.c:1211:24: error: variable > \u2018Opt\u2019 set but not used [-Werror=unused-but-set-variable] > EFTP_OPTION *Opt; > > 3. For Linux build, there is a post build failure, GenFramework.sh > corresponding to GenFramework.cmd is missing. Please let me know, if > you already have this file, if not, will fix this in my next patch. > Mike and I talked about that. I think he was looking into porting the script to Python so it would be portable across different operating systems. This failure brings up a more general issue that PREBUILD and POSTBUILD steps don't do a good job in a multi OS setting. Thanks, Andrew Fish > Thanks, > Supreeth >> On Tue, Jan 31, 2017 at 7:45 PM, Michael Kinney >> wrote: >>> >>> * Add Supreeth Venkatesh to list of branch owners >>> * Clean up environment variable for Windows builds >>> * Add Linux Build Instructions >>> >>> Cc: Andrew Fish >>> Cc: Supreeth Venkatesh >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Michael Kinney >>> --- >>> Readme.md | 50 +++++++++++++++++++++++++++++++++++++++++++++++--- >>> 1 file changed, 47 insertions(+), 3 deletions(-) >>> >>> diff --git a/Readme.md b/Readme.md >>> index 4ca0ffa..572014a 100644 >>> --- a/Readme.md >>> +++ b/Readme.md >>> @@ -5,6 +5,7 @@ edk2 repository and platform firmware that is based >>> on the edk2 repository. >>> >>> ## **edk2-stagaing branch owners** >>> * Michael Kinney >>> +* Supreeth Venkatesh >>> >>> ## **Features** >>> * Test harness that runs from the UEFI Shell >>> @@ -76,13 +77,13 @@ build output directory. >>> >>> ```cmd >>> git clone https://github.com/tianocore/edk2.git >>> -git clone https://github.com/tianocore/edk2-staging.git --brach >>> edk2-test >>> +git clone https://github.com/tianocore/edk2-staging.git --branch >>> edk2-test >>> >>> set WORKSPACE=%CD% >>> set EDK_TOOLS_PATH=%WORKSPACE%\edk2\BaseTools >>> +set EDK_TOOLS_BIN=%EDK_TOOLS_PATH%\BinWrappers\WindowsLike >>> set PACKAGES_PATH=%WORKSPACE%\edk2;%WORKSPACE%\edk2-staging >>> -set EDK_TOOLS_BIN=%WORKSPACE%\BaseTools\BinWrappers\WindowsLike >>> -path=%path%;%WORKSPACE%\edk2\BaseTools\Bin\Win32 >>> +path=%path%;%EDK_TOOLS_PATH%\Bin\Win32 >>> >>> cd edk2 >>> edkSetup.bat >>> @@ -93,6 +94,49 @@ build -a IA32 -a X64 -t VS2015x86 -p >>> TestCasePkg/TestCasePkg.dsc >>> >>> ## **Linux Build Instructions** >>> >>> +### Pre-requisites >>> + >>> +* GIT client: Available from https://git-scm.com/downloads >>> +* GCC 4.9 compiler or XCODE compiler >>> + >>> +Create a new directory for an EDK II WORKSPACE. >>> + >>> +The code block below shows the GIT clone operations required to >>> pull the edk2 >>> +repository, and the edk2-test branch from the edk2-staging >>> repository. >>> + >>> +Next it sets environment variables that must be set before running >>> +```edksetup.bat```. Since content is being pulled from multiple >>> repositories, >>> +the EDK II [Multiple Workspace]( >>> +https://github.com/tianocore/tianocore.github.io/wiki/Multiple_Wor >>> kspace) >>> +feature is used. >>> + >>> +Next, the ```edksetup.bat``` file is run to complete the >>> initialization of an >>> +EDK II build environment. Two example build commands are >>> shown. The first one >>> +in ```TestFrameworkPkg/TestFrameworkPkg.dsc``` builds a test >>> harness and creates >>> +an installer in the build output directory. The second one in >>> +```TestCasePkg/TestCasePkg.dsc``` builds a sample test case using >>> a test library >>> +from the ```TestFrameworkPkg``` and adds the test case to the >>> installer in the >>> +build output directory. >>> + >>> +```cmd >>> +git clone https://github.com/tianocore/edk2.git >>> +git clone https://github.com/tianocore/edk2-staging.git --branch >>> edk2-test >>> + >>> +export WORKSPACE=`pwd` >>> +export EDK_TOOLS_PATH="$WORKSPACE/edk2/BaseTools" >>> +export PACKAGES_PATH="$WORKSPACE/edk2:$WORKSPACE/edk2-staging" >>> +export >>> EDK_TOOLS_BIN="$WORKSPACE/edk2/BaseTools/BinWrappers/PosixLike" >>> +export CONF_PATH="$WORKSPACE/edk2/Conf" >>> +export PATH="$PATH:$EDK_TOOLS_BIN" >>> + >>> +cd edk2 >>> +make -C BaseTools >>> +. edksetup.sh >>> + >>> +build -a IA32 -a X64 -t GCC49 -p >>> TestFrameworkPkg/TestFrameworkPkg.dsc >>> +build -a IA32 -a X64 -t GCC49 -p TestCasePkg/TestCasePkg.dsc >>> +``` >>> + >>> ## **Installation Instructions** >>> >>> * Copy the Build/SctPackage directory to media for the target >>> platform >>> -- >>> 2.6.3.windows.1 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel