Performance enabling of Event handler

Performance enabling of Event handler

[prabin ca]

Hi Team,

I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.

Please help me to enable PerformancePkg action on event handler also.

Re: Performance enabling of Event handler

[Laszlo Ersek]

On 09/06/18 08:10, prabin ca wrote:
> Hi Team,
> 
> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.

Do you mean "can not", instead of "can"? (Sorry, I don't understand.)

> 
> Please help me to enable PerformancePkg action on event handler also.
> 

Hmmm, even with the suggested typo correction, I wouldn't know what to
suggest. Sorry!

Laszlo

Re: Performance enabling of Event handler

[prabin ca]

Hi,
PerformancePkg is not working with event handlers, but it’s working with normal functions handlers. 

> On 06-Sep-2018, at 3:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> 
>> On 09/06/18 08:10, prabin ca wrote:
>> Hi Team,
>> 
>> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.
> 
> Do you mean "can not", instead of "can"? (Sorry, I don't understand.)
> 
>> 
>> Please help me to enable PerformancePkg action on event handler also.
>> 
> 
> Hmmm, even with the suggested typo correction, I wouldn't know what to
> suggest. Sorry!
> 
> Laszlo

Re: Performance enabling of Event handler

[Andrew Fish]

Prabin,

Last time I looked every call to PERF_START()/PERF_END() creates a new performance record. So it does not work well for a function that is called a large number of times. 

Thanks,

Andrew Fish

> On Sep 6, 2018, at 7:30 PM, prabin ca <prabinca4u@gmail.com> wrote:
> 
> Hi,
> PerformancePkg is not working with event handlers, but it’s working with normal functions handlers. 
> 
>> On 06-Sep-2018, at 3:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
>> 
>>> On 09/06/18 08:10, prabin ca wrote:
>>> Hi Team,
>>> 
>>> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.
>> 
>> Do you mean "can not", instead of "can"? (Sorry, I don't understand.)
>> 
>>> 
>>> Please help me to enable PerformancePkg action on event handler also.
>>> 
>> 
>> Hmmm, even with the suggested typo correction, I wouldn't know what to
>> suggest. Sorry!
>> 
>> Laszlo

Re: Performance enabling of Event handler

[Bi, Dandan]

Hi Prabin,

The Performance logging for the normal functions handlers and event handlers should be the same.
Are the normal function calls and the event handler function calls you tested in the same module?
If not, please double check to make sure the performance library instance used correctly for each module.


Thanks,
Dandan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of prabin ca
Sent: Friday, September 7, 2018 10:30 AM
To: Laszlo Ersek <lersek@redhat.com>
Cc: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; afish@apple.com
Subject: Re: [edk2] Performance enabling of Event handler

Hi,
PerformancePkg is not working with event handlers, but it’s working with normal functions handlers. 

> On 06-Sep-2018, at 3:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> 
>> On 09/06/18 08:10, prabin ca wrote:
>> Hi Team,
>> 
>> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.
> 
> Do you mean "can not", instead of "can"? (Sorry, I don't understand.)
> 
>> 
>> Please help me to enable PerformancePkg action on event handler also.
>> 
> 
> Hmmm, even with the suggested typo correction, I wouldn't know what to 
> suggest. Sorry!
> 
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: Performance enabling of Event handler

[prabin ca]

Hi 

Yes it is included in same module (both event handler and function handler), and I’m not perf_start and perf_end only two times (one is by event handler and one is by normal function handler).

And I’m trying to print result using DP.efi, it shows entry for normal function.

> On 07-Sep-2018, at 8:46 AM, Bi, Dandan <dandan.bi@intel.com> wrote:
> 
> Hi Prabin,
> 
> The Performance logging for the normal functions handlers and event handlers should be the same.
> Are the normal function calls and the event handler function calls you tested in the same module?
> If not, please double check to make sure the performance library instance used correctly for each module.
> 
> 
> Thanks,
> Dandan
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of prabin ca
> Sent: Friday, September 7, 2018 10:30 AM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; afish@apple.com
> Subject: Re: [edk2] Performance enabling of Event handler
> 
> Hi,
> PerformancePkg is not working with event handlers, but it’s working with normal functions handlers. 
> 
>>> On 06-Sep-2018, at 3:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
>>> 
>>> On 09/06/18 08:10, prabin ca wrote:
>>> Hi Team,
>>> 
>>> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.
>> 
>> Do you mean "can not", instead of "can"? (Sorry, I don't understand.)
>> 
>>> 
>>> Please help me to enable PerformancePkg action on event handler also.
>>> 
>> 
>> Hmmm, even with the suggested typo correction, I wouldn't know what to 
>> suggest. Sorry!
>> 
>> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Performance enabling of Event handler

[Bi, Dandan]

Hi,

DP tool will filter some entries in which the time duration < 1ms by default.
And you can  use the" dp -t 0  "to dump all the Perf entries.
Then to double check whether the entry you care exists or not.


Thanks,
Dandan
-----Original Message-----
From: prabin ca [mailto:prabinca4u@gmail.com] 
Sent: Friday, September 7, 2018 11:57 PM
To: Bi, Dandan <dandan.bi@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>; edk2-devel@lists.01.org; afish@apple.com
Subject: Re: [edk2] Performance enabling of Event handler

Hi 

Yes it is included in same module (both event handler and function handler), and I’m not perf_start and perf_end only two times (one is by event handler and one is by normal function handler).

And I’m trying to print result using DP.efi, it shows entry for normal function.

> On 07-Sep-2018, at 8:46 AM, Bi, Dandan <dandan.bi@intel.com> wrote:
> 
> Hi Prabin,
> 
> The Performance logging for the normal functions handlers and event handlers should be the same.
> Are the normal function calls and the event handler function calls you tested in the same module?
> If not, please double check to make sure the performance library instance used correctly for each module.
> 
> 
> Thanks,
> Dandan
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> prabin ca
> Sent: Friday, September 7, 2018 10:30 AM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; 
> afish@apple.com
> Subject: Re: [edk2] Performance enabling of Event handler
> 
> Hi,
> PerformancePkg is not working with event handlers, but it’s working with normal functions handlers. 
> 
>>> On 06-Sep-2018, at 3:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
>>> 
>>> On 09/06/18 08:10, prabin ca wrote:
>>> Hi Team,
>>> 
>>> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.
>> 
>> Do you mean "can not", instead of "can"? (Sorry, I don't understand.)
>> 
>>> 
>>> Please help me to enable PerformancePkg action on event handler also.
>>> 
>> 
>> Hmmm, even with the suggested typo correction, I wouldn't know what 
>> to suggest. Sorry!
>> 
>> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Performance enabling of Event handler

[prabin ca]

Hi Team,

Thank it’s got worked on dp -t 0.

> On 07-Sep-2018, at 9:27 PM, prabin ca <prabinca4u@gmail.com> wrote:
> 
> Hi 
> 
> Yes it is included in same module (both event handler and function handler), and I’m not perf_start and perf_end only two times (one is by event handler and one is by normal function handler).
> 
> And I’m trying to print result using DP.efi, it shows entry for normal function.
> 
>> On 07-Sep-2018, at 8:46 AM, Bi, Dandan <dandan.bi@intel.com> wrote:
>> 
>> Hi Prabin,
>> 
>> The Performance logging for the normal functions handlers and event handlers should be the same.
>> Are the normal function calls and the event handler function calls you tested in the same module?
>> If not, please double check to make sure the performance library instance used correctly for each module.
>> 
>> 
>> Thanks,
>> Dandan
>> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of prabin ca
>> Sent: Friday, September 7, 2018 10:30 AM
>> To: Laszlo Ersek <lersek@redhat.com>
>> Cc: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; afish@apple.com
>> Subject: Re: [edk2] Performance enabling of Event handler
>> 
>> Hi,
>> PerformancePkg is not working with event handlers, but it’s working with normal functions handlers. 
>> 
>>>> On 06-Sep-2018, at 3:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
>>>> 
>>>> On 09/06/18 08:10, prabin ca wrote:
>>>> Hi Team,
>>>> 
>>>> I’m used edk2 PerformancePkg for profiling cpu execution time taken by a event handler. Event is created successfully and event handler is also called successfully, but I can capture the performance of this event handler with PerformancePkg (by using perf_start and perf_end check points). This PerformancePkg is working fine with normal function calls.
>>> 
>>> Do you mean "can not", instead of "can"? (Sorry, I don't understand.)
>>> 
>>>> 
>>>> Please help me to enable PerformancePkg action on event handler also.
>>>> 
>>> 
>>> Hmmm, even with the suggested typo correction, I wouldn't know what to 
>>> suggest. Sorry!
>>> 
>>> Laszlo
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel