From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa7.dell-outbound.iphmx.com (esa7.dell-outbound.iphmx.com [68.232.153.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F11781A1E74 for ; Thu, 1 Sep 2016 20:25:01 -0700 (PDT) DomainKey-Signature: s=smtpout; d=dell.com; c=simple; q=dns; h=Received:Received:X-LoopCount0:X-IronPort-AV:From:To:CC: Date:Subject:Thread-Topic:Thread-Index:Message-ID: References:In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-tituslabs-classifications-30:x-titus-version: x-tituslabs-classificationhash-30:x-titusconfig: acceptlanguage:Content-Type:MIME-Version:Return-Path; b=T+pgN/VXFG9Ekgm13IO8aGjM6WGd3BMdJTAhALsXJexa+HyJtSPKbqym +H7KvxHzo9MDgmotX/xppa+bnbdycgUD55w4HFF/yrioQ7sYyrllnIbT2 cyaZ9FQvGyzCBYAvNr3pcVFuINwoGV1iiA0Sv797fd76O1J7V0tHA5wgY E=; DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1472786702; x=1504322702; h=from:to:cc:date:subject:message-id:references: in-reply-to:mime-version; bh=rFcmSa0V4pgylHJfvPuWZ6p0BYqwB7gjBwXUakBQC2o=; b=R3N5uFzGvIjx2AzyaztuCO/gkdQy/o7/+/XjVWUVHuMmcpwuPp/CU4x6 +V3UTXKv7rnvnmkkeXxe1fdFzZ4ZirOUFUXXjbST90IuyR0Omc5gIXNQG W+fl0rM2aq/+CsElUwSQclIJiN7m79HS96yWZnhM6V+jgzjN2gKa7lPnN w=; Received: from esa1.dell-outbound2.iphmx.com ([68.232.153.201]) by esa7.dell-outbound.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Sep 2016 22:25:01 -0500 Received: from ausxippc106.us.dell.com ([143.166.85.156]) by esa1.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2016 09:25:00 +0600 X-LoopCount0: from 10.170.28.40 X-IronPort-AV: E=Sophos;i="5.30,269,1470718800"; d="scan'208,217";a="10278587" From: To: , CC: , Date: Fri, 2 Sep 2016 08:54:53 +0530 Thread-Topic: [EDK2] DxeCapsuleLib returns Status Issue Thread-Index: AdH98GtsCy4QvCtoQNmxQMae1pGCQwAANJIAAPYzTiAAADRncAAQyXogAETw8jAAZor5YAADWbZw Message-ID: References: <74D8A39837DF1E4DA445A8C0B3885C50385EE189@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50385F5F75@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50385F87DD@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50385F87DD@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tituslabs-classifications-30: TLPropertyRoot=Dell;Classification=No Restrictions;Sublabels=; x-titus-version: 3.5.29.3 x-tituslabs-classificationhash-30: VgNFIFU9Hx+/nZJb9Kg7Is0WozxXkkz+8S59Mnh/AsC4xb81kBqaYN9SAQhEOOEtDpTl5RrSZb9h/QfMn8oi0X0Jm/zuaeMv04q3aetSCLcADk5ffQUXmfPqsA2mtA4ntDGSyhpSMPSN05JMEuUutqNJ/m1ox81ccl8F0L+PJpxugR4y0rdf8N+1Wasr7If9DW0gW08UU0gBQb0NEVJkG8Dxj/9BPiZJ5tUz+tZs9ovibg2WGOYxY1HMEhr3VtaX x-titusconfig: 1.4AMER acceptlanguage: en-US MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: DxeCapsuleLib returns Status Issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 03:25:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiewen, Already logged defect for Capsule Status Variable on bugzillar tracker (EDK= II) on 31th August. https://tianocore.acgmultimedia.com/show_bug.cgi?id=3D108 Regards, Ankit Singh From: Yao, Jiewen [mailto:jiewen.yao@intel.com] Sent: Friday, September 02, 2016 7:21 AM To: Singh3, Ankit ; edk2-devel@lists.01.org Subject: RE: [EDK2] DxeCapsuleLib returns Status Issue Hi Ankit Singh A reminder: We haven't seen you filing a Bugzilla yet. At same time, we reviewed UEFI spec and raised an open to USWG. (For your i= nformation only) Thank you Yao Jiewen From: Yao, Jiewen Sent: Wednesday, August 31, 2016 8:55 AM To: Ankit_Singh3@Dell.com; edk2-devel@lists.0= 1.org Cc: Yao, Jiewen > Subject: RE: [EDK2] DxeCapsuleLib returns Status Issue Hi Ankit Singh This seems a missing feature in current EDKII. Thanks to catch that. Would you please file a bugzillar tracker, so that it can recorded? The Bugzilla is introduced @ http://www.tianocore.org/news/2016/07/22/Bugzi= lla.html The URL for Bugzilla is @ https://tianocore.acgmultimedia.com/ Thank you Yao Jiewen From: Ankit_Singh3@Dell.com [mailto:Ankit_Sin= gh3@Dell.com] Sent: Tuesday, August 30, 2016 12:05 AM To: Yao, Jiewen > Subject: RE: [EDK2] DxeCapsuleLib returns Status Issue Dell - Internal Use - Confidential Hi Jiewen, Thanks for pointing me to Capsule Status Variable (UEFI spec - Section 7.5= .6), looks like it exactly what I was expecting. But I looked into latest E= DK2 code and could not find it being populated and stored/saved anywhere. Regards, Ankit Singh -----Original Message----- From: Yao, Jiewen [mailto:jiewen.yao@intel.com] Sent: Monday, August 29, 2016 1:29 PM To: Singh3, Ankit ; edk2-devel@lists.01.org Subject: RE: [EDK2] DxeCapsuleLib returns Status Issue Hi That is good problem statement. Do you think we can use Capsule Status Variable to record such information? It is defined in UEFI spec - "7.5.6 UEFI variable reporting on the Success = or any Errors encountered in processing of capsules after restart" The application can use this standard way to check status. Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ankit_Singh3@Dell.com > Sent: Monday, August 29, 2016 3:51 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [EDK2] DxeCapsuleLib returns Status Issue > > Dell - Internal Use - Confidential > Hi EDK2 Developers, > > We are incorporating DxeCapsuleLib for FMP Capsule Update into our > UEFI product, but we are hitting few issues as described below. > > In case of Capsule Update "SetImage" is randomly done for all the FMP > Handles in case Image Type Id GUID and Image Index matches (this is > expected as there might be multiple similar hardware), but looks like > the returns of each FMP update is not handled. > For example if there are 5 FMP handles (can be for different-different > devices) and assume that any particular device handle is at 3rd index, > therefore the update goes through successfully on the 3rd attempt but > since HandleCount value is 5 it tries further with 4th and 5th Handle. > This 4th & 5th Handle attempt can fail for any of the calls within the FM= P Handle "for loop" > (HandleProtocol/GetImageInfo) and hence the final status is returned > as FAILURE to application layer. > > Below is the code-snippet from DxeCapsuleLib.c , in case of > HandleProtocol & GetImageInfo failure, "for" loop for Handle count is > continued and the previous Status value is over-written with this new > return (return from HandleProtocol & GetImageInfo) and finally returned t= o application. > [cid:image001.jpg@01D201F8.38564220] > > > Proposed Solution:- > Can ProcessFmpCapsuleImage() have an extra OUT parameter which gives > the list of all successful FMP Handles along with the updated GUID > values, so that any application can make the judgment of Update > SUCCESS/FAILURE based on FMP Handle and proceed accordingly at applicatio= n layer. > > Regards, > Ankit Singh > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel