From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ma1-aaemail-dr-lapp03.apple.com (ma1-aaemail-dr-lapp03.apple.com [17.171.2.72]) by mx.groups.io with SMTP id smtpd.web11.10011.1618323374865000632 for ; Tue, 13 Apr 2021 07:16:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=t4Wyedz3; spf=pass (domain: apple.com, ip: 17.171.2.72, mailfrom: afish@apple.com) Received: from pps.filterd (ma1-aaemail-dr-lapp03.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp03.apple.com (8.16.0.42/8.16.0.42) with SMTP id 13DE8oYj046512; Tue, 13 Apr 2021 07:16:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=mzY3H3WM1RXWygT4JSGc+Bk7bxu4UylucQ+6zhIRipE=; b=t4Wyedz3EVD/XVCYbA4w7PX5hn7QNhHbGKkBISNZq2jta+eHa82q19+31dWqY+InT/v0 E58V17G58HY9t8NJZIBUtIubizlAVUhG+IlA2asuk0lY+41ejADiot8cy8Um2zsT3T+3 u371vYO1Drc73PF49xUOiMvlIoUzAbjgi12OqUdFhHtuDhy7KgR2wuCLzFmG5NMPZ3IC Jr7s46g+Hg5ns8aMmhE0aZu+edmnuDGNGx7HT9ott7LfbxFYLeRTFN3nvSDHiG2fBFIw YSxRIjmh8k/YaCOgd4KPfSazWxXq8XuPT70fvHR4qhyIZJyPpnsHtMe1/y2VfCgQfp9e 8A== Received: from rn-mailsvcp-mta-lapp02.rno.apple.com (rn-mailsvcp-mta-lapp02.rno.apple.com [10.225.203.150]) by ma1-aaemail-dr-lapp03.apple.com with ESMTP id 37v1knx63v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 13 Apr 2021 07:16:13 -0700 Received: from rn-mailsvcp-mmp-lapp01.rno.apple.com (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14]) by rn-mailsvcp-mta-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.7.20201203 64bit (built Dec 3 2020)) with ESMTPS id <0QRI004SDAB1KFH0@rn-mailsvcp-mta-lapp02.rno.apple.com>; Tue, 13 Apr 2021 07:16:13 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.7.20201203 64bit (built Dec 3 2020)) id <0QRI00G00A9K7300@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Tue, 13 Apr 2021 07:16:13 -0700 (PDT) X-Va-A: X-Va-T-CD: 004664a286f28cb677a60481ed4243ce X-Va-E-CD: 4730c80ee67030d4f2c83e40b4ab0357 X-Va-R-CD: 6f0325faf294bd23a6d751c620be9d51 X-Va-CD: 0 X-Va-ID: ce59eefd-a71c-4f4f-88ec-37fe532d9f48 X-V-A: X-V-T-CD: 004664a286f28cb677a60481ed4243ce X-V-E-CD: 4730c80ee67030d4f2c83e40b4ab0357 X-V-R-CD: 6f0325faf294bd23a6d751c620be9d51 X-V-CD: 0 X-V-ID: b336afea-dfcf-4c15-bcbb-3f0c72e98f3e X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-13_07:2021-04-13,2021-04-13 signatures=0 Received: from [17.235.15.59] (unknown [17.235.15.59]) by rn-mailsvcp-mmp-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.7.20201203 64bit (built Dec 3 2020)) with ESMTPSA id <0QRI00NK6AAZXN00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Tue, 13 Apr 2021 07:16:12 -0700 (PDT) From: "Andrew Fish" Message-id: MIME-version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.1\)) Subject: Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021) Date: Tue, 13 Apr 2021 07:16:11 -0700 In-reply-to: Cc: harlydavidsen@gmail.com, Laszlo Ersek , "Desimone, Nathaniel L" , Rafael Rodrigues Machado , Gerd Hoffmann To: edk2-devel-groups-io , Leif Lindholm References: <16713E6D64EE917D.25648@groups.io> <2379DE31-D6E1-491E-AE22-416085D73765@intel.com> <66e073bb-366b-0559-4a78-fc5e8215aca1@redhat.com> X-Mailer: Apple Mail (2.3654.20.0.2.1) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-13_07:2021-04-13,2021-04-13 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_B5067A81-AD1F-4474-80CA-2425A30651ED" --Apple-Mail=_B5067A81-AD1F-4474-80CA-2425A30651ED Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Leif, Since I have put some brain cells around this area in the past I can be th= e backup and help out too.=20 I=E2=80=99d also point out if you are having issues building or have gener= al questions on how things work it is fine to use the mailing list. I=E2=80= = =99ve got a lot of feedback that folks read or search the mailing list loo= king for answer to their questions so one person asking can help out a lot = of other people.=20 Thanks, Andrew Fish > On Apr 13, 2021, at 5:28 AM, Leif Lindholm wrote: >=20 > Hi all, especially Ethin. >=20 > Apologies for radio silence - last week I was off on holiday, and before= that ... let's just say corporate acquisitions generate some distractions. > Anyway, I'm back, and since I'm down as the mentor for this task, feel f= ree to spam me with any remaining/new questions. >=20 > / > Leif >=20 > On Tue, Apr 6, 2021 at 4:17 PM Ethin Probst > wrote: > I'll attach the bug for the build tools to the BZ shortly. > Laszlo, thanks for that. I don't know their email addresses though. > And yes, I was going to make it device independent, as the majority > (if not all) of UEFI protocols are. >=20 > On 4/6/21, Laszlo Ersek > w= rote: > > On 03/31/21 08:41, Nate DeSimone wrote: > >> Another option is to put the protocol definition in MdeModulePkg and > >> mark it with the EDKII_ prefix. For my last =E2=80=9Ccode first=E2=80= = =9D UEFI spec > >> contribution I did this with the PPI that added up getting added. > > > > The new audio protocol should be generic, only its implementation in > > question should be virtio specific. > > > > Please include Gerd Hoffmann (CC'd) in the protocol design, as well as > > the developers of the virtio-sound device model in QEMU. > > > > Thanks > > Laszlo > > > > > >> > >> > >> > >> Thanks, > >> > >> Nate > >> > >> > >> > >> *From: *> on behal= f of "Andrew Fish via groups.io " > >> > > >> *Reply-To: *"devel@edk2.groups.io " >, > >> "afish@apple.com " > > >> *Date: *Tuesday, March 30, 2021 at 10:54 PM > >> *To: *edk2-devel-groups-io >, > >> "harlydavidsen@gmail.com " > > >> *Cc: *Rafael Rodrigues Machado > > >> *Subject: *Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021) > >> > >> > >> > >> > >> > >> On Mar 30, 2021, at 5:01 PM, Ethin Probst > >> >= > wrote: > >> > >> > >> > >> I'm wondering where exactly I should add the VirtIO sound protoco= l. I > >> just familiarized myself with the build system and am about to te= st > >> it > >> by building OVMF if possible, but I'm wondering where I should > >> actually put the protocol and all that stuff. Maybe there's > >> documentation I've missed as well. > >> > >> > >> > >> Ethin, > >> > >> > >> > >> For the driver I=E2=80=99d match the patter of OVMF [1] and use > >> OvmfPkg/VirtioSoundDxe/. Maybe even use one of the other drivers as a > >> template. > >> > >> > >> > >> The protocol is more of a public thing. I think eventually we would l= ike > >> to publish the protocol in the UEFI Spec (I can help with that part) = and > >> that would mean we put the Protocol definition in > >> MdePkg/Include/Protocol, but we don=E2=80=99t want to do that before = it is > >> standardized as that causes compatibility issues. So this is a =E2=80= = =9Ccode > >> first project=E2=80=9D (code prototype and then contribute to the UEF= I Forum for > >> inclusion in the specification) so we need to follow some code first > >> rules that I don=E2=80=99t remember of the top of my head? So why not= start out > >> the protocol definition OvmfPkg/Include/Protocol. You can also add a > >> test application looks like you can just use the root [2] of OVMF for > >> that. That way the project is not blocked. > >> > >> > >> > >> We can have a conversation on the mailing list about better places to > >> put stuff, and it should be easy enough to move stuff around if > >> everything else is working. > >> > >> > >> > >> [1] find OvmfPkg -iname '*Virtio*.inf' > >> > >> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf > >> > >> OvmfPkg/VirtioScsiDxe/VirtioScsi.inf > >> > >> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf > >> > >> OvmfPkg/Library/VirtioLib/VirtioLib.inf > >> > >> OvmfPkg/VirtioGpuDxe/VirtioGpu.inf > >> > >> OvmfPkg/VirtioBlkDxe/VirtioBlk.inf > >> > >> OvmfPkg/Virtio10Dxe/Virtio10.inf > >> > >> OvmfPkg/VirtioNetDxe/VirtioNet.inf > >> > >> OvmfPkg/VirtioRngDxe/VirtioRng.inf > >> > >> > >> > >> [2] /Volumes/Case/edk2-github/OvmfPkg>git grep APPLICATION -- *.inf | > >> grep MODULE_TYPE > >> > >> EnrollDefaultKeys/EnrollDefaultKeys.inf:13: MODULE_TYPE > >> =3D UEFI_APPLICATION > >> > >> > >> > >> Thanks, > >> > >> > >> > >> Andrew Fish > >> > >> > >> > >> > >> > >> > >> On 3/30/21, Ethin Probst via groups.io > > >> > >> =3Dgmail.com@groups.i= o >> wrote: > >> > >> I agree. Plus, it gives me a chance to finally learn the EDK2 > >> build > >> system and how it works! I've been working on a hobby OS as a > >> side > >> project and, though learning from other code examples from OS= es > >> is > >> fun, I have to say that learning from the firmware code like = from > >> SeaBIOS has been some of the most enlightening and interestin= g > >> times > >> thus far. > >> Thanks for the link to your code, Rafael; once I get virtIO > >> support > >> in, I can work on HDA support, though I might tackle USB supp= ort > >> second and HDA third. We'll see, but VirtIO definitely is com= ing > >> first. > >> > >> As I said before, I look forward to working with all of you > >> wonderful > >> people! > >> > >> On 3/30/21, Rafael Rodrigues Machado > >> > >> >> > >> wrote: > >> > >> This would be amazing so people can continue my work rela= ted > >> to > >> accessibility at BIOS. Something desired by the blind peo= ple > >> since the > >> 90's > >> Just for reference, this is what I have done: > >> > >> > >> https://github.com/RafaelRMachado/Msc_UefiHda_PreOs_Accessibility > >> > >> Thanks > >> Rafael > >> > >> Em seg, 29 de mar de 2021 20:24, Ethin Probst > >> = > > >> escreveu: > >> > >> > >> Hello everyone, > >> > >> This is the first time I've ever contributed to EDK2.= As > >> part of GSoC > >> 2021, I have submitted a proposal to implement a UEFI > >> audio output > >> protocol that will utilize the VirtIO sound driver. I= 've > >> already > >> submitted a draft proposal, and apologize if I've don= e > >> things out of > >> order. This is my first time doing GSoC 2021, and > >> contributing to EDK2 > >> felt like a really fun thing to do! > >> > >> I look forward to working with you guys on this and a= ny > >> future projects! > >> :-) > >> > >> -- > >> Signed, > >> Ethin D. Probst > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> -- > >> Signed, > >> Ethin D. Probst > >> > >> > >> > >> > >> > >> > >> > >> -- > >> Signed, > >> Ethin D. Probst > >> > >> > >> > >> > >> > >>=20 > > > > >=20 >=20 > --=20 > Signed, > Ethin D. Probst >=20 >=20 >=20 >=20 >=20 >=20 --Apple-Mail=_B5067A81-AD1F-4474-80CA-2425A30651ED Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Leif,

Since I have put some brain cells around t= his area in the past I can be the backup and help out too. 

I=E2=80=99d also point out = if you are having issues building or have general questions on how things w= ork it is fine to use the mailing list. I=E2=80=99ve got a lot of feedback = that folks read or search the mailing list looking for answer to their ques= tions so one person asking can help out a lot of other people. 
<= div class=3D"">
Thanks,

Andrew Fish
=
On Apr = 13, 2021, at 5:28 AM, Leif Lindholm <leif@nuviainc.com> wrote:

Hi all, especi= ally Ethin.

Apolo= gies for radio silence - last week I was off on holiday, and before that ..= . let's just say corporate acquisitions generate some distractions.
Anyway, I'm back, and since I'm down as the mentor for this t= ask, feel free to spam me with any remaining/new questions.

/
 &n= bsp;  Leif

On Tue, Apr 6, 2021 at 4:17 PM Ethin Probst <harlydavidsen@gmail.com= > wrote:
I'll attach th= e bug for the build tools to the BZ shortly.
Laszlo, thanks f= or that. I don't know their email addresses though.
And yes, = I was going to make it device independent, as the majority
(i= f not all) of UEFI protocols are.

On 4/6/21, L= aszlo Ersek <lersek@redhat.com> wrote:
> On 03/31/21 08:4= 1, Nate DeSimone wrote:
>> Another option is to put the= protocol definition in MdeModulePkg and
>> mark it wit= h the EDKII_ prefix. For my last =E2=80=9Ccode first=E2=80=9D UEFI spec
>> contribution I did this with the PPI that added up gett= ing added.
>
> The new audio protocol sho= uld be generic, only its implementation in
> question shou= ld be virtio specific.
>
> Please include= Gerd Hoffmann (CC'd) in the protocol design, as well as
>= the developers of the virtio-sound device model in QEMU.
>= ;
> Thanks
> Laszlo
>>
>>
>>
>>
>> Thanks,
>>
>> Nate
>>
>>
>>
>> *From: *<devel@edk2.groups.io> o= n behalf of "Andrew Fish via groups.io"
>> <afish=3Dapple.com@groups.io&g= t;
>> *Reply-To: *"devel@edk2.groups.io" <devel@edk2.groups.= io>,
>> "afish@apple.com" <afish@apple.com>
>> *Date: *Tuesday, March 30, 2021 at 10:54 PM
>&g= t; *To: *edk2-devel-groups-io <devel@edk2.groups.io>,
>= ;> "harlydavidsen@gmail.com" <harlydavidsen@gmail.com>
>> *Cc: *Rafael Rodrigues Machado <rafaelrodrigues.= machado@gmail.com>
>> *Subject: *Re: [edk2-devel= ] VirtIO Sound Driver (GSoC 2021)
>>
>= >
>>
>>
>>>>     On Mar 30, 2021, at 5:01 PM, Ethin= Probst <harlydavidsen@gmail.com
>>    &n= bsp;<mailto:harlydavidsen@gmail.com>> wrote:
>&g= t;
>>
>>
>>&nbs= p;    I'm wondering where exactly I should add the VirtIO sound p= rotocol. I
>>     just familiarized myse= lf with the build system and am about to test
>> it
>>     by building OVMF if possible, but I'= m wondering where I should
>>     actual= ly put the protocol and all that stuff. Maybe there's
>>= ;     documentation I've missed as well.
>&= gt;
>>
>>
>> Et= hin,
>>
>>
>>>> For the driver I=E2=80=99d match the patter of OVMF [= 1] and use
>> OvmfPkg/VirtioSoundDxe/. Maybe even use o= ne of the other drivers as a
>> template.
>>
>>
>>
>&= gt; The protocol is more of a public thing. I think eventually we would lik= e
>> to publish the protocol in the UEFI Spec (I can he= lp with that part) and
>> that would mean we put the Pr= otocol definition in
>> MdePkg/Include/Protocol, but we= don=E2=80=99t want to do that before it is
>> standard= ized as that causes compatibility issues. So this is a =E2=80=9Ccode
>> first project=E2=80=9D (code prototype and then contribute= to the UEFI Forum for
>> inclusion in the specificatio= n) so we need to follow some code first
>> rules that I= don=E2=80=99t remember of the top of my head? So why not start out
>> the protocol definition OvmfPkg/Include/Protocol. You can a= lso add a
>> test application looks like you can just u= se the root [2] of OVMF for
>> that. That way the proje= ct is not blocked.
>>
>>
>>
>> We can have a conversation on the ma= iling list about better places to
>> put stuff, and it = should be easy enough to move stuff around if
>> everyt= hing else is working.
>>
>>
>>
>> [1] find OvmfPkg  -iname '= *Virtio*.inf'
>>
>> OvmfPkg/VirtioP= ciDeviceDxe/VirtioPciDeviceDxe.inf
>>
>= ;> OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
>>
>> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf=
>>
>> OvmfPkg/Library/VirtioLib/Vi= rtioLib.inf
>>
>> OvmfPkg/VirtioGpu= Dxe/VirtioGpu.inf
>>
>> OvmfPkg/Vir= tioBlkDxe/VirtioBlk.inf
>>
>> OvmfP= kg/Virtio10Dxe/Virtio10.inf
>>
>> O= vmfPkg/VirtioNetDxe/VirtioNet.inf
>>
>= > OvmfPkg/VirtioRngDxe/VirtioRng.inf
>>
>>
>>
>> [2] /Volumes/= Case/edk2-github/OvmfPkg>git grep APPLICATION -- *.inf |
&= gt;> grep MODULE_TYPE
>>
>> Enro= llDefaultKeys/EnrollDefaultKeys.inf:13:  MODULE_TYPE
>= ;>     =3D UEFI_APPLICATION
>>
>>
>>
>> Thanks,
>>
>>
>>
>> Andrew Fish
>>
>>
>>
>>
>>
>>
>>     On 3/30/21, Ethin Probs= t via groups.io <http://groups.io/>
>>    &nb= sp;<harlydavidsen=3Dgmail.com@groups.io
>>   =  <mailto:harlydavidsen=3Dgmail.com@groups.io>> wrote:
&g= t;>
>>         I agree. Plu= s, it gives me a chance to finally learn the EDK2
>> bu= ild
>>         system and how = it works! I've been working on a hobby OS as a
>> side<= br class=3D"">>>         project and, though= learning from other code examples from OSes
>> is
>>         fun, I have to say that= learning from the firmware code like from
>>  &nb= sp;      SeaBIOS has been some of the most enlightening and = interesting
>> times
>>   = ;      thus far.
>>      =    Thanks for the link to your code, Rafael; once I get virtIO>> support
>>      &nb= sp;  in, I can work on HDA support, though I might tackle USB support<= br class=3D"">>>         second and HDA thir= d. We'll see, but VirtIO definitely is coming
>>  =        first.
>>
>= >         As I said before, I look forward to w= orking with all of you
>>        &n= bsp;wonderful
>>         peopl= e!
>>
>>       =  On 3/30/21, Rafael Rodrigues Machado
>>  &n= bsp;      <rafaelrodrigues.machado@gmail.com>>         <mailto:rafaelrodrigues.machado@gmail.com>>
>> =        wrote:
>>
>= ;>             This would be amazing = so people can continue my work related
>> to
>>             accessibilit= y at BIOS. Something desired by the blind people
>>&nbs= p;            since the
>>= ;             90's
>>= ;             Just for reference, this i= s what I have done:
>>
>>
>> https://github.com/RafaelRMac= hado/Msc_UefiHda_PreOs_Accessibility
>>
>>             Thanks
>>             Rafael
>>
>>          =    Em seg, 29 de mar de 2021 20:24, Ethin Probst
&g= t;>             <harlydavidsen@gmail.= com>
>>           =  escreveu:
>>
>>
>>                 Hel= lo everyone,
>>
>>    &nb= sp;            This is the first time I've ev= er contributed to EDK2. As
>>       = ;          part of GSoC
>>&nbs= p;                2021, I have subm= itted a proposal to implement a UEFI
>>    &n= bsp;            audio output
&g= t;>                 protoco= l that will utilize the VirtIO sound driver. I've
>>&nb= sp;                already
>>                &nbs= p;submitted a draft proposal, and apologize if I've done
>= >                 things ou= t of
>>             =    order. This is my first time doing GSoC 2021, and
>>                 co= ntributing to EDK2
>>         =        felt like a really fun thing to do!
>>
>>           =      I look forward to working with you guys on this and an= y
>>              &n= bsp;  future projects!
>>      &nbs= p;          :-)
>>
>>                 --=
>>              &nb= sp;  Signed,
>>          =        Ethin D. Probst
>>
>>
>>
>>
>>
>>
>>
>&= gt;
>>
>>       = ;  --
>>         Signed,<= br class=3D"">>>         Ethin D. Probst
>>
>>
>>
>>
>>
>>
>>
>>     --
>&g= t;     Signed,
>>     Eth= in D. Probst
>>
>>
&g= t;>
>>
>>
>>=  
>
>


-- 
Signed,
E= thin D. Probst



<= br class=3D"">
--Apple-Mail=_B5067A81-AD1F-4474-80CA-2425A30651ED--