From: "Fan, ZhijuX" <zhijux.fan@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: [PATCH] BaseTools:The code used to test python module is moved to edksetup
Date: Tue, 30 Apr 2019 02:16:01 +0000 [thread overview]
Message-ID: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF57197@SHSMSX101.ccr.corp.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1582
testing for presence of python modules should be done in edksetup
to reduce impact on subsequent build times.
This code currently exists in BaseTools/Tests/RunTest.py.
This patch is going to fix this issue.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
BaseTools/Tests/RunTests.py | 8 --------
edksetup.sh | 15 +++++++++++++--
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py
index 81af736cd8..e8acf1b348 100644
--- a/BaseTools/Tests/RunTests.py
+++ b/BaseTools/Tests/RunTests.py
@@ -12,14 +12,6 @@
import os
import sys
import unittest
-
-try:
- import distutils.util
-except ModuleNotFoundError:
- sys.exit('''
-Python reported: "No module named 'distutils.util"
-''')
-
import TestTools
def GetCTestSuite():
diff --git a/edksetup.sh b/edksetup.sh
index c7b2e1e201..add18ca7c0 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -177,11 +177,22 @@ function SetupPython()
SetupPython3
}
+function TestUtilModule()
+{
+ if ( $PYTHON_COMMAND -c "import distutils.util" >/dev/null 2>&1 );then
+ return 1
+ else
+ echo Error: "No module named 'distutils.util"
+ return 0
+ fi
+}
+
function SourceEnv()
{
SetWorkspace &&
- SetupEnv
- SetupPython
+ SetupEnv &&
+ SetupPython &&
+ TestUtilModule
}
I=$#
--
2.14.1.windows.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4111 bytes --]
next reply other threads:[~2019-04-30 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 2:16 Fan, ZhijuX [this message]
2019-05-07 3:53 ` [PATCH] BaseTools:The code used to test python module is moved to edksetup Bob Feng
2019-05-08 11:38 ` [edk2-devel] " Leif Lindholm
2019-05-08 11:45 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FAD0D7E0AE0FA54D987F6E72435CAFD50AF57197@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox