From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhijux.fan@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Mon, 06 May 2019 20:05:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 20:05:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,440,1549958400"; d="scan'208";a="322280216" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 06 May 2019 20:05:05 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 6 May 2019 20:05:04 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.33]) with mapi id 14.03.0415.000; Tue, 7 May 2019 11:05:02 +0800 From: "Fan, ZhijuX" To: "devel@edk2.groups.io" , "afish@apple.com" CC: "Gao, Liming" , "Feng, Bob C" , "Fan, ZhijuX" Subject: FW: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes Thread-Topic: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes Thread-Index: AdUEe7SOF0Lb/xo/QTyWjhkmAT2wu///fFwA//94MtA= Date: Tue, 7 May 2019 03:05:02 +0000 Message-ID: References: <5C1A24BA-648D-4A3F-AE88-034073AB5C13@apple.com> In-Reply-To: <5C1A24BA-648D-4A3F-AE88-034073AB5C13@apple.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhijux.fan@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This problem has nothing to do with the file system, We just use the filena= me as a string to compare with other strings Our unittest tested minplatform, Ovmf. This problem was found when buildin= g a platform inside Intel. We've tested it on Linux and Windows. Any question, please let me know. Thanks. Best Regards Fan Zhiju -----Original Message----- From: afish@apple.com [mailto:afish@apple.com]=20 Sent: Tuesday, May 7, 2019 10:31 AM To: devel@edk2.groups.io; Fan, ZhijuX Cc: Gao, Liming ; Feng, Bob C Subject: Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C f= iles with .C suffixes This brings up a question? Do we tests on a file system that is case sensi= tive? Is this just lack of a test case? Thanks, Andrew Fish > On May 6, 2019, at 7:22 PM, Fan, ZhijuX wrote: >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1773 >=20 > Build break if C file suffixes of named .C instead of .c Code not=20 > recognize filenames with .C suffixes. >=20 > This patch adds code to Support both .c file and .C file >=20 > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- > BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py=20 > b/BaseTools/Source/Python/AutoGen/GenMake.py > index 0e0f9fd9b0..858ddedf8e 100644 > --- a/BaseTools/Source/Python/AutoGen/GenMake.py > +++ b/BaseTools/Source/Python/AutoGen/GenMake.py > @@ -1035,7 +1035,8 @@ cleanlib: > CmdTargetDict[CmdSign] =3D "%s %s" % (CmdTargetD= ict[CmdSign], SingleCommandList[-1]) > Index =3D CommandList.index(Item) > CommandList.pop(Index) > - if SingleCommandList[-1].endswith("%s%s.c" % (TAB_S= LASH, CmdSumDict[CmdSign.lstrip('/Fo').rsplit(TAB_SLASH, 1)[0]])): > + if SingleCommandList[-1].endswith("%s%s.c" % (TAB_S= LASH, CmdSumDict[T.Target.SubDir])) or \ > + SingleCommandList[-1].endswith("%s%s.C" % (= TAB_SLASH, CmdSumDict[T.Target.SubDir])): > Cpplist =3D CmdCppDict[T.Target.SubDir] > Cpplist.insert(0, '$(OBJLIST_%d): $(COMMON_DEPS)= ' % list(self.ObjTargetDict.keys()).index(T.Target.SubDir)) > T.Commands[Index] =3D '%s\n\t%s' % ('=20 > \\\n\t'.join(Cpplist), CmdTargetDict[CmdSign]) > -- > 2.14.1.windows.1 >=20 >=20 >=20 >=20 >