public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Fan, ZhijuX" <zhijux.fan@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Shi, Steven" <steven.shi@intel.com>,
	"Lu, Shifei A" <shifei.a.lu@intel.com>,
	"Zhou, Bowen" <bowen.zhou@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>,
	"Chiu, Chasel" <chasel.chiu@intel.com>,
	"Kubacki, Michael A" <michael.a.kubacki@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: [PATCH 2/4] Platform/Intel:Add build parameter to support Binary Cache
Date: Fri, 31 May 2019 01:37:59 +0000	[thread overview]
Message-ID: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF6EB86@SHSMSX101.ccr.corp.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3595 bytes --]

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785

Need extend the options in the Intel/build_bios.py file
to support Binary Cache.

 --hash:
   Enable hash-based caching during build process.
 --binary-destination:
   Generate a cache of binary files in the specified directory.
 --binary-source:
   Consume a cache of binary files from the specified directory.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Steven Shi <steven.shi@intel.com>
Cc: Shifei A Lu <shifei.a.lu@intel.com>
Cc: Xiaohu Zhou <bowen.zhou@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 Platform/Intel/build_bios.py | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py
index 9f8d78f6e8..628b127417 100644
--- a/Platform/Intel/build_bios.py
+++ b/Platform/Intel/build_bios.py
@@ -333,6 +333,7 @@ def build(config):
     print(" SILENT_MODE    = ", config.get("SILENT_MODE"))
     print(" REBUILD_MODE   = ", config.get("REBUILD_MODE"))
     print(" BUILD_ROM_ONLY = ", config.get("BUILD_ROM_ONLY"))
+    print(" BINARY_CACHE_CMD_LINE = ", config.get("HASH"), config.get("BINARY_CACHE_CMD_LINE"))
     print("==========================================")
 
     command = ["build", "-n", config["NUMBER_OF_PROCESSORS"]]
@@ -343,6 +344,10 @@ def build(config):
     if config["EXT_BUILD_FLAGS"] and config["EXT_BUILD_FLAGS"] != "":
         command.append(config["EXT_BUILD_FLAGS"])
 
+    if config.get('BINARY_CACHE_CMD_LINE'):
+        command.append(config['HASH'])
+        command.append(config['BINARY_CACHE_CMD_LINE'])
+
     if config.get("SILENT_MODE", "FALSE") == "TRUE":
         command.append("--silent")
         command.append("--quiet")
@@ -848,6 +853,17 @@ def get_cmd_config_arguments(arguments):
     if arguments.fspapi is True:
         result["API_MODE_FSP_WRAPPER_BUILD"] = "TRUE"
 
+    if not arguments.UseHashCache:
+        result['BINARY_CACHE_CMD_LINE'] = ''
+    elif arguments.BinCacheDest:
+        result['HASH'] = '--hash'
+        result['BINARY_CACHE_CMD_LINE'] = '--binary-destination=%s' % arguments.BinCacheDest
+    elif arguments.BinCacheSource:
+        result['HASH'] = '--hash'
+        result['BINARY_CACHE_CMD_LINE'] = '--binary-source=%s' % arguments.BinCacheSource
+    else:
+        result['BINARY_CACHE_CMD_LINE'] = ''
+
     return result
 
 
@@ -924,6 +940,17 @@ def get_cmd_arguments(build_config):
     parser.add_argument("--fspapi", help="API mode fsp wrapper build enabled",
                         action='store_true', dest="fspapi")
 
+    parser.add_argument("--hash", action="store_true", dest="UseHashCache", default=False,
+                        help="Enable hash-based caching during build process.")
+
+    parser.add_argument("--binary-destination", help="Generate a cache of binary \
+                            files in the specified directory.",
+                        action='store', dest="BinCacheDest")
+
+    parser.add_argument("--binary-source", help="Consume a cache of binary files \
+                                from the specified directory.",
+                        action='store', dest="BinCacheSource")
+
     return parser.parse_args()
 
 
-- 
2.14.1.windows.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4671 bytes --]

             reply	other threads:[~2019-05-31  1:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  1:37 Fan, ZhijuX [this message]
2019-05-31  1:57 ` [PATCH 2/4] Platform/Intel:Add build parameter to support Binary Cache Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FAD0D7E0AE0FA54D987F6E72435CAFD50AF6EB86@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox