[PATCH] BaseTools:Build cache support the cache files for library package

[PATCH] BaseTools:Build cache support the cache files for library package

[Fan, ZhijuX]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1867

Current build cache cannot store the cache for library package.
build -p MdePkg\MdePkg.dsc -a IA32 -b DEBUG -t VS2015x86 --hash
--binary-destination=BinCache
After build, the expected result is the BinCache folder is generated
and the MdePkg build cache files (e.g. .hash and .lib) are stored in
the BinCache folder. But the BinCache folder is not generated at all.

This patch is going to fix that issue.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Steven Shi <steven.shi@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++++
 1 files changed, 4 insertions(+)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
index a879b6259f..b8ecf3826f 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -3571,6 +3571,10 @@ class ModuleAutoGen(AutoGen):
 
         # Skip the following code for libraries
         if self.IsLibrary:
+            try:
+                self.CopyModuleToCache()
+            except:
+                pass
             return
 
         # Skip the following code for modules with no source files
-- 
2.14.1.windows.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 3938 bytes --]

Re: [PATCH] BaseTools:Build cache support the cache files for library package

[Bob Feng]

Zhiju,

There is no error handle for self.CopyModuleToCache(), please don't "pass" in except block.

Thanks,
Bob

-----Original Message-----
From: Fan, ZhijuX 
Sent: Thursday, June 6, 2019 9:26 AM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Shi, Steven <steven.shi@intel.com>
Subject: [PATCH] BaseTools:Build cache support the cache files for library package

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1867

Current build cache cannot store the cache for library package.
build -p MdePkg\MdePkg.dsc -a IA32 -b DEBUG -t VS2015x86 --hash --binary-destination=BinCache After build, the expected result is the BinCache folder is generated and the MdePkg build cache files (e.g. .hash and .lib) are stored in the BinCache folder. But the BinCache folder is not generated at all.

This patch is going to fix that issue.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Steven Shi <steven.shi@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++++
 1 files changed, 4 insertions(+)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
index a879b6259f..b8ecf3826f 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -3571,6 +3571,10 @@ class ModuleAutoGen(AutoGen):
 
         # Skip the following code for libraries
         if self.IsLibrary:
+            try:
+                self.CopyModuleToCache()
+            except:
+                pass
             return
 
         # Skip the following code for modules with no source files
--
2.14.1.windows.1