Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

[rebecca]

On 2019-06-20 20:33, Fan, ZhijuX wrote:
> -      ret=`echo "$origin_version < $python_version" |bc`
> -      if [ "$ret" -eq 1 ]; then
> +      if [ "$origin_version" \< "$python_version" ]; then
>          origin_version=$python_version
>          export PYTHON_COMMAND=$python
>        fi


I think using the "-lt" operator might be better (more standard). e.g.:


if [ "$origin_version" -lt "$python_version" ]; then



-- 
Rebecca Cran

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

[Fan, ZhijuX]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

Hi:

You're right, but at least we won't have to worry about this until “python3.10”

·         And we're comparing directory names, "Python 3.6.6" doesn't appear in the Python version we found

·         We find python applications using “whereis python”   “/usr/bin/python3.6” “/usr/local/bin/python3.6”

·         Later we can compare the form of string length to add a layer of judgment, but we don't need it now.


Any question, please let me know. Thanks.

Best Regards
Fan Zhiju



From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of rebecca@bluestop.org
Sent: Wednesday, June 26, 2019 11:48 PM
To: devel@edk2.groups.io; Fan, ZhijuX <zhijux.fan@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

On 2019-06-25 22:46, Fan, ZhijuX wrote:

Hi:
Python3.6 and python3.7
After the code removes some common values “python”, we compare “3.6” and “3.7”
origin_version = “3.6”, python_version=”3.7”

I'm going to change it to
if [[ "$origin_version" < "$python_version" ]]; then





That's fine for now, hopefully it'll keep working as long as it needs to.

But once you're comparing for example 3.7 and 3.12:

[bcran@photon ~]$ if [[ "3.7" > "3.12" ]]; then echo "wrong!"; else echo "correct!"; fi
wrong!

--
Rebecca Cran


[-- Attachment #2: Type: text/html, Size: 14340 bytes --]

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

[Liming Gao]

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

Push@39744883933eea9674ccaf243cbf565966b8fa74

From: Fan, ZhijuX
Sent: Friday, June 28, 2019 3:49 PM
To: devel@edk2.groups.io; rebecca@bluestop.org
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
Subject: RE: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

Hi:

You're right, but at least we won't have to worry about this until “python3.10”

·         And we're comparing directory names, "Python 3.6.6" doesn't appear in the Python version we found

·         We find python applications using “whereis python”   “/usr/bin/python3.6” “/usr/local/bin/python3.6”

·         Later we can compare the form of string length to add a layer of judgment, but we don't need it now.


Any question, please let me know. Thanks.

Best Regards
Fan Zhiju



From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of rebecca@bluestop.org<mailto:rebecca@bluestop.org>
Sent: Wednesday, June 26, 2019 11:48 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Fan, ZhijuX <zhijux.fan@intel.com<mailto:zhijux.fan@intel.com>>
Cc: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>
Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

On 2019-06-25 22:46, Fan, ZhijuX wrote:

Hi:
Python3.6 and python3.7
After the code removes some common values “python”, we compare “3.6” and “3.7”
origin_version = “3.6”, python_version=”3.7”

I'm going to change it to
if [[ "$origin_version" < "$python_version" ]]; then





That's fine for now, hopefully it'll keep working as long as it needs to.

But once you're comparing for example 3.7 and 3.12:

[bcran@photon ~]$ if [[ "3.7" > "3.12" ]]; then echo "wrong!"; else echo "correct!"; fi
wrong!

--
Rebecca Cran


[-- Attachment #2: Type: text/html, Size: 15841 bytes --]