From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhijux.fan@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 11 Sep 2019 02:00:32 -0700 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 02:00:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="dat'59?scan'59,208,59";a="336192954" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 11 Sep 2019 02:00:31 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 02:00:19 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 02:00:19 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Wed, 11 Sep 2019 17:00:17 +0800 From: "Fan, ZhijuX" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Feng, Bob C" , "Zhang, Shenglei" Subject: [PATCH] BaseTools:Change the case rules for ECC check pointer names Thread-Topic: [PATCH] BaseTools:Change the case rules for ECC check pointer names Thread-Index: AdVof1PDVTViFg83QUqCcuIlL6zA2w== Date: Wed, 11 Sep 2019 09:00:17 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhijux.fan@intel.com X-Groupsio-MsgNum: 47118 Content-Type: multipart/mixed; boundary="_000_FAD0D7E0AE0FA54D987F6E72435CAFD50AFBC930SHSMSX101ccrcor_" Content-Language: en-US --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50AFBC930SHSMSX101ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like this. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Ecc/Check.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Ecc/Check.py b/BaseTools/Source/Python= /Ecc/Check.py index 2180818609..f927d8e4d3 100644 --- a/BaseTools/Source/Python/Ecc/Check.py +++ b/BaseTools/Source/Python/Ecc/Check.py @@ -1469,13 +1469,14 @@ class Check(object): EdkLogger.quiet("Checking naming convention of variable name .= ..") Pattern =3D re.compile(r'^[A-Zgm]+\S*[a-z]\S*$') =20 - SqlCommand =3D """select ID, Name from %s where Model =3D %s""= " % (FileTable, MODEL_IDENTIFIER_VARIABLE) + SqlCommand =3D """select ID, Name, Modifier from %s where Mode= l =3D %s""" % (FileTable, MODEL_IDENTIFIER_VARIABLE) RecordSet =3D EccGlobalData.gDb.TblFile.Exec(SqlCommand) for Record in RecordSet: Var =3D Record[1] + Modifier =3D Record[2] if Var.startswith('CONST'): Var =3D Var[5:].lstrip() - if not Pattern.match(Var): + if not Pattern.match(Var) and not Modifier.endswith('*'): if not EccGlobalData.gException.IsException(ERROR_NAMI= NG_CONVENTION_CHECK_VARIABLE_NAME, Record[1]): EccGlobalData.gDb.TblReport.Insert(ERROR_NAMING_CO= NVENTION_CHECK_VARIABLE_NAME, OtherMsg=3D"The variable name [%s] does not f= ollow the rules" % (Record[1]), BelongsToTable=3DFileTable, BelongsToItem= =3DRecord[0]) =20 --=20 2.14.1.windows.1 --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50AFBC930SHSMSX101ccrcor_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IlwUAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAADg5RjQwRjMz NDI3RkU5NDVBQTVCODhBODBBQUY5NDRCAE4HAQ2ABAACAAAAAgACAAEFgAMADgAAAOMHCQALAAkA AAARAAMAGwEBIIADAA4AAADjBwkACwAJAAAAEQADABsBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAEQAAABbUEFUQ0hdIEJhc2VUb29sczpDaGFuZ2UgdGhlIGNhc2UgcnVs ZXMgZm9yIEVDQyBjaGVjayBwb2ludGVyIG5hbWVzAIEXAQuAAQAhAAAAODlGNDBGMzM0MjdGRTk0 NUFBNUI4OEE4MEFBRjk0NEIATgcBA5AGAGQPAAAzAAAAAgF/AAEAAABIAAAAPEZBRDBEN0UwQUUw RkE1NEQ5ODdGNkU3MjQzNUNBRkQ1MEFGQkM5MzBAU0hTTVNYMTAxLmNjci5jb3JwLmludGVsLmNv bT4ACwAfDgEAAAACAQkQAQAAAKcFAACjBQAA2QkAAExaRnW/SwPbYQAKZmJpZAQAAGNjwHBnMTI1 MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBzZXQwIO8HbQKDAFARTTIKgAa0AoCWfQqACMg7CWIxOQ7A vwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQFsg5QA2Bzom8BgCBFeBHBbhgwXQZSdgSQF7YCEHIAwHR9 CFBuGjEQIAXABaAbZGSaIANSIBAiF7JcdgiQ5HdrC4BkNR1TBPAHQA0XcDAKcRfyYmttawZzAZAA ICBCTV9C4EVHSU59CvwB8QvxER+wWjpoAkBwczrALy9idWd6AxALYCQudAcwbm8FoWUuAQWwZy9z aG93X0EiUS5jZ2k/DdA9oQHQODdcbAuAZQqBRSUUSQOgQ3J5BTBISGtkZiRAICAlEiAONA7AJRsm wEVWUF8AUEtFWV9DVFjoICpwJmJDDNAWICUbPlYKwAcwAmAZ4Ck2IGLOZSRgBjED8HRoJtAj4AUb smESACAncCcsOSUFd2gOUCxgI8F1bMscYCvAIADQY2UFMCrjeyvAHlB1LQEsQDADBCBhLSsgbwuA G6EuJQUoUg8BEBuxGJAmAENTXzKwXzFfRBhwAYAsJyBULjMzUiklDFMyMEXfMlAyEQbwLjkHcHAD YBow9xxgMiEZoWQrAQQBClAEIH0lEGsZ4CxQBAAxNiUFQzBjOiBMB3ALgGcgNEdhMjA8JRA5gi5n tTngQDDibCRAA3A+OLlgQm9iIEYJ8DmwPPUG4GIkQC4x4BnAOs8UwCRpZxhQZC0ZMGYtFGJ5OUBa LfBqdS7SRgORPHo/gng9EABwWT1vCi1B4CfGQizxVDk1IXMvNKAIcC8AL1AmeSxQAiAvRS7wL0MC aAWQay5weSB8sCA1ICtFIEH4MRxw1wMQGeAZlGQzIDMwAACAhRuBaQIgcygrKTMg3DIgAQAecEdk LTO9DeCdASAgQeAkYAVAYS9Cn/tDr0SxYkqPS59EoSUFHbEzEDBH8DE4JNBQIDYwDDkuPRAWgDdk OGWMNGRG8B6RNjQ0QXh/Sm9N7076RSFM31OfTvpAAkBKADE0NjksMaVG8CtYtDQgWHFjC2ArBBFE Uyg8MGoFkHQpBjonx1upRWRrTG8mZxgwMSBxdQiQdCjmIkRTOZJuYTmDG+MCMOVHcSAZMCB2KrZe ERng2VCwLiIztlurUBiAG6FZA6A9ICNROzFwRiEoAHInXltBLVpnAG1dK1xcUypbkGEtel1j0iQn YIejQXZbqlNxbAhQbQOBexxgYlAiZ2ASAB5wWvAgtElEMyBOYAIcgyUsEf9EYAlwBdAEcQMgYlBo 4Gdh0WjQIChGRiFUKuIzIEBNT0RFTF9oAEUATlRJRklFUl8AVkFSSUFCTEX/M7ZVgGXvZv9oBmsR BHAGkP8IkWiPaZ9qr2u/YI9bojHAvQWhZAZgBUBiUEQRRwkAmmIHQEQYgCLAZ0Q84LZUAmByoi4Z cAWQKG4Y/3TvW6Ia4XYlRwF2KFsvW6bnKqFiQXY0WzFkUGzvW6R7cCd+FzJ+tnzPBpB9wi4HH2MD 4SxQKCdDT048U1RksHxPfR99wls1qDpdLlYwdAURKDO232XLgsUjEAVAYdUuGxERwP4oKqGEl38/ iV+KZi7QbpGrjKJwJi4J8GSDxSqEjz+Ln4yidv0ZcS8RR3EuSUpzkycodDBST3RATrRBTSAgRyjQ hEBWc9JrhEAo0Eg00Et0V5TSRf8zIH43j++Y73b/eAIxwDDAvwAgk7BHI5R/lY+Wmk8sUIEEkE1z Zz0iVERg1V9dW3EAXUgQbweRjKLfAhAioCPgN+EZ4HIucAeQN3JTl1gzIEI7AAIgZ3NbVgBy4z1y qaO3SRAgbXo9fjUwl9Bk3lJwJQUy9i5YsKhwLgPwHcAj4DggDwBQJRsVQqqAAB8AQgABAAAAGAAA AEYAYQBuACwAIABaAGgAaQBqAHUAWAAAAB8AZQABAAAAKgAAAHoAaABpAGoAdQB4AC4AZgBhAG4A QABpAG4AdABlAGwALgBjAG8AbQAAAAAAHwBkAAEAAAAKAAAAUwBNAFQAUAAAAAAAAgFBAAEAAABk AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACARgBhAG4ALAAgAFoAaABpAGoAdQBYAAAAUwBNAFQA UAAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAB8AAl0BAAAAKgAA AHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAAAAHwDlXwEAAAAyAAAA cwBpAHAAOgB6AGgAaQBqAHUAeAAuAGYAYQBuAEAAaQBuAHQAZQBsAC4AYwBvAG0AAAAAAB8AGgwB AAAAGAAAAEYAYQBuACwAIABaAGgAaQBqAHUAWAAAAB8AHwwBAAAAKgAAAHoAaABpAGoAdQB4AC4A ZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAAAAHwAeDAEAAAAKAAAAUwBNAFQAUAAAAAAAAgEZ DAEAAABkAAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACARgBhAG4ALAAgAFoAaABpAGoAdQBYAAAA UwBNAFQAUAAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAB8AAV0B AAAAKgAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAAAAHwD4PwEA AAAYAAAARgBhAG4ALAAgAFoAaABpAGoAdQBYAAAAHwAjQAEAAAAqAAAAegBoAGkAagB1AHgALgBm AGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAAAAfACJAAQAAAAoAAABTAE0AVABQAAAAAAACAfk/ AQAAAGQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBGAGEAbgAsACAAWgBoAGkAagB1AFgAAABT AE0AVABQAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAHwAJXQEA AAAqAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAAAALAEA6AQAA AB8AGgABAAAAEgAAAEkAUABNAC4ATgBvAHQAZQAAAAAAAwDxPwkEAAALAEA6AQAAAAMA/T/kBAAA AgELMAEAAAAQAAAAifQPM0J/6UWqW4ioCq+USwMAFwABAAAAQAA5AICmylR/aNUBQAAIMH1cFlV/ aNUBHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAHgAAAGEAYwBjAGUAcAB0AGwAYQBuAGcAdQBhAGcA ZQAAAAAAAQAAAAwAAABlAG4ALQBVAFMAAAAfADcAAQAAAIgAAABbAFAAQQBUAEMASABdACAAQgBh AHMAZQBUAG8AbwBsAHMAOgBDAGgAYQBuAGcAZQAgAHQAaABlACAAYwBhAHMAZQAgAHIAdQBsAGUA cwAgAGYAbwByACAARQBDAEMAIABjAGgAZQBjAGsAIABwAG8AaQBuAHQAZQByACAAbgBhAG0AZQBz AAAAHwA9AAEAAAACAAAAAAAAAAMANgAAAAAAAgFxAAEAAAAWAAAAAdVof1PDVTViFg83QUqCcuIl L6zA2wAAHwBwAAEAAACIAAAAWwBQAEEAVABDAEgAXQAgAEIAYQBzAGUAVABvAG8AbABzADoAQwBo AGEAbgBnAGUAIAB0AGgAZQAgAGMAYQBzAGUAIAByAHUAbABlAHMAIABmAG8AcgAgAEUAQwBDACAA YwBoAGUAYwBrACAAcABvAGkAbgB0AGUAcgAgAG4AYQBtAGUAcwAAAB8ANRABAAAAkAAAADwARgBB AEQAMABEADcARQAwAEEARQAwAEYAQQA1ADQARAA5ADgANwBGADYARQA3ADIANAAzADUAQwBBAEYA RAA1ADAAQQBGAEIAQwA5ADMAMABAAFMASABTAE0AUwBYADEAMAAxAC4AYwBjAHIALgBjAG8AcgBw AC4AaQBuAHQAZQBsAC4AYwBvAG0APgAAAAMA3j+fTgAAQAAHMFc4D1V/aNUBAgELAAEAAAAQAAAA ifQPM0J/6UWqW4ioCq+USwMAJgAAAAAAAgFHAAEAAAAyAAAAYz1VUzthPU1DSTtwPUludGVsO2w9 U0hTTVNYMTAxLTE5MDkxMTA5MDAxN1otOTA2MAAAAAIBEDABAAAARgAAAAAAAAAmd705O+w4SaSm FT3LpXtCBwD60Nfgrg+lTZh/bnJDXK/VAAAARBFeAACmk2g2iHZsS6dK0+tHmkxkAAAJVMAHAAAA AB8A+j8BAAAAGAAAAEYAYQBuACwAIABaAGgAaQBqAHUAWAAAAAMACVkBAAAAQAAAgAggBgAAAAAA wAAAAAAAAEYAAAAAv4UAAJB0ylN/aNUBCwAAgAggBgAAAAAAwAAAAAAAAEYAAAAAgoUAAAAAAAAf AACAhgMCAAAAAADAAAAAAAAARgEAAAAYAAAAZABsAHAALQBwAHIAbwBkAHUAYwB0AAAAAQAAABoA AABkAGwAcABlAC0AdwBpAG4AZABvAHcAcwAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAGAAA AGQAbABwAC0AdgBlAHIAcwBpAG8AbgAAAAEAAAASAAAAMQAxAC4AMgAuADAALgA2AAAAAAAfAACA hgMCAAAAAADAAAAAAAAARgEAAAAaAAAAZABsAHAALQByAGUAYQBjAHQAaQBvAG4AAAAAAAEAAAAU AAAAbgBvAC0AYQBjAHQAaQBvAG4AAAADAA00/T8AAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACAA AAB4AC0AbQBzAC0AaABhAHMALQBhAHQAdABhAGMAaAAAAAEAAAACAAAAAAAAAB8AAICGAwIAAAAA AMAAAAAAAABGAQAAACIAAAB4AC0AbwByAGkAZwBpAG4AYQB0AGkAbgBnAC0AaQBwAAAAAAABAAAA IAAAAFsAMQAwAC4AMgAzADkALgAxADIANwAuADQAMABdAAAAG2o= --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50AFBC930SHSMSX101ccrcor_--