From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.5749.1578629879734451566 for ; Thu, 09 Jan 2020 20:17:59 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhijux.fan@intel.com) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 20:17:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="dat'59?scan'59,208,59";a="272291390" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2020 20:17:58 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 20:17:58 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 20:17:58 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.139]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 12:17:56 +0800 From: "Fan, ZhijuX" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Feng, Bob C" Subject: [PATCH V2] BaseTools:Change the case rules for ECC check pointer names Thread-Topic: [PATCH V2] BaseTools:Change the case rules for ECC check pointer names Thread-Index: AdXHbO2S6i2Q7Y0OSkylu8I7Pm99ow== Date: Fri, 10 Jan 2020 04:17:56 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhijux.fan@intel.com X-Groupsio-MsgNum: 53120 Content-Type: multipart/mixed; boundary="_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B003B7DSHSMSX101ccrcor_" Content-Language: en-US --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B003B7DSHSMSX101ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like this. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Ecc/Check.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Ecc/Check.py b/BaseTools/Source/Python= /Ecc/Check.py index 2180818609..f927d8e4d3 100644 --- a/BaseTools/Source/Python/Ecc/Check.py +++ b/BaseTools/Source/Python/Ecc/Check.py @@ -1469,13 +1469,14 @@ class Check(object): EdkLogger.quiet("Checking naming convention of variable name .= ..") Pattern =3D re.compile(r'^[A-Zgm]+\S*[a-z]\S*$') =20 - SqlCommand =3D """select ID, Name from %s where Model =3D %s""= " % (FileTable, MODEL_IDENTIFIER_VARIABLE) + SqlCommand =3D """select ID, Name, Modifier from %s where Mode= l =3D %s""" % (FileTable, MODEL_IDENTIFIER_VARIABLE) RecordSet =3D EccGlobalData.gDb.TblFile.Exec(SqlCommand) for Record in RecordSet: Var =3D Record[1] + Modifier =3D Record[2] if Var.startswith('CONST'): Var =3D Var[5:].lstrip() - if not Pattern.match(Var): + if not Pattern.match(Var) and not (Modifier.endswith('*') = and Var.startswith('p')): if not EccGlobalData.gException.IsException(ERROR_NAMI= NG_CONVENTION_CHECK_VARIABLE_NAME, Record[1]): EccGlobalData.gDb.TblReport.Insert(ERROR_NAMING_CO= NVENTION_CHECK_VARIABLE_NAME, OtherMsg=3D"The variable name [%s] does not f= ollow the rules" % (Record[1]), BelongsToTable=3DFileTable, BelongsToItem= =3DRecord[0]) =20 --=20 2.14.1.windows.1 --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B003B7DSHSMSX101ccrcor_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IvgtAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAEYyNzBFNDJD NjRCMzc1NDJBMDVCOTk2RTczMjMwRTQyAP0GAQ2ABAACAAAAAgACAAEFgAMADgAAAOQHAQAKAAQA EQA4AAUASAEBIIADAA4AAADkBwEACgAEABEAOAAFAEgBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAEcAAABbUEFUQ0ggVjJdIEJhc2VUb29sczpDaGFuZ2UgdGhlIGNhc2Ug cnVsZXMgZm9yIEVDQyBjaGVjayBwb2ludGVyIG5hbWVzACkYAQuAAQAhAAAARjI3MEU0MkM2NEIz NzU0MkEwNUI5OTZFNzMyMzBFNDIA/QYBA5AGAAwQAAA1AAAAAgF/AAEAAABIAAAAPEZBRDBEN0Uw QUUwRkE1NEQ5ODdGNkU3MjQzNUNBRkQ1MEIwMDNCN0RAU0hTTVNYMTAxLmNjci5jb3JwLmludGVs LmNvbT4ACwAfDgEAAAACAQkQAQAAALIFAACuBQAA8wkAAExaRnWma5KgYQAKZmJpZAQAAGNjwHBn MTI1MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBzZXQwIO8HbQKDAFARTTIKgAa0AoCWfQqACMg7CWIx OQ7AvwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQFsg5QA2Bzom8BgCBFeBHBbhgwXQZSdgSQF7YCEHIA wHR9CFBuGjEQIAXABaAbZGSaIANSIBAiF7JcdgiQ5HdrC4BkNR1TBPAHQA0XcDAKcRfyYmttawZz AZAAICBCTV9C4EVHSU59CvwB8QvxER+wWjpoAkBwczrALy9idWd6AxALYCQudAcwbm8FoWUuAQWw Zy9zaG93X0EiUS5jZ2k/DdA9oQHQODdcbAuAZQqBRSUUSQOgQ3J5BTBISGtkZiRAICAlEiAONA7A JRsmwEVWUF8AUEtFWV9DVFjoICpwJmJDDNAWICUbPlYKwAcwAmAZ4Ck2IGLOZSRgBjED8HRoJtAj 4AUbsmESACAncCcsOSUFd2gOUCxgI8F1bMscYCvAIADQY2UFMCrjeyvAHlB1LQEsQDADBCBhLSsg bwuAG6EuJQUoUg8BEBuxGJAmAENTXzKwXzFfRBhwAYAsJyBULjMzUiklDFMyMEXfMlAyEQbwLjkH cHADYBow9xxgMiEZoWQrAQQBClAEIH0lEGsZ4CxQBAAxNiUFQzBjOiBMB3ALgGcgNEdhMjA8JRA5 gi5ntTngQDDibCRAA3A+OLlgQm9iIEYJ8DmwPPUG4GIkQC4x4BnAOs8UwCRpZxhQZC0ZMGYtFGJ5 OUBaLfBqdS7SRgORPHo/gng9EABwWT1vCi1B4CfGQizxVDk1IXMvNKAIcC8AL1AmeSxQAiAvRS7w L0MCaAWQay5weSB8sCA1ICtFIEH4MRxw1wMQGeAZlGQzIDMwAACAhRuBaQIgcygrKTMg3DIgAQAe cEdkLTO9DeCdASAgQeAkYAVAYS9Cn/tDr0SxYkqPS59EoSUFHbEzEDBH8DE4JNBQIDYwDDkuPRAW gDdkOGWMNGRG8B6RNjQ0QXh/Sm9N7076RSFM31OfTvpAAkBKADE0NjksMaVG8CtYtDQgWHFjC2Ar BBFEUyg8MGoFkHQpBjonx1upRWRrTG8mZxgwMSBxdQiQdCjmIkRTOZJuYTmDG+MCMOVHcSAZMCB2 KrZeERng2VCwLiIztlurUBiAG6FZA6A9ICNROzFwRiEoAHInXltBLVpnAG1dK1xcUypbkGEtel1j 0iQnYIejQXZbqlNxbAhQbQOBexxgYlAiZ2ASAB5wWvAgtElEMyBOYAIcgyUsEf9EYAlwBdAEcQMg YlBo4Gdh0WjQIChGRiFUKuIzIEBNT0RFTF9oAEUATlRJRklFUl8AVkFSSUFCTEX/M7ZVgGXvZv9o BmsRBHAGkP8IkWiPaZ9qr2u/YI9bojHAvQWhZAZgBUBiUEQRRwkAmmIHQEQYgCLAZ0Q84LZUAmBy oi4ZcAWQKG4Y/3TvW6Ia4XYlRwF2KFsvW6bnKqFiQXY0WzFkUGzvW6R7cCd+FzJ+tnzPBpB9wi4H H2MD4SxQKCdDT048U1RksHxPfR99wls1qDpdLlYwdAURKDO232XLgsUjEAVAYdUuGxERwP4oKqGE l38/iV+KZi7QbpFVjKIocCYuCfBkg8Uq72SwjgODPi1AKYSfi6+MsY92/RlxLxFHcS5Jc5THEih0 MFJPdEBOQU3tICBHKNCEQFZz0oRAKNDaSDTQS3RXlnJFMyB+N/+Rj5qPdv94AjHAMMAAIJVQb0cj lh+XL5g6TyxQBJBNYHNnPSJURGBfXVv1cQBdSBBvB5GMogIQIqD3I+A34Rngci5wB5ByU5j4zTMg QjsAAiBnc1YAcuOWPXKppVdJECBtPX41njCZcGTeUnAlBTIuWLD9qhAuA/AdwCPgOCAAUCUbAxVC rCAAAB8AQgABAAAAGAAAAEYAYQBuACwAIABaAGgAaQBqAHUAWAAAAB8AZQABAAAAKgAAAHoAaABp AGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAAAAHwBkAAEAAAAKAAAAUwBNAFQA UAAAAAAAAgFBAAEAAABkAAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACARgBhAG4ALAAgAFoAaABp AGoAdQBYAAAAUwBNAFQAUAAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8A bQAAAB8AAl0BAAAAKgAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAA AAAAHwDlXwEAAAAyAAAAcwBpAHAAOgB6AGgAaQBqAHUAeAAuAGYAYQBuAEAAaQBuAHQAZQBsAC4A YwBvAG0AAAAAAB8AGgwBAAAAGAAAAEYAYQBuACwAIABaAGgAaQBqAHUAWAAAAB8AHwwBAAAAKgAA AHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8AbQAAAAAAHwAeDAEAAAAKAAAA UwBNAFQAUAAAAAAAAgEZDAEAAABkAAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACARgBhAG4ALAAg AFoAaABpAGoAdQBYAAAAUwBNAFQAUAAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwA LgBjAG8AbQAAAB8AAV0BAAAAKgAAAHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBj AG8AbQAAAAAAHwD4PwEAAAAYAAAARgBhAG4ALAAgAFoAaABpAGoAdQBYAAAAHwAjQAEAAAAqAAAA egBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAAAAfACJAAQAAAAoAAABT AE0AVABQAAAAAAACAfk/AQAAAGQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBGAGEAbgAsACAA WgBoAGkAagB1AFgAAABTAE0AVABQAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAu AGMAbwBtAAAAHwAJXQEAAAAqAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMA bwBtAAAAAAALAEA6AQAAAB8AGgABAAAAEgAAAEkAUABNAC4ATgBvAHQAZQAAAAAAAwDxPwkEAAAL AEA6AQAAAAMA/T/kBAAAAgELMAEAAAAQAAAA8nDkLGSzdUKgW5lucyMOQgMAFwABAAAAQAA5AADy Ju9sx9UBQAAIMC8CaO9sx9UBHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAHgAAAGEAYwBjAGUAcAB0 AGwAYQBuAGcAdQBhAGcAZQAAAAAAAQAAAAwAAABlAG4ALQBVAFMAAAAfADcAAQAAAI4AAABbAFAA QQBUAEMASAAgAFYAMgBdACAAQgBhAHMAZQBUAG8AbwBsAHMAOgBDAGgAYQBuAGcAZQAgAHQAaABl ACAAYwBhAHMAZQAgAHIAdQBsAGUAcwAgAGYAbwByACAARQBDAEMAIABjAGgAZQBjAGsAIABwAG8A aQBuAHQAZQByACAAbgBhAG0AZQBzAAAAAAAfAD0AAQAAAAIAAAAAAAAAAwA2AAAAAAACAXEAAQAA ABYAAAAB1cds7ZLqLZDtjQ5KTKW7wjs+b32jAAAfAHAAAQAAAI4AAABbAFAAQQBUAEMASAAgAFYA MgBdACAAQgBhAHMAZQBUAG8AbwBsAHMAOgBDAGgAYQBuAGcAZQAgAHQAaABlACAAYwBhAHMAZQAg AHIAdQBsAGUAcwAgAGYAbwByACAARQBDAEMAIABjAGgAZQBjAGsAIABwAG8AaQBuAHQAZQByACAA bgBhAG0AZQBzAAAAAAAfADUQAQAAAJAAAAA8AEYAQQBEADAARAA3AEUAMABBAEUAMABGAEEANQA0 AEQAOQA4ADcARgA2AEUANwAyADQAMwA1AEMAQQBGAEQANQAwAEIAMAAwADMAQgA3AEQAQABTAEgA UwBNAFMAWAAxADAAMQAuAGMAYwByAC4AYwBvAHIAcAAuAGkAbgB0AGUAbAAuAGMAbwBtAD4AAAAD AN4/n04AAEAABzBrP2PvbMfVAQIBCwABAAAAEAAAAPJw5Cxks3VCoFuZbnMjDkIDACYAAAAAAAIB RwABAAAAMgAAAGM9VVM7YT1NQ0k7cD1JbnRlbDtsPVNIU01TWDEwMS0yMDAxMTAwNDE3NTZaLTcz ODAAAAACARAwAQAAAEYAAAAAAAAAJne9OTvsOEmkphU9y6V7QgcA+tDX4K4PpU2Yf25yQ1yv1QAA AEQRXgAAppNoNoh2bEunStPrR5pMZAAACVTAVgAAAAAfAPo/AQAAABgAAABGAGEAbgAsACAAWgBo AGkAagB1AFgAAAADAAlZAQAAAEAAAIAIIAYAAAAAAMAAAAAAAABGAAAAAL+FAAAQlFfubMfVAQsA AIAIIAYAAAAAAMAAAAAAAABGAAAAAIKFAAAAAAAAAwAAgAggBgAAAAAAwAAAAAAAAEYAAAAA64UA AAkEAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAYAAAAZABsAHAALQBwAHIAbwBkAHUAYwB0AAAA AQAAABoAAABkAGwAcABlAC0AdwBpAG4AZABvAHcAcwAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYB AAAAGAAAAGQAbABwAC0AdgBlAHIAcwBpAG8AbgAAAAEAAAASAAAAMQAxAC4AMgAuADAALgA2AAAA AAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAaAAAAZABsAHAALQByAGUAYQBjAHQAaQBvAG4AAAAA AAEAAAAUAAAAbgBvAC0AYQBjAHQAaQBvAG4AAAACAQCACCAGAAAAAADAAAAAAAAARgEAAAA2AAAA SQBuAFQAcgBhAG4AcwBpAHQATQBlAHMAcwBhAGcAZQBDAG8AcgByAGUAbABhAHQAbwByAAAAAAAB AAAAEAAAAJHZbjsnfjRKiKdjl/iXdScDAA00/T8AAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAACAA AAB4AC0AbQBzAC0AaABhAHMALQBhAHQAdABhAGMAaAAAAAEAAAACAAAAAAAAAB8AAICGAwIAAAAA AMAAAAAAAABGAQAAACIAAAB4AC0AbwByAGkAZwBpAG4AYQB0AGkAbgBnAC0AaQBwAAAAAAABAAAA IAAAAFsAMQAwAC4AMgAzADkALgAxADIANwAuADQAMABdAAAAt4k= --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B003B7DSHSMSX101ccrcor_--