From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.7531.1578645470590420606 for ; Fri, 10 Jan 2020 00:37:50 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhijux.fan@intel.com) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 00:37:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="dat'59?scan'59,208,59";a="230174675" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2020 00:37:49 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 00:37:49 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 00:37:49 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by shsmsx102.ccr.corp.intel.com ([169.254.2.202]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 16:37:47 +0800 From: "Fan, ZhijuX" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Feng, Bob C" Subject: [PATCH V3] BaseTools:Change the case rules for ECC check pointer names Thread-Topic: [PATCH V3] BaseTools:Change the case rules for ECC check pointer names Thread-Index: AdXHkSvYboPrJjYkTDyV+NZr/5Rvrw== Date: Fri, 10 Jan 2020 08:37:46 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhijux.fan@intel.com X-Groupsio-MsgNum: 53145 Content-Type: multipart/mixed; boundary="_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B004C95SHSMSX101ccrcor_" Content-Language: en-US --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B004C95SHSMSX101ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2087 In CryptHkdf.c line 42 EVP_PKEY_CTX *pHkdfCtx; Variable pHkdfCtx begins with lower case 'p', which should be acceptable because it it is a pointer. (Refer to CCS_2_1_Draft, 4.3.3.3) So ECC tool should be improved to handle issues like this. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Ecc/Check.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) update the copyright to 2020 diff --git a/BaseTools/Source/Python/Ecc/Check.py b/BaseTools/Source/Python= /Ecc/Check.py index b68cecddfd..0fdc7e35c1 100644 --- a/BaseTools/Source/Python/Ecc/Check.py +++ b/BaseTools/Source/Python/Ecc/Check.py @@ -1,7 +1,7 @@ ## @file # This file is used to define checkpoints used by ECC tool # -# Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2008 - 2020, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # from __future__ import absolute_import @@ -1469,13 +1469,14 @@ class Check(object): EdkLogger.quiet("Checking naming convention of variable name .= ..") Pattern =3D re.compile(r'^[A-Zgm]+\S*[a-z]\S*$') =20 - SqlCommand =3D """select ID, Name from %s where Model =3D %s""= " % (FileTable, MODEL_IDENTIFIER_VARIABLE) + SqlCommand =3D """select ID, Name, Modifier from %s where Mode= l =3D %s""" % (FileTable, MODEL_IDENTIFIER_VARIABLE) RecordSet =3D EccGlobalData.gDb.TblFile.Exec(SqlCommand) for Record in RecordSet: Var =3D Record[1] + Modifier =3D Record[2] if Var.startswith('CONST'): Var =3D Var[5:].lstrip() - if not Pattern.match(Var): + if not Pattern.match(Var) and not (Modifier.endswith('*') = and Var.startswith('p')): if not EccGlobalData.gException.IsException(ERROR_NAMI= NG_CONVENTION_CHECK_VARIABLE_NAME, Record[1]): EccGlobalData.gDb.TblReport.Insert(ERROR_NAMING_CO= NVENTION_CHECK_VARIABLE_NAME, OtherMsg=3D"The variable name [%s] does not f= ollow the rules" % (Record[1]), BelongsToTable=3DFileTable, BelongsToItem= =3DRecord[0]) =20 --=20 2.14.1.windows.1 --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B004C95SHSMSX101ccrcor_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IvNIAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAEY3MEZDMEEx OEU3RkIyNEZBRkRBMDZEMjgzNDc2MkZCAG4HAQ2ABAACAAAAAgACAAEFgAMADgAAAOQHAQAKAAgA JQAuAAUAVgEBIIADAA4AAADkBwEACgAIACUALgAFAFYBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAEcAAABbUEFUQ0ggVjNdIEJhc2VUb29sczpDaGFuZ2UgdGhlIGNhc2Ug cnVsZXMgZm9yIEVDQyBjaGVjayBwb2ludGVyIG5hbWVzACoYAQuAAQAhAAAARjcwRkMwQTE4RTdG QjI0RkFGREEwNkQyODM0NzYyRkIAbgcBA5AGAOwQAAA1AAAAAgF/AAEAAABIAAAAPEZBRDBEN0Uw QUUwRkE1NEQ5ODdGNkU3MjQzNUNBRkQ1MEIwMDRDOTVAU0hTTVNYMTAxLmNjci5jb3JwLmludGVs LmNvbT4ACwAfDgEAAAACAQkQAQAAAJEGAACNBgAAngsAAExaRnW3X0EJYQAKZmJpZAQAAGNjwHBn MTI1MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBzZXQwIO8HbQKDAFARTTIKgAa0AoCWfQqACMg7CWIx OQ7AvwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQFsg5QA2Bzom8BgCBFeBHBbhgwXQZSdgSQF7YCEHIA wHR9CFBuGjEQIAXABaAbZGSaIANSIBAiF7JcdgiQ5HdrC4BkNR1TBPAHQA0XcDAKcRfyYmttawZz AZAAICBCTV9C4EVHSU59CvwB8QvxER+wWjpoAkBwczrALy9idWd6AxALYCQudAcwbm8FoWUuAQWw Zy9zaG93X0EiUS5jZ2k/DdA9oQHQODdcbAuAZQqBRSUUSQOgQ3J5BTBISGtkZiRAICAlEiAONA7A JRsmwEVWUF8AUEtFWV9DVFjoICpwJmJDDNAWICUbPlYKwAcwAmAZ4Ck2IGLOZSRgBjED8HRoJtAj 4AUbsmESACAncCcsOSUFd2gOUCxgI8F1bMscYCvAIADQY2UFMCrjeyvAHlB1LQEsQDADBCBhLSsg bwuAG6EuJQUoUg8BEBuxGJAmAENTXzKwXzFfRBhwAYAsJyBULjMzUiklDFMyMEXfMlAyEQbwLjkH cHADYBow9xxgMiEZoWQrAQQBClAEIH0lEGsZ4CxQBAAxNiUFQzBjOiBMB3ALgGcgNEdhMjA8JRA5 gi5ntTngQDDibCRAA3A+OLlgQm9iIEYJ8DmwPPUG4GIkQC4x4BnAOs8UwCRpZxhQZC0ZMGYtFGJ5 OUBaLfBqdS7SRgORPHo/gng9EABwWT1vCi1B4CfGQizxVDk1IXMvNKAIcC8AL1AmeSxQAiAvRS7w L0MCaAWQay5weSB8sCA3ICtFIUHpMRxw9wMQGeAZlGQzITAAAIAbgUJpAiBzKCspMyAzLiABAB5w R4QtM70gddxwZBiAN9JGYW9EsAUQ/mch0DISAdAMASUbDeABIM4gQeAkYAVAYS9Cn0Ov/USxYk1f Tm9EoSUFHbEQMEkrsDY4LwBjZCaAZAguLjAFcGM3ZTOMNWNGEB6RNjQ0QXh/TT9Qv1HKRSFPr1Zv UcpA8kBM0DEsRQFbgltAJ8b8IyNcAEYyXDcSQDgBRiT/MHEv0TZzAQEm8hHARHEww/9ehT8wNMdc N0F2XMAIUErGeChjKUthJNBM0EthMd44MyAl4DrxYnFyMMAYcdFHkS4gQSKgIErjBCCHCXBHUTZR LjxCUjtm/itib2N2AdBkH2UvZj9dkuBTUERYLTlgLwBHQXwtSQEAAjAGkAiRPAFTYEQtMi1DC2Av 0S0eUEohAjBhXhx0X19m9HV0CHBlcKA18gkRLtBuYhkgCkAQIF9xVFraNPA2OSwxSCBbwHNzRxBd W0FjC2AEEURTKDwwajEFkHQpOifHdllFZDBrTG9nGDAxIHF1MQiQdCgiRFM5km5hLzmDG+NtgQIg IBkwIHbPKrZ4wRngU4AuIjO2dlu3buEboQOgPWsBOyJwRkEAKHInXltBLVoAZ21dK1xcUyogW2Et el1+giQnR3s3QXZ2WlNxbAhQbfcDgRxgfQAighASAB5wdaC1aSBEMyBOerIcgyUsEf9EYAlwBdAE cQMgfQCDkIIRa4OAYxBGRkFUKuIzIE0gT0RFTF+CsEVOAFRJRklFUl9WgEFSSUFCTEUztv9YUICf ga+CtoXBBHBto4M/f4RPhV+Gb3s/dlIxwAWhZK8GYAVAfQBEEUcJAGIHQKZEGIAiwGdEPOBUAmDt jVIuGXAFkCiIyI+fdlL/GuGQ1UchkNh133ZWKqF88fmQ5FsxfwCHn3ZUiteYx94ymWaXfwaQmHIu H2MD4QEsUCgnQ09OU1QPf2CW/5fPmHJbNTpd6i5ZAHQFESgztoB7nXW3IxAFQHyFLhsREcAoKqF/ n0eZ76QPpRYu0IlBp1Io1YrWLgnwZJ51Kn9gqLP7ne4tQCmfT6Zfp2GRrRlxUy8RahJJc693KI7g UqJPjvBOQU0gIEco0F2e8FaOgp7wKNBINNBL+48HsSJFMyCY56w/tT+Rr/+SsjHAcXKwAEdDsM+x 37LqAk9KYXJNc2c9Ildd0Bngehxbi7BdSDBvvweRp1ICECKgI+BKU3IucG8HkI0Ds6gzIEI7AAIg Z7ZzWNCNkz2NWcAHSRAg9G09mOUwtCB/jlVAJQXsMi5zYMTALgPwHcAj4B84IABQJRsVQsbQAAAA HwBCAAEAAAAYAAAARgBhAG4ALAAgAFoAaABpAGoAdQBYAAAAHwBlAAEAAAAqAAAAegBoAGkAagB1 AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAAAAfAGQAAQAAAAoAAABTAE0AVABQAAAA AAACAUEAAQAAAGQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBGAGEAbgAsACAAWgBoAGkAagB1 AFgAAABTAE0AVABQAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAA HwACXQEAAAAqAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAAAAf AOVfAQAAADIAAABzAGkAcAA6AHoAaABpAGoAdQB4AC4AZgBhAG4AQABpAG4AdABlAGwALgBjAG8A bQAAAAAAHwAaDAEAAAAYAAAARgBhAG4ALAAgAFoAaABpAGoAdQBYAAAAHwAfDAEAAAAqAAAAegBo AGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBtAAAAAAAfAB4MAQAAAAoAAABTAE0A VABQAAAAAAACARkMAQAAAGQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBGAGEAbgAsACAAWgBo AGkAagB1AFgAAABTAE0AVABQAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMA bwBtAAAAHwABXQEAAAAqAAAAegBoAGkAagB1AHgALgBmAGEAbgBAAGkAbgB0AGUAbAAuAGMAbwBt AAAAAAAfAPg/AQAAABgAAABGAGEAbgAsACAAWgBoAGkAagB1AFgAAAAfACNAAQAAACoAAAB6AGgA aQBqAHUAeAAuAGYAYQBuAEAAaQBuAHQAZQBsAC4AYwBvAG0AAAAAAB8AIkABAAAACgAAAFMATQBU AFAAAAAAAAIB+T8BAAAAZAAAAAAAAACBKx+kvqMQGZ1uAN0BD1QCAAAAgEYAYQBuACwAIABaAGgA aQBqAHUAWAAAAFMATQBUAFAAAAB6AGgAaQBqAHUAeAAuAGYAYQBuAEAAaQBuAHQAZQBsAC4AYwBv AG0AAAAfAAldAQAAACoAAAB6AGgAaQBqAHUAeAAuAGYAYQBuAEAAaQBuAHQAZQBsAC4AYwBvAG0A AAAAAAsAQDoBAAAAHwAaAAEAAAASAAAASQBQAE0ALgBOAG8AdABlAAAAAAADAPE/CQQAAAsAQDoB AAAAAwD9P+QEAAACAQswAQAAABAAAAD3D8Chjn+yT6/aBtKDR2L7AwAXAAEAAABAADkAACmEO5HH 1QFAAAgwRrUEPJHH1QEfAACAhgMCAAAAAADAAAAAAAAARgEAAAAeAAAAYQBjAGMAZQBwAHQAbABh AG4AZwB1AGEAZwBlAAAAAAABAAAADAAAAGUAbgAtAFUAUwAAAB8ANwABAAAAjgAAAFsAUABBAFQA QwBIACAAVgAzAF0AIABCAGEAcwBlAFQAbwBvAGwAcwA6AEMAaABhAG4AZwBlACAAdABoAGUAIABj AGEAcwBlACAAcgB1AGwAZQBzACAAZgBvAHIAIABFAEMAQwAgAGMAaABlAGMAawAgAHAAbwBpAG4A dABlAHIAIABuAGEAbQBlAHMAAAAAAB8APQABAAAAAgAAAAAAAAADADYAAAAAAAIBcQABAAAAFgAA AAHVx5Er2G6D6yY2JEw8lfjWa/+Ub68AAB8AcAABAAAAjgAAAFsAUABBAFQAQwBIACAAVgAzAF0A IABCAGEAcwBlAFQAbwBvAGwAcwA6AEMAaABhAG4AZwBlACAAdABoAGUAIABjAGEAcwBlACAAcgB1 AGwAZQBzACAAZgBvAHIAIABFAEMAQwAgAGMAaABlAGMAawAgAHAAbwBpAG4AdABlAHIAIABuAGEA bQBlAHMAAAAAAB8ANRABAAAAkAAAADwARgBBAEQAMABEADcARQAwAEEARQAwAEYAQQA1ADQARAA5 ADgANwBGADYARQA3ADIANAAzADUAQwBBAEYARAA1ADAAQgAwADAANABDADkANQBAAFMASABTAE0A UwBYADEAMAAxAC4AYwBjAHIALgBjAG8AcgBwAC4AaQBuAHQAZQBsAC4AYwBvAG0APgAAAAMA3j+f TgAAQAAHMORTAjyRx9UBAgELAAEAAAAQAAAA9w/AoY5/sk+v2gbSg0di+wMAJgAAAAAAAgFHAAEA AAAyAAAAYz1VUzthPU1DSTtwPUludGVsO2w9U0hTTVNYMTAxLTIwMDExMDA4Mzc0NlotNzc4NwAA AAIBEDABAAAARgAAAAAAAAAmd705O+w4SaSmFT3LpXtCBwD60Nfgrg+lTZh/bnJDXK/VAAAARBFe AACmk2g2iHZsS6dK0+tHmkxkAAAJVMBaAAAAAB8A+j8BAAAAGAAAAEYAYQBuACwAIABaAGgAaQBq AHUAWAAAAAMACVkBAAAAQAAAgAggBgAAAAAAwAAAAAAAAEYAAAAAv4UAAPDDOjuRx9UBCwAAgAgg BgAAAAAAwAAAAAAAAEYAAAAAgoUAAAAAAAADAACACCAGAAAAAADAAAAAAAAARgAAAADrhQAACQQA AB8AAICGAwIAAAAAAMAAAAAAAABGAQAAABgAAABkAGwAcAAtAHAAcgBvAGQAdQBjAHQAAAABAAAA GgAAAGQAbABwAGUALQB3AGkAbgBkAG8AdwBzAAAAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAY AAAAZABsAHAALQB2AGUAcgBzAGkAbwBuAAAAAQAAABIAAAAxADEALgAyAC4AMAAuADYAAAAAAB8A AICGAwIAAAAAAMAAAAAAAABGAQAAABoAAABkAGwAcAAtAHIAZQBhAGMAdABpAG8AbgAAAAAAAQAA ABQAAABuAG8ALQBhAGMAdABpAG8AbgAAAAIBAIAIIAYAAAAAAMAAAAAAAABGAQAAADYAAABJAG4A VAByAGEAbgBzAGkAdABNAGUAcwBzAGEAZwBlAEMAbwByAHIAZQBsAGEAdABvAHIAAAAAAAEAAAAQ AAAAG3inxByMb0O1jheKUcghNgMADTT9PwAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAIAAAAHgA LQBtAHMALQBoAGEAcwAtAGEAdAB0AGEAYwBoAAAAAQAAAAIAAAAAAAAAHwAAgIYDAgAAAAAAwAAA AAAAAEYBAAAAIgAAAHgALQBvAHIAaQBnAGkAbgBhAHQAaQBuAGcALQBpAHAAAAAAAAEAAAAgAAAA WwAxADAALgAyADMAOQAuADEAMgA3AC4ANAAwAF0AAAD54A== --_000_FAD0D7E0AE0FA54D987F6E72435CAFD50B004C95SHSMSX101ccrcor_--